[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989

--- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi, I've been following this dev with interest, but failed to add my comments
promptly. Sorry for that.

One of the reasons we've been chasing leaks in the OPAC regarding hidden
things, is because, too often, we don't use the same logic in all places (in
which it is meaningful to do so, of course).

With that in mind, we added things like

Koha::Item->hidden_in_opac
Koha::Biblio->hidden_in_opac

So, to add my stamp, I would like this logic to be added to
Koha::Biblio->hidden_in_opac instead, and leave the controllers untouched.
Tests should cover all cases and we will be (forever?) sure we don't leak
things anymore.

I have doubts about opac-tags.pl, which has a more convoluted logic in it, and
probably needs a rewrite (I think it is the missing piece in all this
refactoring we've been doing).

-- 
You are receiving this mail because:
You are watching all bug changes.