[Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029

--- Comment #12 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Caroline Cyr La Rose from comment #11)
> In my opinion (for what it is worth, probably two cents only!),
> AllowPatronToControlAutorenewal is ok as it is, because it does what the
> title of the syspref says it does. I do think we need a master switch for
> this feature, like the ILLModule syspref. 
> 
> The syspref could be called simply Autorenewal. 
> Enable/Disable the auto-renewal feature.
> NOTE: This system preference requires the
> misc/cronjobs/automatic_renewals.pl cronjob. Ask your system administrator
> to schedule it. 
> NOTE: You must configure the auto-renewal settings in your circulation rules.
> 
> This system preference would do what Chris said above
> > * hid[e] the "Allow auto-renewal of items" choice in the Library Management
> > settings for the patron.
> > * hid[e] the three columns in the circulation rules that deal with Auto Renewal.
> 
> A note should be added to AllowPatronToControlAutorenewal and
> OPACFineNoRenewalsBlockAutoRenew
> NOTE: This system preference has no effect if Autorenewal is set to Disable.

Wondering why a completely new switch would be better than a disable option in
this one.  That would be like having an on/off switch for a light, and a
completely separate dimmer to control it.  Creating a whole new switch makes
more for admins to sift through and one more thing that we have to look at to
make something work and an added failure point.  Unless I am missing something,
it would be ideal to have the disable option in the same pref.  Adding a
disable option to the pref would not change the nature of the pref, and it
would still do what the name of the pref says.  Making admins chase down
another pref to disable this pref is inefficient.  ANYWHERE we can put a
disable in a pref rather than having a separate pref is an improvement, in my
opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.