[Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21754,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23129

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Putting down some investigations:

Commit 66f1605c59763613a4e955fd259a845e4fc06324 (bug 21754) introduces the
ModItem call to adjust holdingbranch, and the tests.
If we checkout this commit and comment the ModItem call, the tests fail with:
    #   Failed test 'Lost item with cancelled hold has holding branch
equallying the transfers source branch'
    #   at t/db_dependent/Circulation.t line 2481.
    #          got: 'e9cN2ZmqsE'
    #     expected: 'OIL0DThSY1'

It proves that the test is correct.


However, on master (f096a8dffc), the tests still pass if we comment the current
line:
  Koha::Items->find($itemnumber)->holdingbranch($frombranch)->store({
skip_record_index => $params->{skip_record_index} });

It may be something we fixed with bug 23129, which patched in ModItemTransfer,
but if we look at the code there are conditionals to reach ModItemTransfer.

Trusting Martin, Kyle and Nick as I don't have more time to investigate this.

-- 
You are receiving this mail because:
You are watching all bug changes.