From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 00:21:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Jan 2021 23:21:05 +0000 Subject: [Koha-bugs] [Bug 27534] koha upgrade throws SQL error while applying Bug 25333 - Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27534 --- Comment #8 from Manos PETRIDIS --- I don't think that I can test the patch Jonathan, as I'm not running a git installation, but one based on koha packages. I can report though that the mere addition of "ON DELETE CASCADE ON UPDATE CASCADE" won't do he trick in an existing db, as it comes up with Kernel error: Error( 1005 ) HY000: "Can't create table `koha_usmarc`.`letter` (errno: 121 "Duplicate key on write or update")" What I have done is first ALTER TABLE letter drop CONSTRAINT message_transport_type_fk 01:12:50 Query time: 91 millisecond(s) 01:12:50 Query has been executed and then ALTER TABLE letter ADD CONSTRAINT message_transport_type_fk FOREIGN KEY (message_transport_type) REFERENCES message_transport_types(message_transport_type) ON DELETE CASCADE ON UPDATE CASCADE 01:13:21 Query time: 518 millisecond(s), Number of affected records: 62 01:13:21 Number of affected rows: 62 Having done that, the failing update now works fine UPDATE message_transport_types SET message_transport_type = "asdf" WHERE message_transport_type = "email" 01:13:51 Query time: 223 millisecond(s), Number of affected records: 1 01:13:51 Number of affected rows: 1 01:13:51 UPDATE message_transport_types SET message_transport_type = "asdf" WHERE message_transport_type = "email" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 03:20:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 02:20:08 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #700 from Aleisha Amohia --- Switching back to Signed Off as was the status before recent rebasing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 03:39:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 02:39:23 +0000 Subject: [Koha-bugs] [Bug 27573] Use of NOW() in SQL should be avoided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27573 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Better yet we should use UTC dates in the database :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 03:40:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 02:40:11 +0000 Subject: [Koha-bugs] [Bug 27577] Autolink bibs after generating the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27577 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 03:43:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 02:43:32 +0000 Subject: [Koha-bugs] [Bug 18416] Audio alerts: Add a hint that the upload file tool can be used for adding custom sound files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18416 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- (In reply to Cab Vinton from comment #0) > Think of the possibilities -- Warnings in Darth Vader's voice. Reminders in > a soothing British accent. Etc. > https://www.youtube.com/watch?v=97b6FfQbibM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 04:17:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 03:17:15 +0000 Subject: [Koha-bugs] [Bug 22579] Split actions in z3950 search results so Import is the main action and make clicking title pop up Card Preview In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #27 from Aleisha Amohia --- Looks like my comment was ignored and Bug 23302 has been pushed through, so we can close this one :) *** This bug has been marked as a duplicate of bug 23302 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 04:17:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 03:17:15 +0000 Subject: [Koha-bugs] [Bug 23302] Less clicks on Z3950 search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #40 from Aleisha Amohia --- *** Bug 22579 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 04:19:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 03:19:54 +0000 Subject: [Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from Aleisha Amohia --- I'll work on that ^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 04:29:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 03:29:35 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #276 from David Cook --- Who is working on this one now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 04:40:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 03:40:50 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #236 from David Cook --- Thanks, Jonathan. I haven't looked at it yet, but I'm hoping I'll get the time to do so at some point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 07:08:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 06:08:32 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Abdulaziz qn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azoz141415 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 09:42:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 08:42:18 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115991|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 116136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116136&action=edit Bug 26274: Add cashups api routes This patch creates a Koha::Cash::Register::Cashup(s) class pair which subclass Koha::Cash::Register::Action(s) and moves the cashup specific code into these new classes to improve code separation. We then introduce API routes based on these classes to allow fetching a list of cashups associated to a cash register and a full cashup with emeddable summary for individual cashups. Test plan 1/ Run the updated unit tests. t/db_dependent/Koha/Cash/Register/Action.t t/db_dependent/Koha/Cash/Register/Cashup.t 2/ Run the incuded api tests. t/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 09:42:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 08:42:22 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115992|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 116137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116137&action=edit Bug 26274: Update register.tt to use the API This patch updates the existing register details page to utilise the new api routes to gather the summary details on demand. Test plan 1/ Enable cash registers 2/ Add some transactions 3/ Perform a cashup 4/ Click 'Summary' next to the last cashup date 5/ Note the modal appears as it did prior to the patch being applied. 6/ Check the print option still works 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 09:42:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 08:42:50 +0000 Subject: [Koha-bugs] [Bug 26272] Allow cashup summaries to be displayed from the library summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115993|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 116138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116138&action=edit Bug 26272: Add ajax driven cashup modal to library page This patch adds an ajax driven cashup summary modal to the library registers summary page. Test plan 1/ Enable UseCashRegisters in the system preferences 2/ Add at least one cash register to your library 3/ Make some payments of various types (Cash, Card) against the cash register 4/ View the register transactions details page 5/ Make a refund against a payment 6/ Cashup 7/ View the cashup summary by clicking on the 'Summary' link on the register page. 8/ Navigate to the 'libraries' summary page 9/ View the cashup summary by clicking on the 'Summary' link in the registers table. 10/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 09:45:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 08:45:24 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:13:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:13:13 +0000 Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115445|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:19:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:19:27 +0000 Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #16 from Fridolin Somers --- (In reply to Fridolin Somers from comment #8) > And what do you think displaying the version below "About Koha" in main page > ? > Since version is displayed is this page about.pl Can we also add it in main page ? "About Koha" under "Koha administration" ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:30:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:30:13 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:36:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:36:38 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #217 from Jonathan Druart --- Created attachment 116139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116139&action=edit Bug 20212: Add missing html filter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:37:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:37:05 +0000 Subject: [Koha-bugs] [Bug 27486] Rename system preference delimiter to CSVDelimiter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27486 --- Comment #10 from Jonathan Druart --- Created attachment 116140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116140&action=edit Bug 27486: Fix UsageStats.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:37:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:37:24 +0000 Subject: [Koha-bugs] [Bug 25670] Add useful methods to Koha::Acquisition::Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 --- Comment #14 from Jonathan Druart --- Created attachment 116141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116141&action=edit Bug 25670: Fix random failure on Orders.t It has failed at least 3 times: # Failed test 'The right order is returned' # at t/db_dependent/Koha/Acquisition/Orders.t line 153. # got: '50' # expected: '49' # Failed test 'The right order is returned' # at t/db_dependent/Koha/Acquisition/Orders.t line 154. # got: '49' # expected: '50' # Looks like you failed 2 tests of 6. I cannot manage to make it fail locally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:39:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:39:28 +0000 Subject: [Koha-bugs] [Bug 25670] Add useful methods to Koha::Acquisition::Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 --- Comment #15 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:39:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:39:37 +0000 Subject: [Koha-bugs] [Bug 27486] Rename system preference delimiter to CSVDelimiter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27486 --- Comment #11 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:40:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:40:09 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #218 from Jonathan Druart --- Oops, looks like I forgot to amend the changes I made locally to add the filter! Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:56:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:56:02 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:56:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:56:05 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116136|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 116142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116142&action=edit Bug 26274: Add cashups api routes This patch creates a Koha::Cash::Register::Cashup(s) class pair which subclass Koha::Cash::Register::Action(s) and moves the cashup specific code into these new classes to improve code separation. We then introduce API routes based on these classes to allow fetching a list of cashups associated to a cash register and a full cashup with emeddable summary for individual cashups. Test plan 1/ Run the updated unit tests. t/db_dependent/Koha/Cash/Register/Action.t t/db_dependent/Koha/Cash/Register/Cashup.t 2/ Run the incuded api tests. t/ Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:56:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:56:08 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116137|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 116143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116143&action=edit Bug 26274: Update register.tt to use the API This patch updates the existing register details page to utilise the new api routes to gather the summary details on demand. Test plan 1/ Enable cash registers 2/ Add some transactions 3/ Perform a cashup 4/ Click 'Summary' next to the last cashup date 5/ Note the modal appears as it did prior to the patch being applied. 6/ Check the print option still works 7/ Signoff Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 10:57:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 09:57:48 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 --- Comment #12 from David Nind --- I've signed off, but just checking about this step in the test plab: 2/ Run the incuded api tests. t/ I ran prove t/, so I hope that is what was required here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 11:11:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 10:11:44 +0000 Subject: [Koha-bugs] [Bug 27339] Display opac notes and opac messages on check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27339 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114856|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 116144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116144&action=edit Bug 27339: Display opac notes and opac messages on check-in . Adds Opac note (borrowers.opacnote) and Opac messages (messages table) during check-in. Test plan: 1- Add an Opac note and one or several Opac messages to a patron. 2- Checkout and check-in an item for this patron. 3- Check that Opac note and Opac message(s) are not displayed on check-in. 4- Apply the patch. 5- Checkout and check-in an item for this patron. 6- Check that Opac note and Opac message(s) are displayed on check-in. Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 11:13:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 10:13:34 +0000 Subject: [Koha-bugs] [Bug 27339] Display opac notes and opac messages on check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27339 Stina Hallin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |stina.hallin at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 12:34:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 11:34:28 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116142|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 116145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116145&action=edit Bug 26274: Add cashups api routes This patch creates a Koha::Cash::Register::Cashup(s) class pair which subclass Koha::Cash::Register::Action(s) and moves the cashup specific code into these new classes to improve code separation. We then introduce API routes based on these classes to allow fetching a list of cashups associated to a cash register and a full cashup with emeddable summary for individual cashups. Test plan 1/ Run the updated unit tests. t/db_dependent/Koha/Cash/Register/Action.t t/db_dependent/Koha/Cash/Register/Cashup.t 2/ Run the incuded api tests. t/db_dependent/api/v1/cashups.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 12:34:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 11:34:31 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116143|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 116146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116146&action=edit Bug 26274: Update register.tt to use the API This patch updates the existing register details page to utilise the new api routes to gather the summary details on demand. Test plan 1/ Enable cash registers 2/ Add some transactions 3/ Perform a cashup 4/ Click 'Summary' next to the last cashup date 5/ Note the modal appears as it did prior to the patch being applied. 6/ Check the print option still works 7/ Signoff Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 12:35:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 11:35:33 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 --- Comment #15 from Martin Renvoize --- (In reply to David Nind from comment #12) > I've signed off, but just checking about this step in the test plab: > > 2/ Run the incuded api tests. > t/ > > I ran prove t/, so I hope that is what was required here. Oops, seems I missed writing the actual test name in that second point.. however you will have inadvertently run it by running t/ I've fixed the commit message to include it now :) Thanks David :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 12:35:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 11:35:59 +0000 Subject: [Koha-bugs] [Bug 26272] Allow cashup summaries to be displayed from the library summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116138|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 116147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116147&action=edit Bug 26272: Add ajax driven cashup modal to library page This patch adds an ajax driven cashup summary modal to the library registers summary page. Test plan 1/ Enable UseCashRegisters in the system preferences 2/ Add at least one cash register to your library 3/ Make some payments of various types (Cash, Card) against the cash register 4/ View the register transactions details page 5/ Make a refund against a payment 6/ Cashup 7/ View the cashup summary by clicking on the 'Summary' link on the register page. 8/ Navigate to the 'libraries' summary page 9/ View the cashup summary by clicking on the 'Summary' link in the registers table. 10/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:04:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:04:52 +0000 Subject: [Koha-bugs] [Bug 27580] NULL values not correctly handled in Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27580 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:05:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:05:42 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112509|0 |1 is obsolete| | --- Comment #40 from Andrew Isherwood --- Created attachment 116148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116148&action=edit Bug 24190: Add acquisition logging Signed-off-by: Maura Stephens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:05:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:05:45 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112510|0 |1 is obsolete| | --- Comment #41 from Andrew Isherwood --- Created attachment 116149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116149&action=edit Bug 24190: (follow-up) Cancel order del item bug If an order is cancelled but the associated bib / items are unable to be removed, we go into error handling. We still need to log the cancellation though. So this fix moves the logging to just after the cancellation, so it will be logged regardless of the outcome with associated things. Signed-off-by: Maura Stephens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:05:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:05:49 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112511|0 |1 is obsolete| | --- Comment #42 from Andrew Isherwood --- Created attachment 116150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116150&action=edit Bug 24190: (follow-up) Respond to QA feedback This commit makes changes in response to Jonathan's feedback in comment - Moved from using zero padded strings to store log data to a JSON object - Stopped storing formatted dates in logged data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:05:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:05:52 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112512|0 |1 is obsolete| | --- Comment #43 from Andrew Isherwood --- Created attachment 116151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116151&action=edit Bug 24190: (follow-up) Add tests In response to Jonathan's request for tests, I have now added additional tests for the methods in C4/Budgets.pm that do logging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:05:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:05:56 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112513|0 |1 is obsolete| | --- Comment #44 from Andrew Isherwood --- Created attachment 116152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116152&action=edit Bug 24190: (follow-up) Fix erroneous tabs The QA script was reporting forbidden tabs in some of the lines in this bug, these have now been removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:05:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:05:59 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112514|0 |1 is obsolete| | --- Comment #45 from Andrew Isherwood --- Created attachment 116153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116153&action=edit Bug 24190: (follow-up) Modify order of logging Basket creation involves two steps in Koha, creating the basket then modifying its header. We were logging these two steps in the wrong order. This commit fixes that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:06:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:06:36 +0000 Subject: [Koha-bugs] [Bug 27581] UseICU is a misnamed systempreference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27581 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:06:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:06:39 +0000 Subject: [Koha-bugs] [Bug 27581] UseICU is a misnamed systempreference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27581 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116082|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 116154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116154&action=edit Bug 27581: Rename USeICU preference to UseICUStyleQuotes Rather thna have a poorly named preference with an explanation of how it doesn't do what it implies it does, let's rename it! To test: 1 - Set UseICU to 'Using' 2 - Go to the details page of a record in the staff interface 3 - Hover over a subject heading that has subfields 4 - Note the link has curly brackets around the subject, like: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=su:{Winnie-the-Pooh Fictitious character} 5 - Change UseICU to 'Not using' 6 - Note the link is now: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Winnie-the-Pooh Fictitious character" 7 - Repeat on OPAC 8 - Apply patch 9 - Restart all 10 - Repeat tests, the behaviour has not changed 11 - Read the new syspref description and confirm it makes sense Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:06:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:06:57 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #46 from Andrew Isherwood --- Revised test plan: Setup: 1. Apply patch and run database update if necessary 2. Enable AcqLog syspref Order line cancellations: 1. Go to "Aquisitions", find an open basket with at least one order 2. Cancel the order and confirm the cancellation 3. From the staff main page, go to "Reports > Create from SQL" 4. Name the report "Order line cancellations" 5. In the SQL box, enter the report labelled "Order line cancellations" in comment #26 above 6. Save the report, the run it, choosing a start and end date 7. TEST => Observe that the order cancellation you just carried out is listed Order line creations: 1. Go to "Aquisitions", find or create an open basket 2. Create a new order in the basket 3. From the staff main page, go to "Reports > Create from SQL" 4. Name the report "Order line creations" 5. In the SQL box, enter the report labelled "Order line creations" in comment #26 above 6. Save the report, the run it, choosing a start and end date 7. TEST => Observe that the order creation you just carried out is listed Invoice adjustment additions: 1. Go to "Aquisitions", find or create an invoice 2. Click "Add an adjustment" 3. Fill in the details of the adjustment, then click "Update adjustments" 4. From the staff main page, go to "Reports > Create from SQL" 5. Name the report "Invoice adjustment additions" 6. In the SQL box, enter the report labelled "Invoice adjustment additions" in comment #26 above 7. Save the report, the run it, choosing a start and end date 8. TEST => Observe that the adjustment creation you just carried out is listed Invoice adjustment amendments: 1. Go to "Aquisitions", find the invoice from the previous steps 2. Find the adjustment you added and modify it 3. Click "Update adjustments" 4. From the staff main page, go to "Reports > Create from SQL" 5. Name the report "Invoice adjustment amendments" 6. In the SQL box, enter the report labelled "Invoice adjustment amendments" in comment #26 above 7. Save the report, the run it, choosing a start and end date 8. TEST => Observe that the adjustment amendment you just carried out is listed Invoice adjustment deletions: 1. Go to "Aquisitions", find the invoice from the previous steps 2. Find the adjustment you added and delete it 3. From the staff main page, go to "Reports > Create from SQL" 4. Name the report "Invoice adjustment deletions" 5. In the SQL box, enter the report labelled "Invoice adjustment deletions" in comment #26 above 6. Save the report, the run it, choosing a start and end date 7. TEST => Observe that the adjustment deletion you just carried out is listed Order line receipts against an invoice: 1. Go to "Aquisitions", find an open invoice with unreceived items 2. Go to the "Receipt summary" page 3. Click "Receive" for an item 4. Fill in the data as appropriate, then click "Save" 5. From the staff main page, go to "Reports > Create from SQL" 6. Name the report "Order line receipts against an invoice" 7. In the SQL box, enter the report labelled "Order line receipts against an invoice" in comment #26 above 8. Save the report, the run it, choosing a start and end date 9. TEST => Observe that the receipt you just carried out is listed Budget adjustments: 1. Go to "Aquisitions", find a budget 2. Click "Actions" > "Edit" 3. Modify some properties of the budget 4. Click "Save" 5. From the staff main page, go to "Reports > Create from SQL" 6. Name the report "Budget adjustments" 7. In the SQL box, enter the report labelled "Budget adjustments" in comment #26 above 8. Save the report, the run it, choosing a start and end date 9. TEST => Observe that the adjustment you just carried out is listed, including details of the "before" and "after" values Fund adjustments: 1. Go to "Aquisitions", find a fund 2. Click "Actions" > "Edit" 3. Modify some properties of the fund 4. Click "Submit" 5. From the staff main page, go to "Reports > Create from SQL" 6. Name the report "Fund adjustments" 7. In the SQL box, enter the report labelled "Fund adjustments" in comment #26 above 8. Save the report, the run it, choosing a start and end date 9. TEST => Observe that the adjustment you just carried out is listed, including details of the "before" and "after" values Order release date (1): 1. Go to "Aquisitions", find an open basket 2. Close the basket, noting it's ID 3. From the staff main page, go to "Reports > Create from SQL" 4. Name the report "Order release date (1)" 5. In the SQL box, enter the report labelled "Order release date (1)" in comment #26 above 6. Save the report, the run it, choosing a start and end date and basket ID 7. TEST => Observe that the details of the closed basket are listed Order release date (2): 1. Release a basket via an EDI message, resulting in a row in edifact_messages table 3. From the staff main page, go to "Reports > Create from SQL" 4. Name the report "Order release date (2)" 5. In the SQL box, enter the report labelled "Order release date (2)" in comment #26 above 6. Save the report, the run it, choosing a start and end date and basket ID 7. TEST => Observe that the details of the released orders are listed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:07:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:07:01 +0000 Subject: [Koha-bugs] [Bug 27581] UseICU is a misnamed systempreference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27581 --- Comment #5 from Nick Clemens --- (In reply to Katrin Fischer from comment #3) > Hi Nick, I am sorry, but some unrelated changes slipped into this patch: > koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt Oops, reverted those -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:07:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:07:37 +0000 Subject: [Koha-bugs] [Bug 27402] Add column filtering to the Datatables REST API wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27402 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This development adds release notes| |native DataTables column | |filtering to the REST API | |wrapper. This allows easily | |adding column filters to | |DataTables using the REST | |API. | |A sample | |implementation is added to | |the cities admin page, for | |reference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:08:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:08:05 +0000 Subject: [Koha-bugs] [Bug 24190] Add additional Acquisition logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 --- Comment #47 from Andrew Isherwood --- (In reply to Nick Clemens from comment #39) > I will retest the rest once this applies Hi Nick - thanks so much for your efforts on this one! :-) I've now rebased it (having first rebased the bug it depends on). Hopefully this time it will work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:08:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:08:21 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27568 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:08:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:08:21 +0000 Subject: [Koha-bugs] [Bug 27568] Add "Edit your search" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27568 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22605 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:11:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:11:47 +0000 Subject: [Koha-bugs] [Bug 27582] New: Breadcrumb incorrect for POS: Library details page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 Bug ID: 27582 Summary: Breadcrumb incorrect for POS: Library details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The 'Library details' summary page for the Point of Sale module is missing the current page in the breadcrumb. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:16:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:16:03 +0000 Subject: [Koha-bugs] [Bug 27582] Breadcrumb incorrect for POS: Library details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 --- Comment #1 from Martin Renvoize --- Created attachment 116155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116155&action=edit Bug 27582: Fix breadcrumb This patch adds a link back to the top level 'Point of sale' page in the breadcrumb for the 'Library details' summary page. Test plan 1/ Enable 'UseCashRegisters' and 'EnablePointOfSale' 2/ Navigate to 'Point of sale' > 'Library details' 3/ Note the breadcrumb now includes the unlinked' Library details' page title and a linked 'Point of sale' in the list. 4/ Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:39:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:39:04 +0000 Subject: [Koha-bugs] [Bug 27463] OAI-PMH date handling in ListBase.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27463 --- Comment #6 from Ere Maijala --- Haha, thanks. So, is there really an issue that I'm failing to see here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:47:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:47:47 +0000 Subject: [Koha-bugs] [Bug 27402] Add column filtering to the Datatables REST API wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:51:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:51:36 +0000 Subject: [Koha-bugs] [Bug 27582] Breadcrumb incorrect for POS: Library details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:51:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:51:42 +0000 Subject: [Koha-bugs] [Bug 27582] Breadcrumb incorrect for POS: Library details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:51:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:51:52 +0000 Subject: [Koha-bugs] [Bug 27582] Breadcrumb incorrect for POS: Library details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:52:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:52:33 +0000 Subject: [Koha-bugs] [Bug 27582] Breadcrumb incorrect for POS: Library details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Assignee|martin.renvoize at ptfs-europe |koha-bugs at lists.koha-commun |.com |ity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:52:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:52:33 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 [Bug 27582] Breadcrumb incorrect for POS: Library details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:52:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:52:41 +0000 Subject: [Koha-bugs] [Bug 27582] Breadcrumb incorrect for POS: Library details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:56:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:56:53 +0000 Subject: [Koha-bugs] [Bug 27583] New: Clarify how cash management fits together Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 Bug ID: 27583 Summary: Clarify how cash management fits together Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The new(ish) cash management options in Koha aren't clearly defined... you can enable parts of the system without enabling all of it. We should try to clarify the module by more clearly defining how it fits together. I propose to add a 'Cash management' heading under 'Tools' to move the 'Cashuup registers' option to and renaming some of the interface area's to better clarify their purposes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:56:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:56:58 +0000 Subject: [Koha-bugs] [Bug 27583] Clarify how cash management fits together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:56:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:56:58 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 [Bug 27583] Clarify how cash management fits together -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:57:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:57:03 +0000 Subject: [Koha-bugs] [Bug 27583] Clarify how cash management fits together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:57:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:57:18 +0000 Subject: [Koha-bugs] [Bug 27583] Clarify how cash management fits together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 [Bug 27582] Breadcrumb incorrect for POS: Library details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:57:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:57:18 +0000 Subject: [Koha-bugs] [Bug 27582] Breadcrumb incorrect for POS: Library details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 [Bug 27583] Clarify how cash management fits together -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:59:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:59:49 +0000 Subject: [Koha-bugs] [Bug 27584] New: Improve OAI-PMH provider performance Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 Bug ID: 27584 Summary: Improve OAI-PMH provider performance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: ere.maijala at helsinki.fi QA Contact: testopia at bugs.koha-community.org Currently Koha's OAI-PMH provider is using LIMIT and OFFSET to return a chunk of records for each request. While it works relatively well for a small to medium database, it gets prohibitely expensive for a large database especially when items are included and there are a lot of them. I believe this can be improved by using biblionumber for choosing the starting point of the chunk. Patch coming up soon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 13:59:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 12:59:57 +0000 Subject: [Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:10:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 13:10:20 +0000 Subject: [Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:17:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 13:17:56 +0000 Subject: [Koha-bugs] [Bug 27583] Clarify how cash management fits together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 --- Comment #1 from Martin Renvoize --- Created attachment 116156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116156&action=edit Bug 27583: Proposed terminology changes This patch impliments some terminology changes and clarifications for the cash management system Test plan 1/ Apply the patches 2/ Enable 'UseCashRegisters' 3/ Navigate around the cash management system (via the Tools menu) 4/ Enable 'EnablePointOfSale' 5/ Navigate around the cash management system (via the Point of sale module) 6/ Comment on what you think about the changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:18:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 13:18:10 +0000 Subject: [Koha-bugs] [Bug 27583] Clarify how cash management fits together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:19:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 13:19:01 +0000 Subject: [Koha-bugs] [Bug 27583] Clarify how cash management fits together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |lucy.vaux-harvey at ptfs-europ | |e.com, oleonard at myacpl.org, | |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:27:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 13:27:28 +0000 Subject: [Koha-bugs] [Bug 27583] Clarify how cash management fits together In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27583 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116156|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 116157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116157&action=edit Bug 27583: Proposed terminology changes This patch impliments some terminology changes and clarifications for the cash management system Test plan 1/ Apply the patches 2/ Enable 'UseCashRegisters' 3/ Navigate around the cash management system (via the Tools menu) 4/ Enable 'EnablePointOfSale' 5/ Navigate around the cash management system (via the Point of sale module) 6/ Comment on what you think about the changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:40:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 13:40:52 +0000 Subject: [Koha-bugs] [Bug 14004] Add ability to temporarily disable added CSS and Javascript in OPAC and interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.03 released in| | --- Comment #19 from Fridolin Somers --- Small but very usefull feature, I choose to backport. Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:42:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 13:42:15 +0000 Subject: [Koha-bugs] [Bug 25670] Add useful methods to Koha::Acquisition::Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:44:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 13:44:09 +0000 Subject: [Koha-bugs] [Bug 27353] Return the number of total records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27353 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #20 from Fridolin Somers --- What do you say about backporting to 20.11.x ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:45:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 13:45:35 +0000 Subject: [Koha-bugs] [Bug 27402] Add column filtering to the Datatables REST API wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27402 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #17 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:45:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 13:45:48 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #219 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 14:47:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 13:47:29 +0000 Subject: [Koha-bugs] [Bug 20238] Show description of ITEMTYPECAT instead of code in itemtypes summary table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Fridolin Somers --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:03:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:03:15 +0000 Subject: [Koha-bugs] [Bug 27582] Breadcrumb incorrect for POS: Library details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:03:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:03:18 +0000 Subject: [Koha-bugs] [Bug 27582] Breadcrumb incorrect for POS: Library details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27582 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116155|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 116158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116158&action=edit Bug 27582: Fix breadcrumb This patch adds a link back to the top level 'Point of sale' page in the breadcrumb for the 'Library details' summary page. Test plan 1/ Enable 'UseCashRegisters' and 'EnablePointOfSale' 2/ Navigate to 'Point of sale' > 'Library details' 3/ Note the breadcrumb now includes the unlinked' Library details' page title and a linked 'Point of sale' in the list. 4/ Signoff Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:06:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:06:32 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:14:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:14:11 +0000 Subject: [Koha-bugs] [Bug 27334] Add Template Toolkit support to news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:14:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:14:13 +0000 Subject: [Koha-bugs] [Bug 27334] Add Template Toolkit support to news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334 --- Comment #7 from Kyle M Hall --- Created attachment 116159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116159&action=edit Bug 27334: Add unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:29:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:29:47 +0000 Subject: [Koha-bugs] [Bug 14822] Fine totals on circulation.pl don't include manually added fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- The charges on this page are those relating to the checkouts - a manual fine for an item is not tied to the checkout, so I don't think it makes sense to include them -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:31:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:31:02 +0000 Subject: [Koha-bugs] [Bug 14822] Fine totals on circulation.pl don't include manually added fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14822 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|NEW |In Discussion --- Comment #4 from Andrew Fuerste-Henry --- I'd argue "fine" is consistently understood across Koha to mean "overdue fine" specifically. I' am not in favor of making the "fine" column here also include other fees. Especially since this is in the checkouts table and those other fees would not be inherently linked to the checkout of this item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:55:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:55:41 +0000 Subject: [Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 --- Comment #8 from Nick Clemens --- Created attachment 116160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116160&action=edit Bug 27380: (follow-up) Remove earlier declaration and unused assignment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:59:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:59:35 +0000 Subject: [Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:59:38 +0000 Subject: [Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115047|0 |1 is obsolete| | Attachment #115048|0 |1 is obsolete| | Attachment #116160|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 116161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116161&action=edit Bug 27380: Add 'list' option to Koha report parameters TODO: Need to address the svc endpoints To test: 1 - Create a 'New SQL report' like: SELECT * FROM items WHERE itemnumber IN <> 2 - Run the report 3 - You should have a text area where you can enter various itemnumbers 4 - Enter some valid and invalid itemnumbers 5 - You get the info for the valid itemnumbers, no error for the others 6 - Test adding other params to the report and ensure things still work as expected Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:59:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:59:41 +0000 Subject: [Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 --- Comment #10 from Owen Leonard --- Created attachment 116162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116162&action=edit Bug 27380: Move get_prepped_report to object and use for svc/reports This patch moves get_prepped_report to Koha:Report->prep_report and adds some basic tests To test: 1 - Using the report created in last test, hit the report svc api like: http://localhost:8081/cgi-bin/koha/svc/report?id=6¶m_name=One&sql_params=One¶m_name=Listy|list&sql_params=2345%0D%0A423%0D%0A3%0D%0A2%0D%0A12 2 - Note the use of %0D%0A to separate list params 3 - Test with combinations with and without param_name specified http://localhost:8081/cgi-bin/koha/svc/report?id=6&sql_params=5&sql_params=2345%0D%0A423%0D%0A3%0D%0A2%0D%0A12 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 15:59:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 14:59:44 +0000 Subject: [Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 --- Comment #11 from Owen Leonard --- Created attachment 116163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116163&action=edit Bug 27380: (follow-up) Remove earlier declaration and unused assignment Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:00:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:00:31 +0000 Subject: [Koha-bugs] [Bug 9762] Log circulation overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org --- Comment #4 from Michael Adamyk --- As a consortia library, this would also be helpful for us. If we have librarians overriding restrictions (such as circulation rules), it can cause problems if the rules are for another library. Knowing which login is doing this would help track down what's going on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:01:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:01:46 +0000 Subject: [Koha-bugs] [Bug 9762] Log circulation overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #5 from Michael Adamyk --- As a consortia library, this would also be helpful for us. If we have librarians overriding restrictions (such as circulation rules), it can cause problems if the rules are for another library. Knowing which login is doing this would help track down what's going on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:06:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:06:49 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:06:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:06:52 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #3 from Jonathan Druart --- Created attachment 116164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116164&action=edit Bug 27569: Remove non mysql code Remove a bit of the confusion by removing unless code (not related to mysql) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:06:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:06:55 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #4 from Jonathan Druart --- Created attachment 116165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116165&action=edit Bug 27569: Don't hide errors! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:06:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:06:58 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #5 from Jonathan Druart --- Created attachment 116166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116166&action=edit Bug 27569: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:07:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:07:01 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #6 from Jonathan Druart --- Created attachment 116167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116167&action=edit Bug 27569: Fix CSV export for biblio frameworks The CSV import of the biblio frameworks is broken. A change in LibreOffice resulted in CSV not formatted how the C4::ImportExportFramework code is expected. This code is quite broken, it expects all the CSV cells to be quoted. The "add tests" patch shows the different between what we expected before this patch, and what is the new version generated by LibreOffice. Test plan: Export a biblio framework in CSV Open it with LibreOffice and save it undef a different name Create a new biblio framework and use the new file to construct it Compare the 2 frameworks and make sure they are identical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:07:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:07:04 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #7 from Jonathan Druart --- Created attachment 116168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116168&action=edit Bug 27569: Add tests for ODS export Looks ok so far -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:07:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:07:08 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #8 from Jonathan Druart --- Created attachment 116169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116169&action=edit Bug 27569: Change av for 100$2 Switch from "#" to "" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:07:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:07:11 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #9 from Jonathan Druart --- Created attachment 116170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116170&action=edit Bug 27569: Fix ODS export - take empty string into account If a cell contains an empty string it was not taken into account. Test plan: Same as CSV but with ODS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:07:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:07:22 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:14:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:14:18 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #27 from Jonathan Druart --- Please add release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:22:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:22:41 +0000 Subject: [Koha-bugs] [Bug 27554] Clarify and add tests for Koha::Patrons->update_category_to child to adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116097|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 116171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116171&action=edit Bug 27554: Clarify and add tests for update_category_to This patch adds a comment to the existing tests, clarifying what they test, and verifying the expected patron is affected. The original test should be broken by 26307 when the behvaiour is prevented I additionally add a test for 'too old' To test: 1 - Apply patch 2 - Prove tests, they should pass 3 - Verify the comments make sense Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer JD amended patch: behvaiour ==> behaviour and add more info to the commit title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:23:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:23:23 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Marking an item as a return release notes| |claim checks the system | |preference | |MarkLostItemsAsReturned to | |see if the claim should be | |removed from the patron | |record. However, the option | |for "when marking an item | |as a return claim" was | |never added to the system | |preference, so there was no | |way to remove a checkout | |from the patron record when | |marking the checkout as a | |return claim. This patch | |set adds that missing | |option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:41:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:41:10 +0000 Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #17 from Barbara Johnson --- I agree with Fridolin. My hope was that the version would display more prominently without having to click on 'About Koha' or 'More.' I attached a screenshot that shows the version in the lower right hand corner of the main/hone page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:42:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:42:37 +0000 Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #18 from Barbara Johnson --- Created attachment 116172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116172&action=edit Display version in lower right corner of home page in staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:46:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:46:46 +0000 Subject: [Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #26 from Jonathan Druart --- (In reply to Katrin Fischer from comment #19) > Created attachment 116109 [details] [review] > Bug 27330: Use Basic auth in tests > > This patch puts the tests in line with the current codebase. Can we fix all the other tests as well please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:47:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:47:02 +0000 Subject: [Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 --- Comment #27 from Jonathan Druart --- (On its own bug report of course) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:50:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:50:54 +0000 Subject: [Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 --- Comment #28 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #26) > (In reply to Katrin Fischer from comment #19) > > Created attachment 116109 [details] [review] [review] > > Bug 27330: Use Basic auth in tests > > > > This patch puts the tests in line with the current codebase. > > Can we fix all the other tests as well please? I think it is only: - acquisitions_vendors.t - patrons_accounts.t - patrons_password.t - stockrotationstage.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:56:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:56:34 +0000 Subject: [Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 --- Comment #29 from Jonathan Druart --- + unless ($item) { + return $c->render( + status => 404, + openapi => { error => "item_id not found." } + ); + } [...] + elsif ($biblio_id) { + $biblio = Koha::Biblios->find($biblio_id); + } + else { + return $c->render( + status => 400, + openapi => { error => "At least one of biblio_id, item_id should be given" } + ); Is that correct? (404 vs 400) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 16:57:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 15:57:30 +0000 Subject: [Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 --- Comment #30 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #28) > (In reply to Jonathan Druart from comment #26) > > (In reply to Katrin Fischer from comment #19) > > > Created attachment 116109 [details] [review] [review] [review] > > > Bug 27330: Use Basic auth in tests > > > > > > This patch puts the tests in line with the current codebase. > > > > Can we fix all the other tests as well please? > > I think it is only: > > - acquisitions_vendors.t > - patrons_accounts.t > - patrons_password.t > - stockrotationstage.t "only", so you prefer to fix them here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:13:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:13:10 +0000 Subject: [Koha-bugs] [Bug 27430] Use minimum length for patron category on password hint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart --- In my understanding we never see
Minimum password length: [% patron.category.effective_min_password_length | html %]
as it's replaced by the JS code. Shouldn't we remove it then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:14:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:14:33 +0000 Subject: [Koha-bugs] [Bug 27430] Use minimum length for patron category on password hint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #19 from Jonathan Druart --- 1573 [% IF categorycode %] 1574 update_category_code( "[% categorycode | html %]" ); 1575 [% ELSE %] 1576 if ( $("#categorycode_entry").length > 0 ){ 1577 var category_code = $("#categorycode_entry").find("option:selected").val(); 1578 update_category_code( category_code ); 1579 } 1580 [% END %] update_category_code COULD not be called on document.ready. But I am not sure we display the form without the category dropdown list. I will push as it, don't want to mess with this form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:17:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:17:55 +0000 Subject: [Koha-bugs] [Bug 27538] Cells in the bottom filtering row of the "Holds to pull" table shifted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23485 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Caused by: commit fe84c3acba33af7a2fb27643f6b5f9129c329b36 Bug 23485: Show barcode in holds to pull Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485 [Bug 23485] Holds to pull (pendingreserves.pl) should list barcodes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:17:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:17:55 +0000 Subject: [Koha-bugs] [Bug 23485] Holds to pull (pendingreserves.pl) should list barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27538 [Bug 27538] Cells in the bottom filtering row of the "Holds to pull" table shifted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:25:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:25:14 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #28 from Jonathan Druart --- Created attachment 116173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116173&action=edit Bug 25552: Simplify tests using build_sample_item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:12 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:15 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #23 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:17 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:19 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #29 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:21 +0000 Subject: [Koha-bugs] [Bug 26298] If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:24 +0000 Subject: [Koha-bugs] [Bug 26298] If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:26 +0000 Subject: [Koha-bugs] [Bug 26578] OverDrive results can return false positives when searches contain CCL syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:28 +0000 Subject: [Koha-bugs] [Bug 26578] OverDrive results can return false positives when searches contain CCL syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26578 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:30 +0000 Subject: [Koha-bugs] [Bug 27204] SIP patron information request with fee line items returns incorrect data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:32 +0000 Subject: [Koha-bugs] [Bug 27204] SIP patron information request with fee line items returns incorrect data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27204 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:34 +0000 Subject: [Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:36 +0000 Subject: [Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:39 +0000 Subject: [Koha-bugs] [Bug 27321] Make excluded database columns in system preferences more clearly disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:41 +0000 Subject: [Koha-bugs] [Bug 27321] Make excluded database columns in system preferences more clearly disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:43 +0000 Subject: [Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:44 +0000 Subject: [Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 --- Comment #31 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:47 +0000 Subject: [Koha-bugs] [Bug 27430] Use minimum length for patron category on password hint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:49 +0000 Subject: [Koha-bugs] [Bug 27430] Use minimum length for patron category on password hint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27430 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:51 +0000 Subject: [Koha-bugs] [Bug 27450] Making password required for patron registration breaks patron modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:53 +0000 Subject: [Koha-bugs] [Bug 27450] Making password required for patron registration breaks patron modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27450 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:55 +0000 Subject: [Koha-bugs] [Bug 27530] Sample patron data should be updated and/or use relative dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:57 +0000 Subject: [Koha-bugs] [Bug 27530] Sample patron data should be updated and/or use relative dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27530 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:26:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:26:59 +0000 Subject: [Koha-bugs] [Bug 27538] Cells in the bottom filtering row of the "Holds to pull" table shifted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:01 +0000 Subject: [Koha-bugs] [Bug 27538] Cells in the bottom filtering row of the "Holds to pull" table shifted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27538 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:03 +0000 Subject: [Koha-bugs] [Bug 27548] Warnings "use of uninitialized value" on branchoverdues.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:06 +0000 Subject: [Koha-bugs] [Bug 27548] Warnings "use of uninitialized value" on branchoverdues.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27548 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:13 +0000 Subject: [Koha-bugs] [Bug 27549] Warning "use of uninitialized value" on renew.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:15 +0000 Subject: [Koha-bugs] [Bug 27549] Warning "use of uninitialized value" on renew.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27549 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:17 +0000 Subject: [Koha-bugs] [Bug 27554] Clarify and add tests for Koha::Patrons->update_category_to child to adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:19 +0000 Subject: [Koha-bugs] [Bug 27554] Clarify and add tests for Koha::Patrons->update_category_to child to adult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27554 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:21 +0000 Subject: [Koha-bugs] [Bug 27561] Remove type attribute from script tags: Various templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:23 +0000 Subject: [Koha-bugs] [Bug 27561] Remove type attribute from script tags: Various templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27561 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:24 +0000 Subject: [Koha-bugs] [Bug 27571] "Add to lists" on MARC and ISBD view of OPAC detail page doesn't open in new window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27571 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:26 +0000 Subject: [Koha-bugs] [Bug 27571] "Add to lists" on MARC and ISBD view of OPAC detail page doesn't open in new window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27571 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:28 +0000 Subject: [Koha-bugs] [Bug 27576] Don't show import records table when cleaning a batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27576 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:30 +0000 Subject: [Koha-bugs] [Bug 27576] Don't show import records table when cleaning a batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27576 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:32 +0000 Subject: [Koha-bugs] [Bug 27580] NULL values not correctly handled in Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:27:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:27:34 +0000 Subject: [Koha-bugs] [Bug 27580] NULL values not correctly handled in Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27580 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:29:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:29:02 +0000 Subject: [Koha-bugs] [Bug 27463] OAI-PMH date handling in ListBase.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27463 --- Comment #7 from Rudolf Byker --- > Haha, thanks. So, is there really an issue that I'm failing to see here? Indeed. I re-read my original post, and can't find a way to say it any clearer than I did. Please also read the linked IRC chat. :)(In reply to Ere Maijala from comment #6) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:33:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:33:52 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #10 from Katrin Fischer --- Hi Jonathan, can you add which LibreOffice version you have used for testing? I have tested a bit and the issue seems to be that we used to export "empty cell" with # in it, but we don't seem to do that with the authorised_value and see_also columns consistently anymore? When I add back the #, the file loads appears to be loading ok. I think making it work with empty cells would be better, but it could it have been a change in our export format causing this? I tested with an .ods file with Excel 2016 or LibreOffice 6.2.5.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:44:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:44:17 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116145|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 116174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116174&action=edit Bug 26274: Add cashups api routes This patch creates a Koha::Cash::Register::Cashup(s) class pair which subclass Koha::Cash::Register::Action(s) and moves the cashup specific code into these new classes to improve code separation. We then introduce API routes based on these classes to allow fetching a list of cashups associated to a cash register and a full cashup with emeddable summary for individual cashups. Test plan 1/ Run the updated unit tests. t/db_dependent/Koha/Cash/Register/Action.t t/db_dependent/Koha/Cash/Register/Cashup.t 2/ Run the incuded api tests. t/db_dependent/api/v1/cashups.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:44:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:44:21 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116146|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 116175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116175&action=edit Bug 26274: Update register.tt to use the API This patch updates the existing register details page to utilise the new api routes to gather the summary details on demand. Test plan 1/ Enable cash registers 2/ Add some transactions 3/ Perform a cashup 4/ Click 'Summary' next to the last cashup date 5/ Note the modal appears as it did prior to the patch being applied. 6/ Check the print option still works 7/ Signoff Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:44:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:44:51 +0000 Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #4 from Martin Renvoize --- Created attachment 116176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116176&action=edit Bug 26273: Add historic cashups table to register page This patch adds a historic cashups table to the bottom of the register transaction details page. It will only display if one or more cashups have taken place and contains links to allow display of the summary detail modal for each cashup. Test plan 1/ Enable UseCashRegisters 2/ Undertake a few transactions and cashups 3/ View the 'Register details' page 4/ Note the appearance of a 'Cashup history' section at the bottom of the page 5/ Note that 'Summary' button displays the relevant modal 6/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:47:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:47:18 +0000 Subject: [Koha-bugs] [Bug 26272] Allow cashup summaries to be displayed from the library summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116147|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 116177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116177&action=edit Bug 26272: Add ajax driven cashup modal to library page This patch adds an ajax driven cashup summary modal to the library registers summary page. Test plan 1/ Enable UseCashRegisters in the system preferences 2/ Add at least one cash register to your library 3/ Make some payments of various types (Cash, Card) against the cash register 4/ View the register transactions details page 5/ Make a refund against a payment 6/ Cashup 7/ View the cashup summary by clicking on the 'Summary' link on the register page. 8/ Navigate to the 'libraries' summary page 9/ View the cashup summary by clicking on the 'Summary' link in the registers table. 10/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:47:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:47:36 +0000 Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:48:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:48:39 +0000 Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #5 from Martin Renvoize --- I'm looking for feedback on this one now.. I'm not entirely sure about the placement of the index.. whether the register details page is the right place or whether this warrants a page of it's own (but then.. where should it be linked from and what should it be called?) The attached patch is a proof of concept for how we may achieve it however :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 17:54:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 16:54:55 +0000 Subject: [Koha-bugs] [Bug 26957] Find duplicate removes operators from the middle of search terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26957 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:36:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 17:36:02 +0000 Subject: [Koha-bugs] [Bug 27307] "Keyword as phrase" option in search dropdown doesn't work with Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27307 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:39:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 17:39:39 +0000 Subject: [Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.02,20.05.09 |21.05.00,20.11.02,20.05.09, released in| |19.11.15 --- Comment #11 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:41:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 17:41:13 +0000 Subject: [Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 --- Comment #18 from David Nind --- > Oops, seems I missed writing the actual test name in that second point.. > however you will have inadvertently run it by running t/ > > I've fixed the commit message to include it now :) Thanks Martin! Just to confirm that the tests for t/db_dependent/api/v1/cashups.t pass. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 18:44:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 17:44:18 +0000 Subject: [Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.02,20.05.08 |21.05.00,20.11.02,20.05.08, released in| |19.11.15 --- Comment #14 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 19:04:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 18:04:09 +0000 Subject: [Koha-bugs] [Bug 27585] New: Adding multiple items doesn't update total cost Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27585 Bug ID: 27585 Summary: Adding multiple items doesn't update total cost Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org I noticed that when adding multiple items to an order (using the 'Add multiple items' button), the total cost (budgeted cost*quantity) is not updated. 1) In Acquisitions, search for a vendor 2) Click 'New basket' 3) Give a name to the basket 4) Make sure 'Create items when' is set to 'placing an order' 5) Click 'Save' 6) Click 'Add to basket' to add an order to the basket (I use from existing record) 7) Click 'Add item' at the end of the item form <-- Notice the quantity is now 1 8) Enter a vendor price, e.g. 12.95 <-- Notice the total (budgeted cost*quantity) is now 12.95 9) Click 'Add item' at the end of the item form again <-- Notice the quantity is now 2 and the total is now 25.90 10) Click 'Add multiple items' at the end of the item form 11) Enter a quantity, e.g. 8, and click 'Add' <-- Notice the quantity is now 10 BUT the total stayed at 25.90 The total should be updated to 129.50. When saving the order, the total cost is correct. So it's really just a display problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 19:05:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 18:05:23 +0000 Subject: [Koha-bugs] [Bug 27585] Adding multiple items doesn't update total cost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27585 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 116178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116178&action=edit Screenshot of order details This is a screenshot showing my order details, the quantity is 10, but the total cost is 25.90 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 19:14:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 18:14:40 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #22 from Victor Grousset/tuxayo --- Thanks Nick :D Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 19:14:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 18:14:48 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.01,20.05.08 |21.05.00,20.11.01,20.05.08, released in| |19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 19:15:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 18:15:09 +0000 Subject: [Koha-bugs] [Bug 27586] New: Import patrons script has a confirm switch that doesn't nothing! Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27586 Bug ID: 27586 Summary: Import patrons script has a confirm switch that doesn't nothing! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If the script misc/import_patrons.pl is run without "--confirm" it reports that is "running in dry-run mode" but it is not! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 19:25:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 18:25:16 +0000 Subject: [Koha-bugs] [Bug 26713] Add pagination to bottom of saved SQL reports table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26713 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net Version(s)|21.05.00,20.11.02,20.05.09 |21.05.00,20.11.02,20.05.09, released in| |19.11.15 --- Comment #8 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 19:25:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 18:25:59 +0000 Subject: [Koha-bugs] [Bug 27586] Import patrons script has a confirm switch that doesn't nothing! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27586 --- Comment #1 from Kyle M Hall --- Created attachment 116179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116179&action=edit Bug 27586: Import patrons script has a confirm switch that doesn't nothing! If the script misc/import_patrons.pl is run without "--confirm" it reports that it is "running in dry-run mode" but it is not! Test Plan: 1) Import a CSV of patrons using import_patrons.pm *without* the --confirm parameter 2) Note that it does actually import the patrons 3) Apply this patch 4) Note that this time the patrons are not actually imported 5) Import again with --confirm 6) Note that the patrons were actually imported this time! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:48:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 19:48:03 +0000 Subject: [Koha-bugs] [Bug 27306] Add subtitle to return claims table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27306 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:48:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 19:48:06 +0000 Subject: [Koha-bugs] [Bug 27587] New: Use Basic auth on API tests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27587 Bug ID: 27587 Summary: Use Basic auth on API tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com Even if it is correct to use either authentication method, we are trying to clean our tests so consistency is key for users using existing tests as examples for the new ones they want/need to introduce. There are specific tests for the cookie (and OAuth2) authentication, so we can use the built-in Basic authentication mechanism from Test::Mojo and have simpler tests written. This bug should include patches to fix existing tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:48:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 19:48:26 +0000 Subject: [Koha-bugs] [Bug 27587] Use Basic auth on API tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27587 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27330 Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:48:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 19:48:26 +0000 Subject: [Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27587 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:50:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 19:50:44 +0000 Subject: [Koha-bugs] [Bug 27297] When itemtype is marked as required in OpacSuggestion MandatoryFields the field is not required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 20:52:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 19:52:23 +0000 Subject: [Koha-bugs] [Bug 27588] New: Hadeh pak Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27588 Bug ID: 27588 Summary: Hadeh pak Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: rahaxor666 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 116180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116180&action=edit Halah Erere -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:01:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:01:34 +0000 Subject: [Koha-bugs] [Bug 27588] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27588 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Hadeh pak |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:04:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:04:07 +0000 Subject: [Koha-bugs] [Bug 18416] Audio alerts: Add a hint that the upload file tool can be used for adding custom sound files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18416 --- Comment #6 from Owen Leonard --- Is it possible to access an uploaded file via a URL? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:16:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:16:36 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #68 from Andrew Fuerste-Henry --- I'm getting test failures when trying to apply this to 20.05. Please address for backport. Here's what I see: $ prove t/db_dependent/ILSDI_Services.t t/db_dependent/ILSDI_Services.t .. 1/10 Use of bare << to mean <<"" is deprecated at t/db_dependent/ILSDI_Services.t line 452. Use of bare << to mean <<"" is deprecated at t/db_dependent/ILSDI_Services.t line 452. Bareword found where operator expected at t/db_dependent/ILSDI_Services.t line 466, near "HEAD is" (Might be a runaway multi-line << string starting on line 459) (Do you need to predeclare HEAD?) Global symbol "$module" requires explicit package name (did you forget to declare "my $module"?) at t/db_dependent/ILSDI_Services.t line 454. Global symbol "$module" requires explicit package name (did you forget to declare "my $module"?) at t/db_dependent/ILSDI_Services.t line 455. Global symbol "$issue" requires explicit package name (did you forget to declare "my $issue"?) at t/db_dependent/ILSDI_Services.t line 456. Global symbol "$origin_branch" requires explicit package name (did you forget to declare "my $origin_branch"?) at t/db_dependent/ILSDI_Services.t line 463. syntax error at t/db_dependent/ILSDI_Services.t line 466, near "HEAD is" syntax error at t/db_dependent/ILSDI_Services.t line 466, near ""Patron has issued same book" )" Global symbol "$reply" requires explicit package name (did you forget to declare "my $reply"?) at t/db_dependent/ILSDI_Services.t line 467. Global symbol "$biblio_with_no_item" requires explicit package name (did you forget to declare "my $biblio_with_no_item"?) at t/db_dependent/ILSDI_Services.t line 490. Global symbol "$query" requires explicit package name (did you forget to declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 495. Global symbol "$query" requires explicit package name (did you forget to declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 496. Global symbol "$query" requires explicit package name (did you forget to declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 497. Global symbol "$biblio_with_no_item" requires explicit package name (did you forget to declare "my $biblio_with_no_item"?) at t/db_dependent/ILSDI_Services.t line 497. Global symbol "$query" requires explicit package name (did you forget to declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 498. Global symbol "$reply" requires explicit package name (did you forget to declare "my $reply"?) at t/db_dependent/ILSDI_Services.t line 500. Global symbol "$query" requires explicit package name (did you forget to declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 500. Global symbol "$reply" requires explicit package name (did you forget to declare "my $reply"?) at t/db_dependent/ILSDI_Services.t line 501. syntax error at t/db_dependent/ILSDI_Services.t line 503, near ">>" t/db_dependent/ILSDI_Services.t has too many errors. # Looks like your test exited with 255 just after 1. t/db_dependent/ILSDI_Services.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 9/10 subtests Test Summary Report ------------------- t/db_dependent/ILSDI_Services.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 10 tests but ran 1. Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.67 cusr 0.14 csys = 0.84 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:18:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:18:55 +0000 Subject: [Koha-bugs] [Bug 27264] Reword sentence of OPACHoldsHistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27264 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20936 CC| |andrew at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds history for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:18:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:18:55 +0000 Subject: [Koha-bugs] [Bug 20936] Holds history for patrons in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27264 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27264 [Bug 27264] Reword sentence of OPACHoldsHistory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:19:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:19:14 +0000 Subject: [Koha-bugs] [Bug 27264] Reword sentence of OPACHoldsHistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27264 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #6 from Andrew Fuerste-Henry --- Missing dependency, not backported to 20.50 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:19:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:19:56 +0000 Subject: [Koha-bugs] [Bug 26991] Add action logs to search engine administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26991 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry --- Enhancement, not backported to 20.05. Please ask if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:22:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:22:57 +0000 Subject: [Koha-bugs] [Bug 27416] String 'Modify tag' in breadcrumb is untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27416 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:25:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:25:41 +0000 Subject: [Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #15 from Andrew Fuerste-Henry --- Enhancement, not backporting to 20.05. Please ask if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:35:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:35:43 +0000 Subject: [Koha-bugs] [Bug 24372] Elasticsearch - cannot search for titles containing a colon next to a search term using the colon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24372 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:36:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:36:29 +0000 Subject: [Koha-bugs] [Bug 27589] New: Error when specifying CR field in SIP Config Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Bug ID: 27589 Summary: Error when specifying CR field in SIP Config Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 21979 added the ability to define a custom CR field in SIP responses - the code in handle_checkin uses: $item->{$CR} but in handle_item_information: $item->$CR To recreate: 1 - set cr_item_field to 'itype' In SIP Config 2 - Attempt item_information request 3 - it Fails! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:36:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:36:56 +0000 Subject: [Koha-bugs] [Bug 27589] Error when specifying CR field in SIP Config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979 [Bug 21979] Add option to SIP2 config to send arbitrary item field in CR instead of collection code -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:36:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:36:56 +0000 Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary item field in CR instead of collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 [Bug 27589] Error when specifying CR field in SIP Config -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:37:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:37:58 +0000 Subject: [Koha-bugs] [Bug 24372] Elasticsearch - cannot search for titles containing a colon next to a search term using the colon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24372 Margaret Hade changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:42:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:42:56 +0000 Subject: [Koha-bugs] [Bug 27192] Set focus for cursor to item type input box when creating new item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | CC| |andrew at bywatersolutions.com --- Comment #12 from Andrew Fuerste-Henry --- Following Frido, backporting to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:55:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:55:22 +0000 Subject: [Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Andrew Fuerste-Henry --- Backporting standalone script to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:56:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:56:03 +0000 Subject: [Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 21:56:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 20:56:07 +0000 Subject: [Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105003|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia --- Created attachment 116181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116181&action=edit Bug 23295: Automatically restrict (debar) patrons when email/sms notices fail When the 'RestrictPatronsWithFailedNotices' syspref is enabled then patrons with email and sms notices which failed sending (have a message_queue.status field of 'failed') have a restriction (debarment) applied to them. Test plan: 1. In the Koha staff client > Tools > Overdue notice/status triggers and create the 'First' rule for all patron categories as: Delay: 1 Letter: Overdue Notice SMS: ticked Ensure you have an SMS notice for the ODUE letter. 2. In the system preferences make sure you enter dummy data into the SMSSendUsername, SMSSendPassword and EmailSMSSendDriverFromAddress sysprefs 2. Find two non-debarred patrons and make sure they have invalid SMS numbers set. The SMS numbers must be INCORRECT, for example "123" as an SMS number. Leaving this field empty will result in the message_transport_type defaulting to 'print' instead of 'sms'. 3. Check one item out to each patron in step 2 4. Jump into the database and run the query: UPDATE issues SET date_due=<2 days before current date> WHERE borrowernumber=; UPDATE issues SET date_due=<2 days before current date> WHERE borrowernumber=; 5. Go to misc/cronjobs directory and enter the Koha shell: sudo koha-shell 6. Run: ./overdue_notices.pl 7. Exit the shell and jump back into the database and run the query: SELECT message_transport_type, status FROM message_queue WHERE borrowernumber= OR borrowernumber=; 8. Confirm both new notice records have the message_transport_type is 'sms' and the status of 'pending' 9. Exit the database and re-enter the Koha shell and run the command: ./process_message_queue.pl 10. Jump back into the database re-run the query from step 7 and confirm the status is 'failed' for both 11. Also run the query: SELECT * FROM borrower_debarments WHERE borrowernumber= OR borrowernumber=; Notice there is no added debarment to these two patrons 12. Apply patch, restart memcached and plack. In the installer/data/mysql directory enter the Koha shell and run the command: ./update_database.pl 13. In the Administration > Global System Preferences interface of the staff client notice there is a new system (set to "Don't" by default) named 'RestrictPatronsWithFailedNotices'. Enable it (i.e. select 'Do') 14. Create a new file in the /etc/cron.daily directory named koha-custom and add the following line to it: koha-foreach --chdir --enabled /usr/share/koha/bin/cronjobs/restrict_patrons_with_failed_notices.pl 15. In the misc/cronjobs directory enter the Koha shell and run the command: ./restrict_patrons_with_failed_notices.pl 16. The script should output text saying: There are borrowers with failed SMS or email notices However because you haven't given the script the argument -c it won't apply debarments (restrictions) to any of the patrons with the failed SMS or email notices. 16. Query the borrower_debarments table: SELECT * FROM borrower_debarments WHERE borrowernumber= OR borrowernumber=; Notice they still have no restriction 17. Now in the Koha shell run the command: ./restrict_patrons_with_failed_notices.pl -c 18. Notice the script outputs the text: There are borrowers with failed SMS or email notices Applying restriction to patron : ; 19. Repeat step 16 and notice both patrons now have 1 restriction each with the borrower_debarments.type=SUSPENSION and comment=SMSnumber invalid and expiration=NULL 20. Query the borrowers table: SELECT debarred, debarredcomment FROM borrowers WHERE borrowernumber= OR borrowernumber=; 21. Notice the values are: debarred= 9999-12-31 debarredcomment= SMS number invalid 22. Repeat step 17 and notice the script outputs: There are borrowers with failed SMS or email notices Patron : is currently restricted due to having an invalid SMS number. No new restriction applied" 23. Repeat step 16 and notice no new debarment has been added to those borrowers as they have already been restricted from having a failed SMS notice. 24. In the Koha home directory run the command: prove t/db_dependent/Koha/Notices.t This unit test contains the tests for the new subroutines added to Koha/Notice/Message.pm which are restrict_patron_when_notice_fails() and get_failed_notices() 25. All tests should pass 26. Sign off Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 22:14:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 21:14:12 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 22:15:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 21:15:09 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|21.05.00,20.11.02,20.05.09 |21.05.00,20.11.02,20.05.09, released in| |19.11.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #65 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 in the interest of correcting bug 15448 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 22:51:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 21:51:57 +0000 Subject: [Koha-bugs] [Bug 27563] Remove check-url.pl in favor of check-url-quick.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 22:53:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 21:53:03 +0000 Subject: [Koha-bugs] [Bug 25808] Renewal via the SIP 'checkout' message gives incorrect message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | --- Comment #15 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 22:58:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 21:58:47 +0000 Subject: [Koha-bugs] [Bug 27011] Warnings in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 23:35:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 22:35:57 +0000 Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #19 from David Cook --- (In reply to Barbara Johnson from comment #17) > I agree with Fridolin. My hope was that the version would display more > prominently without having to click on 'About Koha' or 'More.' I attached a > screenshot that shows the version in the lower right hand corner of the > main/hone page. I like the sound of this too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 23:42:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 22:42:12 +0000 Subject: [Koha-bugs] [Bug 25078] Gracefully stop updatedatabase/installer when a database change cannot be applied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 23:42:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 22:42:23 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.02,20.05.09 |21.05.00,20.11.02,20.05.09, released in| |19.11.15 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net --- Comment #24 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 23:48:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 22:48:53 +0000 Subject: [Koha-bugs] [Bug 27563] Remove check-url.pl in favor of check-url-quick.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27563 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 23:48:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 22:48:56 +0000 Subject: [Koha-bugs] [Bug 27563] Remove check-url.pl in favor of check-url-quick.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27563 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115910|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 116182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116182&action=edit Bug 27563: Remove check-url.pl in favor of check-url-quick.pl To test: 1 - verify the script is gone 2 - verify check-url-quick.pl works Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 23:55:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 22:55:23 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 --- Comment #25 from David Cook --- You know... in hindsight... this might not be a good one to backport. If we push out this change and people install it via a package upgrade without paying attention, their Zebra search is going to break until they do a full Zebra re-index. That could make for a lot of very unhappy confused people. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 1 23:56:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 22:56:07 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 --- Comment #26 from David Cook --- The Zebrasrv will also need a restart. I'm not sure if we actually do that when upgrading Koha... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 00:14:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 23:14:48 +0000 Subject: [Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.02,20.05.09 |21.05.00,20.11.02,20.05.09, released in| |19.11.15 --- Comment #49 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 00:19:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 23:19:21 +0000 Subject: [Koha-bugs] [Bug 17429] Document the --plack option for koha-list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17429 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.02,20.05.09 |21.05.00,20.11.02,20.05.09, released in| |19.11.15 --- Comment #9 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 00:41:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 23:41:12 +0000 Subject: [Koha-bugs] [Bug 27416] String 'Modify tag' in breadcrumb is untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27416 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #7 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 00:45:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Feb 2021 23:45:19 +0000 Subject: [Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 --- Comment #17 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 02:04:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 01:04:18 +0000 Subject: [Koha-bugs] [Bug 27192] Set focus for cursor to item type input box when creating new item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #13 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 02:20:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 01:20:38 +0000 Subject: [Koha-bugs] [Bug 25808] Renewal via the SIP 'checkout' message gives incorrect message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #16 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x), tests don't pass. If needed for 19.11, please send a patch. Note that it's not a major bug so it's not a big deal if it's not backported. Just tried to backport since I already knew the test plan. t/db_dependent/SIP/ILS.t .. 2/11 # Failed test 'We get a success message when issue is renewed' # at t/db_dependent/SIP/ILS.t line 170. # got: 'Issue failed : NO_MORE_RENEWALS' # expected: 'Item already checked out to you: renewing item.' # Failed test 'Renewals has been reduced' # at t/db_dependent/SIP/ILS.t line 173. # got: '0' # expected: '1' # Looks like you failed 2 tests of 4. t/db_dependent/SIP/ILS.t .. 11/11 # Failed test 'checkout' # at t/db_dependent/SIP/ILS.t line 174. # Looks like you failed 1 test of 11. For the first failure, it seems the messages where simpler (NO_MORE_RENEWALS) in 19.11 which can be fixed in the test, however this is not the same semantic between the actual and expected message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 02:35:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 01:35:09 +0000 Subject: [Koha-bugs] [Bug 27011] Warnings in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net Version(s)|21.05.00,20.11.03,20.05.09 |21.05.00,20.11.03,20.05.09, released in| |19.11.15 --- Comment #14 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 06:09:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 05:09:32 +0000 Subject: [Koha-bugs] [Bug 27590] New: Self-created MARC-Framework deletes content containing german special characters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27590 Bug ID: 27590 Summary: Self-created MARC-Framework deletes content containing german special characters Change sponsored?: --- Product: Koha Version: 20.11 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: braun.kamilla at web.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 116183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116183&action=edit Self-created MARC-framework For the purpose of fast manual cataloging, I created a small MARC-framework, containing only a few important fields. (see attachment) Using this framework for cataloging (creating new records) all content containing german special characters (i.e. äöüÄÖÜß) will be deleted or somehow changed. If the same record is beeing imported via the Z39.50-interface, the german special characters are accepted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 06:09:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 05:09:54 +0000 Subject: [Koha-bugs] [Bug 27590] Self-created MARC-Framework deletes content containing german special characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27590 braun.kamilla at web.de changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 08:38:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 07:38:13 +0000 Subject: [Koha-bugs] [Bug 27590] Self-created MARC-Framework deletes content containing german special characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27590 --- Comment #1 from Katrin Fischer --- Usually this is a configuration issue. The LDR contains a position declaring the encoding of the record. If that is missing, things will go terribly wrong, like you describe. It's LDR Pos. 9 - it needs to be set to a. https://www.loc.gov/marc/bibliographic/bdleader.html Maybe the default value in the framework doesn't work quite right. Please note: Fields that are deleted from the framework will be lost in records imported from external sources once they are saved for the first time. Koha will delete all fields/subfields not declared in the framework. For this reason it can make sense to only hide, not remove, the fields unneded. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 08:41:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 07:41:47 +0000 Subject: [Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 --- Comment #1 from Ere Maijala --- Created attachment 116184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116184&action=edit Bug 27584: Refactor OAI-PMH paging to improve performance Uses next biblionumber instead of large offset in the queries. Test plan: 1. Without the patch, try harvesting a Koha database with `include_items: 1` in the OAI-PMH configuration file pointed to by preference OAI-PMH:ConfFile and take note of performance. For useful metrics the database must be large enough to not fit in InnoDB buffers or OS file cache. 2. Apply the patch. 3. Run tests: prove -v t/db_dependent/OAI 4. Try again the harvesting from step 1 and compare performance with step 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 08:49:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 07:49:20 +0000 Subject: [Koha-bugs] [Bug 27463] OAI-PMH date handling in ListBase.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27463 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | --- Comment #8 from Ere Maijala --- (In reply to Rudolf Byker from comment #7) > Indeed. I re-read my original post, and can't find a way to say it any > clearer than I did. Please also read the linked IRC chat. :)(In reply to Ere > Maijala from comment #6) Oh, there's a bug indeed. Sorry, not sure how I missed it then and now. It all works fine when you have `include_items: 1` in the conf file specified by preference OAI-PMH:ConfFile, but the item timestamps should be ignored when that's not the case. I'll post a patch. The thing with joins is that they are indeed quite terrible. If you only consider a range of one day, it all looks ok, but the way OAI-PMH harvesting usually works is that the initial harvest is done without date limits to get all the records, and then incremental harvesting is done with just a 'from' date (since the beginning of the previous harvesting). That means the date limits may include millions of records, and joins on such large sets are better avoided. I'll contact you off-bug for further discussion on the topic. You can check the history for these files to see how things have evolved in an attempt to improve functionality and performance. Also, I've just posted bug 27584 with a further refinement trying to address performance issues when there are millions of biblios. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:02:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:02:25 +0000 Subject: [Koha-bugs] [Bug 23830] Koha::AuthorisedValues should use Koha::Objects::Limit::Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115989|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 116185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116185&action=edit Bug 23830: Make Koha::AuthorisedValues use Koha::Objects::Limit::Library This patch makes Koha::AuthorisedValues inherit the 'search_with_library_limits' method from Koha::Objects::Limit::Library. This was left out of the original implementation and this patch makes this library have a similar implementation to that of Koha::ItemTypes, etc. To test: 1. Run: $ kshell k$ prove t/db_dependent/AuthorisedValues.t => SUCCESS: Tests pass! 2. Apply this patch 3. Notice Koha::AuthorisedValues now inherits this new library 4. Notice the overloaded ->search method is removed 5. Repeat (1) => SUCCESS: The behavior of the newly used method on the tests is the same as before. We only changed the method name and how we pass the library_id. 6. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:02:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:02:29 +0000 Subject: [Koha-bugs] [Bug 23830] Koha::AuthorisedValues should use Koha::Objects::Limit::Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115990|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 116186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116186&action=edit Bug 23830: Adapt callers This patch is the result of making the same changes we did on the t/db_dependent/AuthorisedValues.t file (replacing the calls to Koha::AuthorisedValues->search with the tricky branchcode param, and call ->search_with_library_limits, with the library_id as a third parameter. What I did was: $ git grep 'Koha::AuthorisedValues\->search' and then revisited each of the grep results to check if they added the 'branchcode' parameter to the filters. This patch changes the calls to ->search, for ->search_with_library_limits in all the places that require it in the current codebase [1]. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Charges/Sales.t \ t/db_dependent/Ill* 3. Verify the batchmod.pl script is working and filtering the authorised values keeps working [1] Some places like the Koha/Template/Plugin/AuthorisedValues.pm plugin don't seem to be tested, at first glance. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:03:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:03:33 +0000 Subject: [Koha-bugs] [Bug 23830] Koha::AuthorisedValues should use Koha::Objects::Limit::Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- Oooh, thanks for this Tomas.. I had entirely forgotten I'd reported this one! Code is trivial and good, all cases seem covered.. test suit passes, QA script passes (well, except for a false positive on POD removal). I think we can safely go for a straight to PQA on this one.! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:03:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:03:38 +0000 Subject: [Koha-bugs] [Bug 23830] Koha::AuthorisedValues should use Koha::Objects::Limit::Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23830 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:54:24 +0000 Subject: [Koha-bugs] [Bug 16820] Add possibility to edit fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #11 from Martin Renvoize --- With the introduction of a discounts process in accounts with bug 24081 I think this is resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:54:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:54:25 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Bug 14825 depends on bug 16820, which changed state. Bug 16820 Summary: Add possibility to edit fines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:54:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:54:33 +0000 Subject: [Koha-bugs] [Bug 16820] Add possibility to edit fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |DUPLICATE --- Comment #12 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 24081 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:54:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:54:33 +0000 Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca --- Comment #27 from Martin Renvoize --- *** Bug 16820 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:55:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:55:33 +0000 Subject: [Koha-bugs] [Bug 26542] Apply Discount button appears when it can't be used. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26542 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks| |14825 Depends on| |24081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:55:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:55:33 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26542 [Bug 26542] Apply Discount button appears when it can't be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:55:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:55:33 +0000 Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26542 [Bug 26542] Apply Discount button appears when it can't be used. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:58:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:58:38 +0000 Subject: [Koha-bugs] [Bug 26541] Apply discount button misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks| |24821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821 [Bug 24821] Add percentage handling to discount process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:58:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:58:38 +0000 Subject: [Koha-bugs] [Bug 24821] Add percentage handling to discount process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26541 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 [Bug 26541] Apply discount button misleading -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:59:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:59:12 +0000 Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24821 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821 [Bug 24821] Add percentage handling to discount process -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 09:59:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 08:59:12 +0000 Subject: [Koha-bugs] [Bug 24821] Add percentage handling to discount process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24081 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:05:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:05:09 +0000 Subject: [Koha-bugs] [Bug 26540] Server error when aattempting to issue cash credit with UseCashRegisters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Issue Credit with Cash |Server error when |Registers |aattempting to issue cash | |credit with | |UseCashRegisters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:06:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:06:25 +0000 Subject: [Koha-bugs] [Bug 27573] Use of NOW() in SQL should be avoided In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27573 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Martin Renvoize --- In conversation with Jonathan I discovered we actually set the timezone on the database connection handle.. so this isn't the problem I suspected it was. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:14:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:14:02 +0000 Subject: [Koha-bugs] [Bug 24792] Cash register 'cashup' functionality should be available without 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24792 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 24492 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:14:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:14:02 +0000 Subject: [Koha-bugs] [Bug 24492] Add a 'library cashup' workflow to the point of sale system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492 --- Comment #14 from Martin Renvoize --- *** Bug 24792 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:14:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:14:36 +0000 Subject: [Koha-bugs] [Bug 24792] Cash register 'cashup' functionality should be available without 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24792 --- Comment #2 from Martin Renvoize --- Bug 24492 introduces a route to cashup without having point of sale enabled :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:21:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:21:17 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #11 from Jonathan Druart --- (In reply to Katrin Fischer from comment #10) > Hi Jonathan, > > can you add which LibreOffice version you have used for testing? Version: 6.1.5.2 > I have tested a bit and the issue seems to be that we used to export "empty > cell" with # in it, but we don't seem to do that with the authorised_value > and see_also columns consistently anymore? When I add back the #, the file > loads appears to be loading ok. It's actually exporting what we have in DB: MariaDB [koha_kohadev]> select tagfield, authorised_value from marc_tag_structure where frameworkcode="" and tagfield in ("018", "020"); +----------+------------------+ | tagfield | authorised_value | +----------+------------------+ | 018 | | | 020 | NULL | +----------+------------------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:28:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:28:11 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18143 --- Comment #12 from Jonathan Druart --- Ok, there was a change made by bug 18143 that introduced the export behaviour change. But it's from Feb 2017! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18143 [Bug 18143] Silence floody MARC framework export -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:28:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:28:11 +0000 Subject: [Koha-bugs] [Bug 18143] Silence floody MARC framework export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18143 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:29:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:29:42 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114935|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 116187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116187&action=edit Bug 27358: Add a generic way to handle API privileged access attributes deny-list This patch introduces a way for Koha::Object(s)->to_api to filter out attributes that require privileged access. It is done in a way that the 'public' parameter is recursively passed to nested objects in recursive to_api() calls. This way, Koha::Object-based classes can determine how they will render depending on this parameter. For example, for implementing a route for fetching an item looks like: GET /items The controller will look like: my $item = Koha::Items->find( $c->validation->param('item_id') ); return $c->render( status => 200, openapi => $item->to_api ); Implementing an unprivileged (public) route would look like: GET /public/items/:item_id The controller will look like: my $item = Koha::Items->find( $c->validation->param('item_id') ); return $c->render( status => 200, openapi => $item->to_api({ public => 1 }) ); To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object*.t => SUCCESS: Tests pass (i.e. current behaviour is kept, new behaviour passes the tests) 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:29:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:29:45 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114936|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 116188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116188&action=edit Bug 27358: Make is_public stashed on public routes This patch makes the API authentication code stash the 'is_public' value when public routes are hit. This will be particularly useful to have $c->objects->search generically pass this info down to the ->to_api method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t => SUCCESS: Tests pass! When a public route is reached, the controller has the 'is_public' value stashed 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:29:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:29:48 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114937|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 116189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116189&action=edit Bug 27358: Teach objects.search about public requests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:29:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:29:51 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114938|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 116190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116190&action=edit Bug 27358: Add GET /public/biblios/:biblio_id/items This patch introduces a route to fetch items belonging to a biblio. It is expected to return the 'public' representation of the Koha::Item objects. It is also enforcing the visibility rules, by using Koha::Items->filter_by_visible_in_opac. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Test pass and they cover all the cases! 3. Try your favourite REST tool against the new route. 4. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:29:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:29:55 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114939|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 116191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116191&action=edit Bug 27358: Unit tests for public items retrieval Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:31:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:31:10 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > Ok, there was a change made by bug 18143 that introduced the export > behaviour change. But it's from Feb 2017! But pushed in Feb 2019! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:32:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:32:59 +0000 Subject: [Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Martin Renvoize --- This works well and I like it.. signing off.. However, I have one security/qa comment... I think it would be best to reverse the logic here.. Instead of the `BlockList` approach, we have with `api_privileged_attrs` I think we should instead implement an `AllowList` to 'fail safe' if someone forgets to add a field to the list: `api_public_atts` perhaps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:39:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:39:16 +0000 Subject: [Koha-bugs] [Bug 27591] New: Inconsistent install values in biblio frameworks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27591 Bug ID: 27591 Summary: Inconsistent install values in biblio frameworks Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org For instance marc_tag_structure.authorised_value can be "" or NULL (not coming from bug 24594). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:40:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:40:01 +0000 Subject: [Koha-bugs] [Bug 27591] Inconsistent install values in biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27591 --- Comment #1 from Jonathan Druart --- Created attachment 116192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116192&action=edit Bug 27591: Set biblio framework AV to NULL instead of empty string -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:40:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:40:27 +0000 Subject: [Koha-bugs] [Bug 27591] Inconsistent install values in biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27591 --- Comment #2 from Jonathan Druart --- There is more to investigate here. We should also remove the entry from the yml and let the DBMS set the default value. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:40:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:40:44 +0000 Subject: [Koha-bugs] [Bug 27591] Inconsistent install values in biblio frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27569 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 10:40:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 09:40:44 +0000 Subject: [Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27591 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:02:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:02:06 +0000 Subject: [Koha-bugs] [Bug 8326] Allow patron attributes to be made repeatable after initial creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:02:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:02:09 +0000 Subject: [Koha-bugs] [Bug 8326] Allow patron attributes to be made repeatable after initial creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104517|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 116193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116193&action=edit Bug 8326: Make repeatable and unique_id modifiable when editing patron attribute type This patch add the ability to modify the attribute "repeatable" and "unique_id" for a patron's attribute type. Prior to this patch it was not possible, to keep data integrity. When editing an attr type, the controller will check is the value can be modified, depending on the existing patron's attributes. Test plan: 0/ Setup Create 1 patron attribute PA1 that can be repeatable Create 1 patron attribute PA2 that must be unique Create 1 patron attribute PA3 that cannot be repeatable and does not have the unique restriction 1/ Edit them and confirm that you can modify the repeatable and unique restrictions 2/ Restore values from 0. Create a patron P1 with several PA1, PA2=42 and whatever in PA3 3/ Edit PA1 => you cannot remove the repeatable flag but can still remove the unique 4/ Create a patron P2 with PA2=42 5/ Edit PA2 => you cannot remove the unique flag Play a bit more with the different combinaisons and confirm that it works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:04:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:04:55 +0000 Subject: [Koha-bugs] [Bug 8326] Allow patron attributes to be made repeatable after initial creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116193|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 116194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116194&action=edit Bug 8326: Make repeatable and unique_id modifiable when editing patron attribute type This patch add the ability to modify the attribute "repeatable" and "unique_id" for a patron's attribute type. Prior to this patch it was not possible, to keep data integrity. When editing an attr type, the controller will check is the value can be modified, depending on the existing patron's attributes. Test plan: 0/ Setup Create 1 patron attribute PA1 that can be repeatable Create 1 patron attribute PA2 that does not have the unique restriction Create 1 patron attribute PA3 that cannot be repeatable and does not have the unique restriction 1/ Edit them and confirm that you can modify the repeatable and unique restrictions 2/ Restore values from 0. Create a patron P1 with several PA1, PA2=42 and whatever in PA3 3/ Edit PA1 => you cannot remove the repeatable flag but can still remove the unique 4/ Create a patron P2 with PA2=42 5/ Edit PA2 => you cannot add the unique flag Play a bit more with the different combinaisons and confirm that it works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:05:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:05:05 +0000 Subject: [Koha-bugs] [Bug 8326] Allow patron attributes to be made repeatable after initial creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326 --- Comment #6 from Jonathan Druart --- Sorry David, I completely forgot this patch. There were some bugs indeed! I've improved the test plan a bit, hope it makes more sense now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:15:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:15:14 +0000 Subject: [Koha-bugs] [Bug 27534] koha upgrade throws SQL error while applying Bug 25333 - Change message transport type for Talking Tech from "phone" to "itiva" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27534 --- Comment #9 from Jonathan Druart --- Manos, it means you already have it in the table. MariaDB [koha_kohadev]> select count(*) from letter where message_transport_type="phone"; +----------+ | count(*) | +----------+ | 1 | +----------+ 1 row in set (0.000 sec) MariaDB [koha_kohadev]> UPDATE message_transport_types SET message_transport_type = "xxx" WHERE message_transport_type = "phone"; Query OK, 1 row affected (0.019 sec) Rows matched: 1 Changed: 1 Warnings: 0 MariaDB [koha_kohadev]> select count(*) from letter where message_transport_type="xxx"; +----------+ | count(*) | +----------+ | 1 | +----------+ 1 row in set (0.002 sec) That seems to work for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:30:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:30:19 +0000 Subject: [Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116184|0 |1 is obsolete| | --- Comment #2 from Ere Maijala --- Comment on attachment 116184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116184 Bug 27584: Refactor OAI-PMH paging to improve performance Initial patch was bad, needs some fixing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:37:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:37:46 +0000 Subject: [Koha-bugs] [Bug 27476] Improve link text for logging in on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115653|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 116195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116195&action=edit Bug 27476: Improve link text for logging in on OPAC (Note: Must have Shibboleth and CAS added to OPAC) 1. (Before downloading patch) Go to OPAC 2. Search for an item in the search bar (i.e. type 'a') 3. On one of the items, click on 'Place hold' 4. The links should say 'If you have a Shibboleth account, please click here to log in', 'Please click here to log in' and 'If you have a CAS account, please click here to log in' 5. Add patch 6. Repeat steps 1-3 7. The links should now say 'Log in using a Shibboleth account', 'Log in' and 'Log in using a CAS account' NOTE: Also noticed on the initial log in box there was the same issue - here is the testing for that: 1. Go to OPAC home page 2. In the top right click 'Log in to your account' 3. The link should say 'If you have a Shibboleth account, please click here to log in.' 4. Apply patch 5. Repeat steps 1&2 6. The link should now say 'Log in using a Shibboleth account' Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:38:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:38:02 +0000 Subject: [Koha-bugs] [Bug 27476] Improve link text for logging in on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27476 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Works well, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:40:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:40:12 +0000 Subject: [Koha-bugs] [Bug 27473] Improve link text in the installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- I'm not so sure about this change.. the two actions no longer seem related... it feels like you're now in a race against the reload to click a button you don't know where it goes... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:42:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:42:46 +0000 Subject: [Koha-bugs] [Bug 27398] Serials: Values in subscription length pull down are not translatable when defining numbering patterns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115631|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 116196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116196&action=edit Bug 27398: Made values in number patterns subscription length translatable TEST PLAN: Check that the subscription length options when editing or adding a numbering pattern in the serials module are translatable. check that the hard coded values are gone. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:43:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:43:29 +0000 Subject: [Koha-bugs] [Bug 27398] Serials: Values in subscription length pull down are not translatable when defining numbering patterns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Nice work, this is a great little improvement. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:47:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:47:07 +0000 Subject: [Koha-bugs] [Bug 27294] Error when deleting claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- I feel like this should be treated similarly to the claims table with load and refresh functions and a global scoped variable. Whilst the fix here, I think resolves this issue, I think there are other issues in the same script that appear to have the same underlying code issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:48:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:48:47 +0000 Subject: [Koha-bugs] [Bug 27294] Error when deleting claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:51:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:51:37 +0000 Subject: [Koha-bugs] [Bug 12260] Printing a page from bootstrap shows unnecessary links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115285|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 116197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116197&action=edit Bug 12260: Hide unnecessary links when printing TEST PLAN: try printing every page in the opac and confirm these sections don't show #cartmenulink { display: none; } #listsmenu { display: none; } #koha_url { display:none; } .breadcrumb { display:none; } a[href]:after { display:none; } #social_networks { display:none; } a.tag_add { display:none; } .results_summary.online_resources { display:none; } a#Normalview, a#MARCview, a#ISBDview { display:none; } .ui-tabs-panel { border:none !important; } #addcomment { display:none; } #ulactioncontainer { display:none; } #usermenu { display:none; } #didyoumean { display:none; } #top-pages, #bottom-pages { display:none; } #selections-toolbar { display: none; } .actions-menu { display: none; } #numresults a { display:none; } #numresults { float:left; } Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:51:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:51:40 +0000 Subject: [Koha-bugs] [Bug 12260] Printing a page from bootstrap shows unnecessary links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116028|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 116198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116198&action=edit Bug 12260: Minified CSS Signed-off-by: Stina Hallin Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 11:52:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 10:52:17 +0000 Subject: [Koha-bugs] [Bug 12260] Printing a page from bootstrap shows unnecessary links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Works as expected, no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 12:02:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 11:02:18 +0000 Subject: [Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116184|1 |0 is obsolete| | --- Comment #3 from Ere Maijala --- Comment on attachment 116184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116184 Bug 27584: Refactor OAI-PMH paging to improve performance Oops, the patch is fine (I messed up with Plack). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 2 12:05:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Feb 2021 11:05:38 +0000 Subject: [Koha-bugs] [Bug 27005] Adding a filter in the datatable of opac-readingrecord page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115928|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 116199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116199&action=edit Bug 27005: Adding a filter in the datatable of opac-readingrecord page This patch adds a search field and export options to the patron's checkout history table in the OPAC. This patch also adds some showing/hiding classes to controls which should only be seen by users with or without JavaScript: The