[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #68 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I'm getting test failures when trying to apply this to 20.05. Please address
for backport. Here's what I see:

$ prove t/db_dependent/ILSDI_Services.t
t/db_dependent/ILSDI_Services.t .. 1/10 Use of bare << to mean <<"" is
deprecated at t/db_dependent/ILSDI_Services.t line 452.
Use of bare << to mean <<"" is deprecated at t/db_dependent/ILSDI_Services.t
line 452.
Bareword found where operator expected at t/db_dependent/ILSDI_Services.t line
466, near "HEAD
    is"
  (Might be a runaway multi-line << string starting on line 459)
        (Do you need to predeclare HEAD?)
Global symbol "$module" requires explicit package name (did you forget to
declare "my $module"?) at t/db_dependent/ILSDI_Services.t line 454.
Global symbol "$module" requires explicit package name (did you forget to
declare "my $module"?) at t/db_dependent/ILSDI_Services.t line 455.
Global symbol "$issue" requires explicit package name (did you forget to
declare "my $issue"?) at t/db_dependent/ILSDI_Services.t line 456.
Global symbol "$origin_branch" requires explicit package name (did you forget
to declare "my $origin_branch"?) at t/db_dependent/ILSDI_Services.t line 463.
syntax error at t/db_dependent/ILSDI_Services.t line 466, near "HEAD
    is"
syntax error at t/db_dependent/ILSDI_Services.t line 466, near ""Patron has
issued same book" )"
Global symbol "$reply" requires explicit package name (did you forget to
declare "my $reply"?) at t/db_dependent/ILSDI_Services.t line 467.
Global symbol "$biblio_with_no_item" requires explicit package name (did you
forget to declare "my $biblio_with_no_item"?) at
t/db_dependent/ILSDI_Services.t line 490.
Global symbol "$query" requires explicit package name (did you forget to
declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 495.
Global symbol "$query" requires explicit package name (did you forget to
declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 496.
Global symbol "$query" requires explicit package name (did you forget to
declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 497.
Global symbol "$biblio_with_no_item" requires explicit package name (did you
forget to declare "my $biblio_with_no_item"?) at
t/db_dependent/ILSDI_Services.t line 497.
Global symbol "$query" requires explicit package name (did you forget to
declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 498.
Global symbol "$reply" requires explicit package name (did you forget to
declare "my $reply"?) at t/db_dependent/ILSDI_Services.t line 500.
Global symbol "$query" requires explicit package name (did you forget to
declare "my $query"?) at t/db_dependent/ILSDI_Services.t line 500.
Global symbol "$reply" requires explicit package name (did you forget to
declare "my $reply"?) at t/db_dependent/ILSDI_Services.t line 501.
syntax error at t/db_dependent/ILSDI_Services.t line 503, near ">>"
t/db_dependent/ILSDI_Services.t has too many errors.
# Looks like your test exited with 255 just after 1.
t/db_dependent/ILSDI_Services.t .. Dubious, test returned 255 (wstat 65280,
0xff00)
Failed 9/10 subtests 

Test Summary Report
-------------------
t/db_dependent/ILSDI_Services.t (Wstat: 65280 Tests: 1 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 10 tests but ran 1.
Files=1, Tests=1,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.67 cusr  0.14
csys =  0.84 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.