[Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

--- Comment #61 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 115852
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115852
Bug 24850: Correct offset handling in dt_from_string

Review of attachment 115852:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24850&attachment=115852)
-----------------------------------------------------------------

::: Koha/DateUtils.pm
@@ +160,5 @@
>              second => $+{second},
>          );
>          $ampm = $+{ampm};
> +        if ( $+{offset} ) {
> +            $tz = DateTime::TimeZone->new( name => $+{offset} . $+{hours} . $+{minutes} );

You might want to call them offset_hours and offset_minutes, because they're so
close to "hour" and "minute" that I had to do a double-take to make sure they
were right.

-- 
You are receiving this mail because:
You are watching all bug changes.