[Koha-bugs] [Bug 27503] Rename system preference virtualshelves to OpacLists

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27503

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David,

> 1. Should it be OpacLists or OPACLists - the naming of system preferences
> with either OPAC or Opac in the name is a bit of a mixed bag! I think I
> would prefer OPAC, so it would then be OPACLists.

I don't have a preference there, but OPACLists makes sense.

> 2. Database update - is there supposed to be a database update for this
> change? There is nothing in the patch, so running updatedatabase doesn't do
> anything.

We definitely need a database update. It looks like something went wrong here,
as the initial patch made many more changes to files and included a database
update. But doesn't have the new name now :(

I believe git bz is to blame. The follow-up had the exact same subject, so one
got overwritten with the other. It also needs to be fixed to reflect the new
name we picked.

> 3. Text for system preference description - Opac should be spelt as OPAC to
> be consistent with other descriptions for system preferences. Also "saved
> lists of books" - as the lists could include catalog records for many types
> of things, maybe a more generic wording could be used, such as records or
> items. My suggestion would by: 
> 
> "Allow staff and patrons to create and view saved lists of items in the
> OPAC: "

Actually, I would much prefer records, as lists can only be used on record
level and this would lead to a lot of wrong translations (I know in English
lists have items, but not the same word in other languages :) )

-- 
You are receiving this mail because:
You are watching all bug changes.