[Koha-bugs] [Bug 27654] "Table settings for Pages" need to be sorted on "Administration -> Table settings"

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Feb 9 00:50:53 CET 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27654

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116500|0                           |1
        is obsolete|                            |

--- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 116532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116532&action=edit
Bug 27654: Sort module.keys hash when render columns_settings.tt

On the "Administration -> Table settings" page, the order of
"tables related to pages" sections is different with each page refresh.
Cause of that is that Perl gives random order for hash keys where
those elements are stored on template render. To avoid that we
add a "sort" method where getting keys similarly how it was done
previously to display tables always in the same order.

To reproduce:
    1) Head over to /cgi-bin/koha/admin/columns_settings.pl
    2) Open any collapsed module settings, for example
"Acquisition tables". Check the order of pages.
    3) Reload the page. Check the order of the same elements again.
They always come in random order, it's easily distinguishable.
    4) Apply the patch.
    5) Repeat steps 1-3 again and ensure that the order of pages
stays the same no matter how many times you reload the page.

Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list