[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed
             Status|Passed QA                   |Failed QA

--- Comment #74 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1.
+sub priority {
+    my ($self) = @_;
+
+    return $self->has_priority;
+}

It does not seem very useful, especially when it's only used once, from test.

2.
+ALTER TABLE circulation_rules ADD KEY (branchcode , categorycode, itemtype,
has_priority);

Why?
Note that it's missing from kohastructure.sql

3. There is a shift when you edit the line, the "unlimited" (stupid) trick

The followin line (smart-rules.tt):
1169                         } else if ( i == 5 || i == 6 || i == 26 || i == 27
|| i == 28 ) {

4. I think we need a hint on the UI (tooltip on the "Has priority" header?) to
explain what this column is about.

5. Reading the code I don't understand why the first query in
get_effective_rule is not passing the item type.

211     $search_params->{rule_name} = $rule_name;
212     $search_params->{categorycode} = defined $categorycode ? [
$categorycode, undef ] : undef;
213     $search_params->{has_priority} = 1;

What will happen if
Cat 1 | BK | has priority | max_holds = 5
Cat 1 | VID | has priority | max_holds = 2

It feels like you are going to get a random value.

-- 
You are receiving this mail because:
You are watching all bug changes.