[Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #25)
> There is a failing test on My8
> 
>     #   Failed test 'income_grouped arrayref is correct'
>     #   at t/db_dependent/Koha/Cash/Register/Cashup.t line 223.
>     #     Structures begin differing at:
>     #          $got->[0]{debit_type}{description} = 'Overdue fine'
>     #     $expected->[0]{debit_type}{description} = 'Account creation fee'
>     # Looks like you failed 1 test of 29.
> 
> The order is different that the one we expect, I think we should order by
> created_on.

Actually.. I opted for an explicit sort on the description. I think this is
more useful to the end user and also it prevents us hitting up against issues
with the created_on field not being part of the grouping.

We could, alternatively, sort on the amounts. This is a SUM, however, and I'm
not sure how nicely that plays either.. and I personally think the alpha sort
is more useful to end users who may want to compare one summary to another.

-- 
You are receiving this mail because:
You are watching all bug changes.