[Koha-bugs] [Bug 27718] Holds to Pull list doesn't respect holdallowed circulation rule anymore

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27718

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 116941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116941&action=edit
Bug 27718: (bug 24488 follow-up) Hide items not holdable

After bug 24488 was merged Holds to Pull list
(/cgi-bin/koha/circ/pendingreserves.pl)
doesn't respect anymore the 'holdallowed' circulation rules (we bisected it to
this change).
If we look at the patch "Bug 24488: Show correct first patron details on Holds
to pull"
(2285c2d6575) then we can notice that previously the items that were shown in
the list
must had holdallowed != 0:

Now it seems like similar circ rule check is missing in the newly rewritten
Holds To Pull implementation.
(description copied from comment 0)

Test plan:
Have several pending holds
Mark some item type as not holdable in the circulation rules
Confirm that the non holdable items are no longer listed on the "Holds
to pull" view

-- 
You are receiving this mail because:
You are watching all bug changes.