[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

--- Comment #5 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 116950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116950&action=edit
Bug 25690: Remove duplicated logic in SIP2 checkouts

Because AllowItemsOnHoldCheckoutSIP only affects the checkoutability
of non-attached, i.e. RESERVED holds in SIP2 we can therefore use the
common code from CanBookBeIssued and ignore only the RESERVED confirmation
message case in SIP2 checkout code.

This slightly changes the checkout error message given for "In
processing" holds that someone other than the holdee tries to
checkout. Otherwise there is no logic changes. The message that this
changes is "Item is on hold for another patron." vs. now "Item cannot
be issued: $confirmation". It is easier to create follow-up patch to
properly add INPROCESSING confirmation to CanBookBeIssued and then
show correct message based on the CanBookBeIssued return value.

-- 
You are receiving this mail because:
You are watching all bug changes.