[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116948|0                           |1
        is obsolete|                            |
 Attachment #116949|0                           |1
        is obsolete|                            |
 Attachment #116950|0                           |1
        is obsolete|                            |
 Attachment #116951|0                           |1
        is obsolete|                            |

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 117000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117000&action=edit
Bug 25690: Remove double usage of 'Reserved' return value

The patch "Bug 19116: Hold not set to waiting after transfer" added a
new meaning to 'Reserved' return value of C4::Reserves::CheckReserves
function. Let's remove double usage and have separate Transferred
return value so we can differentiate between attached and non-attached
holds. This will come useful in future refactorings.

This patch does no changes to the logic except in the
/cgi-bin/koha/circ/branchtransfers.pl and circulation.pl we now give
similarly to waiting state notice about hold being transferred.

To test:
   1) Apply this patch
   2) Create a new item level hold so that pickup library is different
   than where the item is currently. Then return the item so that hold
   is being attached and transferred.
   3) Go to branchtransfers.pl and try to create a new transfer: it
   should prompt you with message "Item is attached to a hold and
   being transferred for XXX" and provide you with option to cancel
   the hold or to ignore the transfer.

-- 
You are receiving this mail because:
You are watching all bug changes.