[Koha-bugs] [Bug 20028] Export all patron related personal data in one package

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028

--- Comment #34 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Michal Denar from comment #33)
> Lari,
> is this patch ready to testing? Because status is still In Discussion.
> 
> Thank you.

Short answer: Sign-off testing no, testing out of curiosity yes.

Longer answer: In discussion is the correct status. There are many ways to
implement this feature, and as mentioned in comment #32, I'm still curious of
what others think of this approach.

The response body is something that needs to be discussed. There are open
questions regarding terminology, property extension and pagination.

The current patches completely ignore any REST API terminology guidelines we
use. In comment #21 I have asked if we should first implement something that
just returns all the data, and later enhance it in a different Bug. This will
become a terminology hell, because there are many many many related objects
(around 50) that ideally should be terminologically consistent. I'm not sure if
this Bug is the correct place for that.

In comment #22, I have asked about extending properties so that for example
items would include a biblio.title.

We also need pagination, but paginating the currently proposed model would be
weird. How would one paginate such response? Should we instead return an array
of objects with the same structure, such as:

[
  {
    "type": "MESSAGE",
    "object": {
      "message_id": 123,
      ... // the message object
    }
  },
  { 
    "type": "CHECKOUT",
    "object": {
       "checkout_id": 456,
       ... // the checkout object
     }

]

Here the pagination would be clearer.

I will ask these questions on koha-devel mailing list.

Also related:
https://wiki.koha-community.org/wiki/Public_patrons_export_endpoint_RFC

Anyway, the patches are working and can be tested, but I wouldn't yet sign-off
them.

-- 
You are receiving this mail because:
You are watching all bug changes.