[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |joonas.kylmala at helsinki.fi

--- Comment #36 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
ReserveExpiration should be moved out of set_waiting() method because it makes
using set_waiting method really confusing because you are really expecting it
to only set the waiting status and not do much more, documentation and testing
of the function becomes also more difficult. The best way to do this would be
to block adding expiration date already when creating a new hold. So please add
the necessary code to OPAC, Staff and REST. For OPAC and Staff I see there is
already some code, REST is missing completely. Also if I'm not mistaken the
reason you added ReserveExpiration to set_waiting() is because of
ReservesMaxPickUpDelay not working really well – what you could do here is do a
DB upgrade so that ReservesMaxPickUpDelay value '' => 0 so then when
ReservesMaxPickUpDelay is not an integer value it would simply not add
expiration date.

-- 
You are receiving this mail because:
You are watching all bug changes.