[Koha-bugs] [Bug 25078] Gracefully stop updatedatabase/installer when a database change cannot be applied

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078

--- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #27)
> I suggested that approach ~8 years ago, and it got abandoned (bug 7167). I
> am not against the idea but it's weird we finally get back to it...
Maybe you were a misunderstood avant-gardiste :-)
On a more serious note, I really liked the idea of bug 7167 at the time, but I
think it tried to do too much at once (with a UI, and ability to re-execute
failed DB updates from the UI, ...), which made it complicated to test

> I personally don't think we should get rid of the "version" syspref. Mainly
> because of this:
>     if ( Koha::Migrations->pending_migrations > 0 ) {
> 
> We are going to execute it for every hit (at the OPAC at least): 1 SQL query
> + 1 list of the directory.
There are probably ways of making it less painful for performance, like caching
the directory listing in memcached. The Version syspref is in cache too, so it
should not change anything from a "behaviour" point of view.
Another way could be to move the check to the start of the application (in the
.psgi), so that it's checked only once (if we update the sources, we have to
restart starman anyway)
This implementation is a proof of concept. I'm sure it can be improved.

-- 
You are receiving this mail because:
You are watching all bug changes.