[Koha-bugs] [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Feb 23 14:41:15 CET 2021
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071
Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117189|0 |1
is obsolete| |
--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 117209
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117209&action=edit
Bug 27071: (follow-up) Get rid of loop
This patch gets rid of a loop on the librarary's groups siblings, and
acknowledges ->get_hold_libraries returns a proper Koha::Libraries
iterator that can be chained with a new query on the passed branchcode.
This way we only fetch a count from the DB and no loop needs to take
place on the code.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Libraries.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list