[Koha-bugs] [Bug 14233] Add logging support to notices and slips management

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #24 from David Nind <david at davidnind.com> ---
I had a go at testing this and a few things I noted:

1. The link in the log viewer 'Object' column doesn't go to the actual notice -
it just lists the notices. This is because there are two ?? after letter.pl
(for example:
/cgi-bin/koha/tools/letter.pl??op=add_form&branchcode=&module=members&code=A_NOTICE_2&lang=default)

2. I'm not sure whether changes to the notice name should be logged or not - if
I change the notice name it doesn't show in the log. I'm therefore assuming
that only actual changes to the notice itself are logged.

3. The changes logged - I'm not sure whether this is the correct behaviour, but
assume it is:
   . If I make a change to a notice, in the log viewer 'Info' column it shows
what it was before the change was made.
   . If that is what is expected, then it is working - you can only compare
previous changes, but not to the current version of the notice.

4. I could add new notices, the change was logged, and I didn't get the error
the Owen did in Comment 19, presumably because of the follow up patch.

5. Is it possible to add the notice code somewhere? Maybe in front of the
notice name in the log viewer's 'Object' column. Maybe a future enhancement?

6. I was confused that there is already a 'Letter' module listed (before and
after the patch is applied). Is the 'Letter' module something different from
the 'Notices' module, or the same - I prefer notices as it matches up with the
name in the tools section.

Sorry about all the questions!

Testing notes (using koha-testing-docker):
- Apply patches and then updatedatabase, dbic, flush_memcached, restart_all
- MySQL commands for database table checks in test plans:
  . koha-mysql kohadev
  . show columns from letter;
  . show index from letter;

-- 
You are receiving this mail because:
You are watching all bug changes.