[Koha-bugs] [Bug 27718] Holds to Pull list doesn't respect holdallowed circulation rule anymore

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27718

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #6 from Andrew Nugged <nugged at gmail.com> ---
circ/pendingreserves.pl

197: my $all_items;
198: foreach my $item ( $holds->get_items_that_can_fill ) {
199:     push @{$all_items->{$item->biblionumber}}, $item;
200: }
201: 

Software error:
The method Koha::Items->biblionumber is not covered by tests!

Trace begun at .../Koha/Objects.pm line 592
Koha::Objects::AUTOLOAD('Koha::Items=HASH(0x55dd70618e38)') called at
.../circ/pendingreserves.pl line 199


I just researched, it's because of missing return and then DBIXc doesn't sense
"wantarray", I assume.

-    my $items = Koha::Items->search(
+    return Koha::Items->search(

worked.

Let me Sign-it-off patched :) ...

-- 
You are receiving this mail because:
You are watching all bug changes.