[Koha-bugs] [Bug 14233] Add logging support to notices and slips management

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to David Nind from comment #24)

Great feedback David, thanks for testing :)

> 1. The link in the log viewer 'Object' column doesn't go to the actual
> notice - it just lists the notices. This is because there are two ?? after
> letter.pl (for example:
> /cgi-bin/koha/tools/letter.
> pl??op=add_form&branchcode=&module=members&code=A_NOTICE_2&lang=default)

Good catch, fixed in the first QA follow-up.

> 2. I'm not sure whether changes to the notice name should be logged or not -
> if I change the notice name it doesn't show in the log. I'm therefore
> assuming that only actual changes to the notice itself are logged.

I didn't add logging for title changes at this time, but perhaps that could be
added too.. I wasn't sure of the best format to take though and felt at the
moment it was more important to expose the template changes diff view than
record the title changes and lose the diff view. Perhaps a later followup bug
:)

> 3. The changes logged - I'm not sure whether this is the correct behaviour,
> but assume it is:
>    . If I make a change to a notice, in the log viewer 'Info' column it
> shows what it was before the change was made.
>    . If that is what is expected, then it is working - you can only compare
> previous changes, but not to the current version of the notice.

Oops, this is a mistake on my part, it should be the 'after' so we can do the
comparison with current and prior. I've corrected this in the second QA
follow-up.

> 4. I could add new notices, the change was logged, and I didn't get the
> error the Owen did in Comment 19, presumably because of the follow-up patch.

Correct, that was the earlier follow-up :)

> 5. Is it possible to add the notice code somewhere? Maybe in front of the
> notice name in the log viewer's 'Object' column. Maybe a future enhancement?

Done, added in the 'follow-up'.

> 6. I was confused that there is already a 'Letter' module listed (before and
> after the patch is applied). Is the 'Letter' module something different from
> the 'Notices' module, or the same - I prefer notices as it matches up with
> the name in the tools section.

I hadn't even noticed the existing 'Letter' filtering.. when I dug into it, it
seems that it's linked to the acquisitions claims emails.  I wonder if we could
rename it to 'Claims' in the UI to clarify it?

-- 
You are receiving this mail because:
You are watching all bug changes.