[Koha-bugs] [Bug 26317] Misleading choices from reports error when runtime parameter is named incorrectly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26317

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I just tested this on master a bit. There's some inconsistency in behavior
here, perhaps based on complexity of the report?

My original example of "SELECT <<whatever|whatever>>" does not drop any content
when you try to save it.

If I try to save a report of:
SELECT if(1=1,'dur','ohno')
WHERE poodle=<<dog|woof>>

I click save, get the parameter error message, click "save anyway," end up
with:
SELECT if(1=1,

Or, for a less silly example, this report has "branch" where it should say
"branches":
SELECT itemtypes.description as itemtype,
        branchname,
    sum(if(type='issue',1,0)) as issues,
    sum(if(type='renew',1,0)) as renews
FROM statistics
        LEFT JOIN itemtypes USING (itemtype)
    LEFT JOIN branches ON (statistics.branch=branches.branchcode)
WHERE date(datetime) BETWEEN <<Start date|date>> AND <<End date|date>>
    AND branch like <<Branch|branch:all>>
GROUP BY itemtype, branch

And after trying to save it I end up with:
SELECT itemtypes.description as itemtype,
        branchname,
    sum(if(type=

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.