[Koha-bugs] [Bug 27806] New: Exceptions thrown during a call to ->render are not caught and passed to ->unhandled_exception

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27806

            Bug ID: 27806
           Summary: Exceptions thrown during a call to ->render are not
                    caught and passed to ->unhandled_exception
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        Depends on: 27680

Whilst working on 27680 I discovered that we do not catch exceptions that are
thrown at the point of render.

I failed to resolve the problem there so have moved this piece to it's own bug.

The tests added catch the 500 responses and those responses are the HTML
rendered Mojo::Exception templates..

I'll attach the patches I came up with that are not working as expected :(.

I've also tried using

$self->helper( 'reply.exception' => sub { my ($page, $c, $e) = @_; # Custom
error page handling here } );

and

$self->before_render => sub {

  my ($c, $args) = @_;

  # Make sure we are rendering the exception template
  return unless my $template = $args->{template};
  return unless $template eq 'exception';

  # Switch to JSON rendering if content negotiation allows it
  return unless $c->accepts('json');
  $args->{json} = {exception => $c->stash('exception')};
};

and neither appeared to work :(


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680
[Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field
columns
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.