From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 10:56:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2021 09:56:22 +0000 Subject: [Koha-bugs] [Bug 27322] New: Hacked By ./AlfanXploit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27322 Bug ID: 27322 Summary: Hacked By ./AlfanXploit Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.druart at bugs.koha-community.org Reporter: alfanajisetia at gmail.com Created attachment 114764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114764&action=edit Hacked By ./AlfanXploit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 18:27:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2021 17:27:53 +0000 Subject: [Koha-bugs] [Bug 27322] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27322 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Hacked By ./AlfanXploit |SPAM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 1 18:59:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jan 2021 17:59:25 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #46 from Victor Grousset/tuxayo --- Good, there doesn't seem to be a bad choice. Thanks for the info Andrew, that was my 2 cents, I'll leave the rest to more knowledgeable people ^^" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 15:10:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 14:10:45 +0000 Subject: [Koha-bugs] [Bug 27323] New: Plugin for Place of Publication 260$a Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27323 Bug ID: 27323 Summary: Plugin for Place of Publication 260$a Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: rtr.himanshu at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl There is no option to search for Place of Publication like 260$b like Publsiher name. I hope someone can look into this option making Place of Publication searchable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 18:39:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 17:39:34 +0000 Subject: [Koha-bugs] [Bug 27305] iCal feed for circulation issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305 --- Comment #5 from Nico Bako --- Update: the url I have mentioned above (with user name and password provided) works for my Google calendar feed. Since this is all I really wanted to do, and I am quite happy with the solution, feel free to close this issue if you want to. Yeah, I know it's not secure to pass user name and password in a url, but I only use this url on my Google calendar, and if my Google account gets hacked, then I have other more serious stuff to worry about... What I would really like to see, to help make the authentication more secure, is to have another way other than providing user name and password in the url. Many sites provide the ability to create an API token which can be used for authentication instead. Something like that would be great, but probably outside the scope of this issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 18:54:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 17:54:43 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 18:54:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 17:54:46 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114742|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 114765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114765&action=edit Bug 27310: Remove CSS float on 'Visibility' in framework edition In administration > framework edition > subfield edition, 'Visibility' label as a CSS rule float none. This seems obsolete, removing it will align label like others. Test plan : 1) Go to Administration 2) Edit any framework 3) Edit any subfield 4) Look at 'Visibility' => Without patch label is sticked to the left => With patch label postion is like others Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 18:55:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 17:55:10 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 --- Comment #6 from Katrin Fischer --- Nice little patch, thx Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 19:19:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 18:19:55 +0000 Subject: [Koha-bugs] [Bug 27324] New: Use Koha.Preference() for intranetbookbag everywhere Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Bug ID: 27324 Summary: Use Koha.Preference() for intranetbookbag everywhere Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org By using Koha.Preference() in the templates everywhere, we can remove the variable from Auth.pm in the end. After bug 27031, it looks like the remaining instances are: C4/Auth.pm: intranetbookbag => C4::Context->preference("intranetbookbag"), koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt: [% IF ( intranetbookbag ) %] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: [% IF ( intranetbookbag ) %] koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc:[% IF ( virtualshelves && intranetbookbag ) %] koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc:[% ELSIF ( intranetbookbag ) %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 19:21:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 18:21:36 +0000 Subject: [Koha-bugs] [Bug 27324] Use Koha.Preference() for intranetbookbag everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 19:21:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 18:21:44 +0000 Subject: [Koha-bugs] [Bug 27324] Use Koha.Preference() for intranetbookbag everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 19:21:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 18:21:44 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 [Bug 27324] Use Koha.Preference() for intranetbookbag everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 19:21:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 18:21:53 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 --- Comment #3 from Katrin Fischer --- The patch itself is ok, but I wonder if we should remove all remaining instances of the variable and also the code from Auth.pm. I have filed bug 27324 for a possible follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 19:22:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 18:22:25 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 19:22:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 18:22:29 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114753|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 114766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114766&action=edit Bug 27031: Use Koha.Preference() more often in header.inc and js_includes.inc This patch uses the Koha.Preference() macro more often in key includes. (In the longer term, it will help reduce dependency in problematic C4::Auth code.) Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl 2. Note "Cart" link in nav bar 3. Click "Cart" and note "Your cart is currently empty" text 4. Click "More" and note "Course Reserves" in dropdown menu 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 6. Click "Select all" above search results 7. Click "Add to cart" 8. Note "Cart" now has 3 displaying next to it 9. Click "Cart" 10. Note there are three titles in the cart 11. Click "Empty and close" and click "OK" to confirm 12. Note "Cart (0)" now appears in the top nav 13. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 14. Save the following content in the system preference:
  • New Home
    • 15. Refresh the page 16. Note "New Home" appears in the top nav between "Cart" and "More" Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 19:29:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 18:29:29 +0000 Subject: [Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 19:29:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 18:29:33 +0000 Subject: [Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114151|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 114767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114767&action=edit Bug 27135: Adjust "upload image" button when viewing item's cover images When viewing the cover image of an item, the "upload image" button is about to upload an image at biblio level. Test plan: - Attach a cover image to an item - View it - Notice the "Upload image" button, confirm that with this patch applied the wording changed and that clicking it will attach a cover image to the item - Attach a cover image to the biblio - View it - Notice the "Upload image" button, confirm that with this patch applied the wording changed and that clicking it will attach a cover image to the biblio Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 2 20:04:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jan 2021 19:04:41 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |the 'Visibility' label when | |editing subfields for a | |framework. The label is now | |aligned correctly with the | |other labels. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 02:43:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 01:43:13 +0000 Subject: [Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 02:43:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 01:43:17 +0000 Subject: [Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114520|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 114768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114768&action=edit Bug 27276: Prevent borrowers-force-messaging-defaults.pl to crash MySQL 5.7 does not allow queries using 0000-00-00 Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:21:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:21:05 +0000 Subject: [Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:34:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:34:34 +0000 Subject: [Koha-bugs] [Bug 27325] New: Fix singular/plural forms on the OPAC dashboard Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 Bug ID: 27325 Summary: Fix singular/plural forms on the OPAC dashboard Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 26123 At the moment the dashboard panel on the OPAC start page uses "checkout(s)", "overdue(s)", "hold(s)" etc. We have the tools now to deal with these in a nicer way, showing "1 hold" and "2 holds" and deal with these nicely in translations as well. For documentation see: https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_context,_and_more_RFC For an example see the result list on the staff side: https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt#L535 [% tnx('{count} item', '{count} items', SEARCH_RESULT.items_count, {count = SEARCH_RESULT.items_count}) | html %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:34:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:34:34 +0000 Subject: [Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27325 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 [Bug 27325] Fix singular/plural forms on the OPAC dashboard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:35:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:35:25 +0000 Subject: [Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 --- Comment #22 from Katrin Fischer --- I've filed bug 27325 for a possible follow-up. No blocker here for me, as this patch follows the existing pattern and I think we should fix them all together which is out of scope here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:36:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:36:36 +0000 Subject: [Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:36:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:36:40 +0000 Subject: [Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112519|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Created attachment 114769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114769&action=edit Bug 26123: Add message notification to patron dashboard Test plan: 1. Apply patch, restart_all 2. Add some OPAC messages by clicking 'Add a message' on Home › Circulation › Checkouts › patron 3. Log into the OPAC as that patron and you should see a notice about how many messages you have with a link to opac-user.pl 4. Add multiple OPAC messages and make sure it all continues to work. 5. Also add an OPAC note from memberentry.pl. Refresh the OPAC and you should see a 1 message added to the total 6. Try an OPAC without any messages. If there are no messages or any other kind of notification the dashboard should NOT appear at all. 7. Add a 'staff - internal' note. It should not count towards your total messages in the dashboard. 8. Test it with some other notices that would appear on the dashboard, checkouts, holds, overdues. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:48:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:48:34 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 --- Comment #15 from Katrin Fischer --- In the end this boils down to a nice small change. Found no regressions looking at a lot of pages that use the shelvingloc class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:49:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:49:16 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:49:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:49:19 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112996|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 114770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114770&action=edit Bug 25462: Shelving location should be on a new line in holdings table This patch moves the shelving location a new line after the Home library in the holdings table. To test: 1) Assign a shelving location with a long description to an item. 2) See that it displays on the same line as the Home Library in /cgi-bin/koha/catalogue/detail.pl 3) Apply the patch 4) Check that the shelving location is now on a new line Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:49:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:49:23 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112997|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 114771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114771&action=edit Bug 25462: Show shelving location on a new line after home library (staff client) This patch updates the staff client CSS to move the shelving location a new line after the 'Home library' in list of holdings on the bibliographic detail page. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a title in the staff client which has items with a shelving location. - View the detail page for that title. In the table of holdings, confirm that the shelving location information is on a separate line from the home library information. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:49:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:49:27 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112998|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 114772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114772&action=edit Bug 25462: Show shelving location on a new line after home library (OPAC) This patch updates the OPAC CSS to move the shelving location a new line after the 'Home library' in list of holdings on the bibliographic detail page. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Locate a title in the OPAC which has items with a shelving location. - View the detail page for that title. In the table of holdings, confirm that the shelving location information is on a separate line from the home library information. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:49:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:49:30 +0000 Subject: [Koha-bugs] [Bug 25462] Shelving location should be on a new line in holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113092|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 114773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114773&action=edit Bug 25462: (follow-up) Remove
    as it is no longer needed Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:52:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:52:29 +0000 Subject: [Koha-bugs] [Bug 26925] Pickup library list should be in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26925 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #6 from Katrin Fischer --- Patch no longer applies, please rebase! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 15:59:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 14:59:53 +0000 Subject: [Koha-bugs] [Bug 26707] Split cart and lists button on bibliographic detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26707 --- Comment #10 from Katrin Fischer --- I really like this change. An additional thought: When adding to an existing list from the detail page, the pop-up seems superfluous. Having it work a little more like the cart there might be nice, just displaying a "success" hint. I could file a new bug if you think this might be worthwhile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 16:01:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 15:01:44 +0000 Subject: [Koha-bugs] [Bug 26707] Split cart and lists button on bibliographic detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 16:01:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 15:01:47 +0000 Subject: [Koha-bugs] [Bug 26707] Split cart and lists button on bibliographic detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113024|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 114774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114774&action=edit Bug 26707: Split cart and lists button on bibliographic detail pages This patch modifies the toolbar shown on bibliographic detail pages so that the "Add to cart" and "Add to lists" buttons are separate. The "Add to cart" will now reflect whether the title is in the cart. The "Add to lists" button will now be a menu of list choices like it is on the search results page. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Search for a title in the staff client and view the detail page for one of the results. Testing the cart button: - In the toolbar you should see an "Add to cart" button and an "Add to lists" menu button. - Clicking the "Add to cart" button should show the cart message associated with cart link in the header. - The label showing the number of items in the cart should be incremented. - The button should change to a "Remove from cart" button. - Clicking the "Remove from cart" button should correctly remove the item from the cart: - The label showing the number of items in the cart should be decremented. - The button should change to "Add to cart." - Add a title to the cart and click the cart link in the header to open the cart pop-up window. - Click the "Empty and close" button in the cart window. - After you confirm the cart window should close. The "Remove from cart" button should now be an "Add to cart" button. - Add a title to the cart and navigate between each of the other views of that title: Normal, MARC, Labeled MARC, and ISBD. On each page you should see a "Remove from cart" button. - Test the add and remove functions from each of the other bibliographic detail views. Testing the lists button: - On the normal bibliographic detail page you should see an "Add to list" menu button. Clicking it should reveal the same kind of lists menu you see on the catalog search results page, with recent public and private lists and options for "More lists" and "New list." - Test that each of these options works correctly to trigger the expected pop-up window. - Confrim that the correct title is added to the correct list. - Perform this test from each of the bibliographic detail pages: Normal, MARC, Labeled MARC, and ISBD. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 16:21:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 15:21:16 +0000 Subject: [Koha-bugs] [Bug 27326] New: Hacked By ./AlfanXploit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27326 Bug ID: 27326 Summary: Hacked By ./AlfanXploit Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.druart at bugs.koha-community.org Reporter: alfanajisetia at gmail.com Created attachment 114775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114775&action=edit Hacked By ./AlfanXploit Hacked By ./AlfanXploit - JawaDarkSec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 16:34:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 15:34:26 +0000 Subject: [Koha-bugs] [Bug 27326] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27326 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Hacked By ./AlfanXploit |SPAM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 3 18:19:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 17:19:16 +0000 Subject: [Koha-bugs] [Bug 27164] Fix item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | Patch complexity|Trivial patch |Small patch CC| |victor at tuxayo.net --- Comment #15 from Victor Grousset/tuxayo --- Hi :) Much needed improvements and I get better results by default on LibreOffice. The only issue found is about removing the space between title and author. Here is an example: "Laurel & ""Hardy""Hammarberg, Marcus." without quotes to Hardy, I would get "Laurel & HardyHammarberg, Marcus." Other examples 'More fruitful than the soil' :Mackillop, Andrew. "A Hegel dictionary /Inwood, Michael," "A tribute to Jack JohnsonDavis, Miles," The table HTML view and the detail page of the record insert a space between title and author. So it seems pretty sure we need to have that here. Which also means the "by" in UNIMARC case don't need a space before and after, otherwise the space will be duplicated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 00:18:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 23:18:22 +0000 Subject: [Koha-bugs] [Bug 21325] Prevent authentication when sending userid and password via querystring parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21325 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 00:20:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 23:20:02 +0000 Subject: [Koha-bugs] [Bug 27305] iCal feed for circulation issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305 --- Comment #6 from David Cook --- (In reply to Nico Bako from comment #4) > My library is Huntsville Madison County Public Library. It looks like Bywater Solutions is probably the vendor for that one. Hopefully Huntsville get in touch with them, as it would be an interesting feature. > What I would really like to see, to help make the authentication more > secure, is to have another way other than providing user name and password > in the url. Many sites provide the ability to create an API token which can > be used for authentication instead. Something like that would be great, but > probably outside the scope of this issue. I'm not 100% sure what you mean by "API token" in this case. Koha already uses short-lived API tokens using OAuth2 for its HTTP API. I'm guessing you might mean something like an "API key" although even then you'd want to send it via a HTTP header or as POST data for security purposes. However, for your use case, you really do need some kind of generic authentication token that can be put into a URL parameter. It would be interesting to create "read tokens" with minimal fine-grained authorization. For instance, a read token that can only access your current due dates. That way someone can't re-use that token to review your past reading history, access your personal information, etc. > Yeah, I know it's not secure to pass user name and password in a url, but I > only use this url on my Google calendar, and if my Google account gets > hacked, then I have other more serious stuff to worry about... I understand that perspective, but the thing is your Google account doesn't have to be hacked. I don't intimately know Google's internal security practices, but storing a password in plain text that presumably any Google employee could read is not great. Or storing a password in plain text in the event that say all Google calendar links get leaked/dumped without any accounts being breached per se. But since this is a case of one person exploiting a quirk in the system... it's probably not a huge drama. And it is one that I hope will be closed in the future ;). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 00:29:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 23:29:55 +0000 Subject: [Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 --- Comment #19 from David Cook --- Nick added a See Also to Bug 11299 which adds a button for doing the linking while cataloguing along with a summary at that time. Not quite what I had in mind, but it seems like it would be very useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 00:30:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 23:30:17 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #186 from David Cook --- Sounds quite useful! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 00:34:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 23:34:28 +0000 Subject: [Koha-bugs] [Bug 27324] Use Koha.Preference() for intranetbookbag everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Sounds good to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 00:58:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 23:58:15 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 --- Comment #13 from David Cook --- This probably relates to an issue with ICU tokenization that I've covered more here: https://github.com/indexdata/idzebra/issues/24#issuecomment-751260285 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 00:59:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jan 2021 23:59:02 +0000 Subject: [Koha-bugs] [Bug 26707] Split cart and lists button on bibliographic detail pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26707 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch modifies the release notes| |toolbar on bibliographic | |detail pages so that the | |"Add to cart" and "Add to | |lists" buttons are | |separate. The "Add to cart" | |now shows whether the title | |is in the cart. The "Add to | |lists" button is now a menu | |of list choices like it is | |on the search results page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:01:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:01:51 +0000 Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns the same as 'contains' when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- (In reply to Colin Campbell from comment #2) > There is also a question over the rule being used to tokenise phrase > searches and what would be the best default configuration (including no > rule) further investigation is dependent on bug 10729 as phrase and keyword > searching have different requirements in this respect I cover this more at https://github.com/indexdata/idzebra/issues/24#issuecomment-751260285 but yeah the tokenization is definitely the issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:02:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:02:53 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13751, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11158 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:02:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:02:53 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27299 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:02:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:02:53 +0000 Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns the same as 'contains' when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27299 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:03:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:03:01 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10729 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 [Bug 10729] Support phrases-icu.xml in install and upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:03:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:03:01 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27299 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:27:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:27:36 +0000 Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns the same as 'contains' when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158 --- Comment #8 from David Cook --- I hadn't thought of the complete field attribute and truncation... interesting. For what it's worth, without the @attr 6=3, it uses the "w" register: https://software.indexdata.com/zebra/doc/querymodel-zebra.html#querymodel-pqf-apt-mapping-structuretype -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:27:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:27:38 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 --- Comment #14 from David Cook --- Actually, looking at this again, "ti,ext" wouldn't be a "begins with" search. It's a "is exactly" search. So I'm not sure what the problem is here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:28:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:28:51 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from David Cook --- Based on https://github.com/indexdata/idzebra/issues/24#issuecomment-751260285, I think that Adam is confirming that we should not be using tokenization in phrases-icu.xml, but that they're not going to change the default phrases-icu.xml file in Zebra, because they're worried that it would negatively impact users upgrading. So I think at this point we can move forward with my patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:38:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:38:37 +0000 Subject: [Koha-bugs] [Bug 27325] Fix singular/plural forms on the OPAC dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Why not use something like the following instead? Checkouts: [% checkouts.count %] Overdues: [% overdues.count %] Holds: [% holds.count %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:40:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:40:09 +0000 Subject: [Koha-bugs] [Bug 27323] Plugin for Place of Publication 260$a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27323 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 01:41:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 00:41:58 +0000 Subject: [Koha-bugs] [Bug 27320] Add collection code and shelving location options to MARC export tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27320 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:08:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:08:24 +0000 Subject: [Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 --- Comment #12 from David Cook --- Cheers, Lucas. I think that this is looking quite nice. I do have a few suggestions though. 1. I'd change "shibboleth_login" to something more generic like "external_login" (or idp_login or remote_login), so that we can add additional methods more easily in the future. (I think it's a fairly easy change to make for future proofing.) 2. Wrap the word "Shibboleth" in a span with an ID like "shibboleth_name". I like the sound of Bug 27318, but I suspect that rewriting the word Shibboleth with some Javascript would be sufficient for many cases. Alternatively, we replace the existing text with a new default news item that just says "Shibboleth" and maybe includes a generic Shibboleth icon? (As you can tell, I really like how Gitlab does multi provider auth heh.) I agree that Shibboleth is meaningless to most users, and honestly it's actually incorrect for most of my clients, since their actual Identity Provider is not Shibboleth and is instead something like Microsoft ADFS with institutional branding (like "Department of X"). 3. Wrap the Shibboleth text in another border box. (This would be to differentiate it from additional methods added later.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:11:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:11:59 +0000 Subject: [Koha-bugs] [Bug 27318] make shibboleth instructions customizable in the loginModal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I like this idea in theory. As I noted on Bug 25405, I agree that most users aren't going to know what Shibboleth is. Moreover, it's not meaningful, since many Koha libraries don't actually use Shibboleth as an Identity Provider, and we really do want to be referencing the Identity Provider branding at this point (whether it is Google, Facebook, Department of X, et cetera). However, this patch isn't really workable at the moment, since we lose the "shibbolethLoginUrl" variable, which is dynamically defined based on the page you are on at any given time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:12:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:12:12 +0000 Subject: [Koha-bugs] [Bug 27318] make shibboleth instructions customizable in the loginModal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:17:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:17:40 +0000 Subject: [Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 --- Comment #13 from David Cook --- Of course, this actually reminds me of work I want to do for adding identity providers via the staff admin... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:18:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:18:37 +0000 Subject: [Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:19:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:19:57 +0000 Subject: [Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- Ohhh I like the sound of this. This could be an interesting way to add checks for authority linking... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:22:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:22:27 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:22:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:22:58 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 --- Comment #1 from David Cook --- You might want to email the koha-devel listserv about this one too, since someone there might know more about why this is happening. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:27:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:27:59 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #8 from David Cook --- Another idea is to provide a Javascript object that is accessible by Javascript. That could be a more extensible way of getting this functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:30:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:30:29 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- We've implemented an "edit search" feature for years locally. It'll be interesting to see what this one is like... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:31:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:31:08 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:34:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:34:24 +0000 Subject: [Koha-bugs] [Bug 27309] Add plugin hooks for capturing raw passwords (NNPDB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27309 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Could you elaborate more on your use case for this? I don't understand why you'd need to capture and store the password. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 02:40:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 01:40:44 +0000 Subject: [Koha-bugs] [Bug 27312] Add a syspref to redirect patron after self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27312 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- It's an interesting idea. However, what if there are multiple authentication methods provided for a system? For instance, perhaps you have several different identity providers? We've had this scenario on more than one occasion. Perhaps it makes sense to re-direct after self-registration to opac-user.pl and to have your authentication method listed there, and then the user can choose the method that makes sense for them. (This also makes it more generalizable for other Koha libraries.) If you wanted to make it smoother and you only had 1 identity provider, perhaps you could automatically redirect again using some Javascript based on the referer... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 08:39:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 07:39:53 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:06:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:06:02 +0000 Subject: [Koha-bugs] [Bug 27325] Fix singular/plural forms on the OPAC dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27325 --- Comment #2 from Katrin Fischer --- We could, but are we sure that this is nice in every language? I think using the singular/plural feature in such a prominent place would make sense and look good :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:06:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:06:30 +0000 Subject: [Koha-bugs] [Bug 27320] Add collection and shelving location options to MARC export tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add collection code and |Add collection and shelving |shelving location options |location options to MARC |to MARC export tool |export tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:08:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:08:15 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #9 from Katrin Fischer --- (In reply to David Cook from comment #8) > Another idea is to provide a Javascript object that is accessible by > Javascript. > > That could be a more extensible way of getting this functionality. But it would make it harder to tie CSS to it. I think having it in the HTML works well for both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:11:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:11:36 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 --- Comment #15 from Katrin Fischer --- (In reply to David Cook from comment #14) > Actually, looking at this again, "ti,ext" wouldn't be a "begins with" > search. It's a "is exactly" search. > > So I'm not sure what the problem is here... To my knowledge ext hasn't worked with ICU in forever - or at least as long as we have been using Koha with ICU (2009). This is even documented in the manual (https://koha-community.org/manual/20.11/en/html/searching.html?highlight=ext) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:18:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:18:26 +0000 Subject: [Koha-bugs] [Bug 27164] Fix item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:18:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:18:29 +0000 Subject: [Koha-bugs] [Bug 27164] Fix item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114687|0 |1 is obsolete| | --- Comment #16 from Fridolin Somers --- Created attachment 114776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114776&action=edit Bug 27164: Fix item search CSV export In item search CSV export, data cells are exported with double quotes. There should also be double quotes in header cells. Also some spaces can be removed. Delimiter must be from system preference 'delimiter'. TT filter must be $raw not html, only double quotes must be espaped by duplication of it. This may help to open the CSV with any table/calc software. Test plan : 1.0) Create a record with title : Laurel & "Hardy" 1.2) Create an item on this record 2.0) Without patch 2.1) Perform an item search on title 'Laurel' 2.2) Export as a CSV file and save the file locally 2.3) Open the file with a table/calc software 3.0) Apply patch 3.1) Perform same item search 3.2) Export as a CSV file and save the file locally 3.3) Open the file with a table/calc software 4.0) Compare files with diff/meld => you see double quotes arround header cells and removal of space after coma 4.1) Check that delimiter is from system preference 'delimiter' 4.2) In table/calc software they should look the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:19:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:19:30 +0000 Subject: [Koha-bugs] [Bug 27164] Fix item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 --- Comment #17 from Fridolin Somers --- (In reply to Victor Grousset/tuxayo from comment #15) > Hi :) > > Much needed improvements and I get better results by default on LibreOffice. > > The only issue found is about removing the space between title and author. > > Here is an example: > "Laurel & ""Hardy""Hammarberg, Marcus." > without quotes to Hardy, I would get > "Laurel & HardyHammarberg, Marcus." > > Other examples > > 'More fruitful than the soil' :Mackillop, Andrew. > "A Hegel dictionary /Inwood, Michael," > "A tribute to Jack JohnsonDavis, Miles," > > The table HTML view and the detail page of the record insert a space between > title and author. So it seems pretty sure we need to have that here. > Which also means the "by" in UNIMARC case don't need a space before and > after, otherwise the space will be duplicated. Good catch, I see it in my patch indeed. Trival change so I changed the main patch and went to "Signed Off" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:22:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:22:45 +0000 Subject: [Koha-bugs] [Bug 27321] Make excluded database columns in system preferences more clearly disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Oh style inside HTML :/ In my opinion it whould be better into CSS file. With selector : .dbcolumn_selection:disabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:26:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:26:55 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:30:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:30:50 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 --- Comment #2 from Magnus Enger --- I see this problem with Koha 19.11.11, on Debian 9.13. It looks like this affects all our man pages, but I don't think we changed anything in all of them? I suspect the problem is how the man pages are generated from our DocBook files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:37:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:37:26 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:37:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:37:35 +0000 Subject: [Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 09:58:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 08:58:12 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 --- Comment #5 from Fridolin Somers --- I think you need to restart zebra server and indexer after applying patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:37:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 09:37:32 +0000 Subject: [Koha-bugs] [Bug 27315] The man pages for the command line utilities do not display properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- It's coming from the spaces between the start of the line and the XML tags. However I have no idea why this problem appeared recently. I have tried with the example at https://tdg.docbook.org/tdg/5.2/refentry.html and I see the same problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:51:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 09:51:50 +0000 Subject: [Koha-bugs] [Bug 25572] Permissions for Mana Reports are currently linked to Permissions in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25572 --- Comment #7 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #6) > Hi, I have a patron with just the catalogue and create_reports permissions. > I can't create a report from Mana, when clicking on "import" the button > spins infinitely. When refreshing the page, I'm logged out. > When giving the create_subscription permission, it works, the form is filled > with the SQL of the report. > Could I be missing a step? First time using Mana to create a report I think. I followed those steps and it works ok for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:57:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 09:57:31 +0000 Subject: [Koha-bugs] [Bug 27311] Don't pass borrowernumber to check_password plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27311 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- I understand why you remove it from ->store (because in the creation block), but why from set_password? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 10:57:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 09:57:42 +0000 Subject: [Koha-bugs] [Bug 27311] Don't pass borrowernumber to check_password plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27311 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 11:24:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 10:24:13 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #22 from Jonathan Druart --- (In reply to David Cook from comment #20) > (In reply to Jonathan Druart from comment #19) > > (In reply to David Cook from comment #18) > > > (In reply to Jonathan Druart from comment #17) > > > > 2. Should not it be $instance-koha-worker instead, to match what we have in: > > > > debian/scripts/koha-functions.sh: if daemon > > > > --name="$instancename-koha-worker" \ > > > > > > I don't understand the question. What do you mean by "it" in your question? > > > > $instancename-koha-worker vs koha-worker-__DB_NAME__ > > But in what context? Is it just in terms of the following? > > debian/templates/koha-worker at .service:SyslogIdentifier=koha-worker_%i > etc/koha-worker.service:SyslogIdentifier=koha-worker-__DB_NAME__ > > If so, it would be trivial to do "__DB_NAME__-koha-worker" and > "%i_koha-worker" instead, if that's what you mean? Yes, it is what I meant. Do you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 11:39:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 10:39:40 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #235 from Jonathan Druart --- Patches applied correctly for me: % git log --before="2019-04-16" --oneline|head -n1 7e218b81e6 Bug 21953: (follow-up) Fix test count % git checkout -b bug_15565 7e218b81e6 % yes|git bz apply 15565 Bug 15565 - Place multiple holds at once for the same record in OPAC 87979 - Bug 15565: Place multiple holds at once for the same record on staff and OPAC. 87980 - Bug 15565: Use item's biblionumber only on item-level request 87981 - Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off 87982 - Bug 15565: Alert librarian that maximum holds per record is reached 87983 - Bug 15565: Remove use of GetBiblionumberFromItemnumber 87984 - Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC 87985 - Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl 87986 - Bug 15565: Allow up to (and including) maxreserves number of OPAC item levelholds 87987 - Bug 15565: (follow-up) Removed leftover debug code and added missing filters 87988 - Bug 15565: (QA follow-up) Fix some last filters 87989 - Bug 15565: (follow-up) Changes to maximum hold allowed logic 87990 - Bug 15565: (follow-up) Place multiple holds from opac-search.pl 87991 - Bug 15565: (follow-up) fixing typo that breaks placing a hold Applying: Bug 15565: Place multiple holds at once for the same record on staff and OPAC. Applying: Bug 15565: Use item's biblionumber only on item-level request Applying: Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off Applying: Bug 15565: Alert librarian that maximum holds per record is reached Applying: Bug 15565: Remove use of GetBiblionumberFromItemnumber Applying: Bug 15565: Fixed issues preventing any item-level holds being placed in OPAC Applying: Bug 15565: Changed the retrieval of selected hold pickup branch in opac-reserve.pl Applying: Bug 15565: Allow up to (and including) maxreserves number of OPAC item levelholds Applying: Bug 15565: (follow-up) Removed leftover debug code and added missing filters Applying: Bug 15565: (QA follow-up) Fix some last filters Applying: Bug 15565: (follow-up) Changes to maximum hold allowed logic Applying: Bug 15565: (follow-up) Place multiple holds from opac-search.pl Applying: Bug 15565: (follow-up) fixing typo that breaks placing a hold Apply? [(y)es, (n)o, (i)nteractive] % Pushed to a remote branch if needed: https://gitlab.com/joubu/Koha/-/tree/bug_15565 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:17:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 11:17:54 +0000 Subject: [Koha-bugs] [Bug 27034] $c->objects->search shouldn't use path parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27034 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 12:17:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 11:17:58 +0000 Subject: [Koha-bugs] [Bug 27034] $c->objects->search shouldn't use path parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27034 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 114777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114777&action=edit Bug 27034: Do not use path parameters on building the query This patch simply removes the use of path parameters on building the query in $c->objects->search. The sample usage in the original tests considers a specific use case in which the 'nested' resultset has the path param in its attributes: GET /patrons/:patron_id/holds In this case, $c->objects->search would be passed a Koha::Holds resultset into which it would build a query. As the patron_id param can be mapped into a Koha::Hold attribute, this works. We don't actually use this approach in code. What we do is searching for the patron, and properly return a 404 if the patron doesn't exist [1]. If it exists, we actually call $patron->holds to get the related resultset, so there's no gain in having the path param on the query afterwards. That said, if we wanted to build: GET /holds/:hold_id/pickup_locations as the latter is a calculated value, from a resultset that doesn't actually include a (mapped to some attribute) hold_id attribute, there's no way to use it if it will automatically add the hold_id to the pickup_locations resultset. It will give errors about hold_id not being an attribute of Koha::Library (Branches.pm actually). So this patch removes the automatic use of path parameters in $c->objects->search. We can extract them in the controller and add them to the passed resultset if required. But this patch removes a constraint we have for building routes controllers right now. [1] If we didn't return the 404, and we just passed a fresh Koha::Holds resultset to be feeded with the patron_id, we would always return an empty array in cases where the patron doesn't exist. This would be misleading, but I'm open to discuss it. Design-wise. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:30:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 12:30:44 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable --- Comment #9 from Jonathan Druart --- Sending to 20.05 RM queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 13:48:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 12:48:14 +0000 Subject: [Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:00:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:00:27 +0000 Subject: [Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:01:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:01:25 +0000 Subject: [Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 114778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114778&action=edit Bug 23857: Regression tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:01:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:01:28 +0000 Subject: [Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 114779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114779&action=edit Bug 23857: Make adding club holds set the Location header Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:01:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:01:55 +0000 Subject: [Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:06:18 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- There are two other occurrences, should not we fix them as well? koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc: setTimeout('window.close()', 1); koha-tmpl/opac-tmpl/bootstrap/en/includes/slip-print.inc: setTimeout('window.close()', 1); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:06:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:06:38 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24061 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:06:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:06:38 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27282 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:18 +0000 Subject: [Koha-bugs] [Bug 25954] Header search forms should be labeled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:21 +0000 Subject: [Koha-bugs] [Bug 25954] Header search forms should be labeled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 --- Comment #23 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:23 +0000 Subject: [Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:24 +0000 Subject: [Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 --- Comment #13 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:26 +0000 Subject: [Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:28 +0000 Subject: [Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:30 +0000 Subject: [Koha-bugs] [Bug 26996] Elasticsearch: Multiprocess reindexing sometimes doesn't reindex all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26996 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:31 +0000 Subject: [Koha-bugs] [Bug 26996] Elasticsearch: Multiprocess reindexing sometimes doesn't reindex all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26996 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:33 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:35 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:37 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:39 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:41 +0000 Subject: [Koha-bugs] [Bug 27043] Add to number_of_replicas and number_of_shards to index config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:43 +0000 Subject: [Koha-bugs] [Bug 27043] Add to number_of_replicas and number_of_shards to index config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27043 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:44 +0000 Subject: [Koha-bugs] [Bug 27085] Corrections in overdue_notices.pl help text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27085 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:46 +0000 Subject: [Koha-bugs] [Bug 27085] Corrections in overdue_notices.pl help text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27085 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:48 +0000 Subject: [Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:50 +0000 Subject: [Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:51 +0000 Subject: [Koha-bugs] [Bug 27168] Most popular doesn't always sort correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:53 +0000 Subject: [Koha-bugs] [Bug 27168] Most popular doesn't always sort correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27168 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:55 +0000 Subject: [Koha-bugs] [Bug 27178] OPAC results and lists pages contain invalid attributes (xmlns:str="http://exslt.org/strings") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27178 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:57 +0000 Subject: [Koha-bugs] [Bug 27178] OPAC results and lists pages contain invalid attributes (xmlns:str="http://exslt.org/strings") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27178 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:10:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:10:58 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:11:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:11:00 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:20:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:20:03 +0000 Subject: [Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 --- Comment #3 from Tomás Cohen Arazi --- Resubmitting, test instructions missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:20:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:20:06 +0000 Subject: [Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:20:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:20:09 +0000 Subject: [Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:20:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:20:53 +0000 Subject: [Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:20:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:20:56 +0000 Subject: [Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114768|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 114780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114780&action=edit Bug 27276: Prevent borrowers-force-messaging-defaults.pl to crash MySQL 5.7 does not allow queries using 0000-00-00 Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:21:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:21:08 +0000 Subject: [Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 --- Comment #6 from Kyle M Hall --- Created attachment 114781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114781&action=edit Bug 27276:: Fix syntax error Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:22:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:22:20 +0000 Subject: [Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 114782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114782&action=edit Bug 23857: Regression tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:22:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:22:22 +0000 Subject: [Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:22:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:22:24 +0000 Subject: [Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 114783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114783&action=edit Bug 23857: Make adding club holds set the Location header This patch makes the club holds route add the Location header to the response as specified in the API coding guidelines. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/clubs_holds.t => FAIL: Tests don't pass! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:22:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:22:28 +0000 Subject: [Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 114784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114784&action=edit Bug 23857: (QA follow-up) Use Basic auth in tests This patch puts the tests in line with the current codebase. Some bits are passed through perltidy to aid readability... To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/clubs_holds.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! => SUCCESS: Tests look more like the rest of the API tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:29:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:29:01 +0000 Subject: [Koha-bugs] [Bug 27327] New: Indirect object notation in Koha::Club::Hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Bug ID: 27327 Summary: Indirect object notation in Koha::Club::Hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:29:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:29:16 +0000 Subject: [Koha-bugs] [Bug 27327] Indirect object notation in Koha::Club::Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25898 Blocks| |26303 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26303 [Bug 26303] [OMNIBUS] Preparing for Perl 7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:29:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:29:16 +0000 Subject: [Koha-bugs] [Bug 26303] [OMNIBUS] Preparing for Perl 7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26303 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 [Bug 27327] Indirect object notation in Koha::Club::Hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:29:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:29:16 +0000 Subject: [Koha-bugs] [Bug 25898] Prohibit indirect object notation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27327 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:32:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:32:44 +0000 Subject: [Koha-bugs] [Bug 27328] New: Azis Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27328 Bug ID: 27328 Summary: Azis Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: koha-bugs at lists.koha-community.org Reporter: asuhtml12 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114785&action=edit Azis -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:33:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:33:12 +0000 Subject: [Koha-bugs] [Bug 27329] New: Jjj Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27329 Bug ID: 27329 Summary: Jjj Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: feyzavelvina at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114786&action=edit dre4m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:37:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:37:15 +0000 Subject: [Koha-bugs] [Bug 27327] Indirect object notation in Koha::Club::Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 114787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114787&action=edit Bug 27327: Get rid of indirect object notation in Koha::Club::Hold This patch makes the code follow the PERL29 coding guideline. Period. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:38:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:38:02 +0000 Subject: [Koha-bugs] [Bug 27327] Indirect object notation in Koha::Club::Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |agustinmoyano at theke.io, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:42:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:42:29 +0000 Subject: [Koha-bugs] [Bug 25534] Add ability to specifying and store a reason when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #95 from Jonathan Druart --- Created attachment 114788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114788&action=edit Bug 25534: (QA follow-up 2) Add default values for new AV category Fix wrong conflict resolution -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:42:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:42:55 +0000 Subject: [Koha-bugs] [Bug 27330] New: Wrong return status when no enrollments in club holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 Bug ID: 27330 Summary: Wrong return status when no enrollments in club holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com It seems we are expecting a 500 if the club doesn't have any enrollments. A 403 should be returned instead. And it highlights some bad logic in the controller, as it is not catching the narrower exception, but the broader (Exceptions Koha::Club::Hold::add can throw) so some error conditions are being treated wrongly (i.e. bad parameters vs. no enrollments on the club). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:43:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:43:40 +0000 Subject: [Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27327, 19618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 [Bug 19618] Add 'Club Holds' feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 [Bug 27327] Indirect object notation in Koha::Club::Hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:43:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:43:40 +0000 Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 [Bug 27330] Wrong return status when no enrollments in club holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:43:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:43:40 +0000 Subject: [Koha-bugs] [Bug 27327] Indirect object notation in Koha::Club::Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 [Bug 27330] Wrong return status when no enrollments in club holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:43:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:43:44 +0000 Subject: [Koha-bugs] [Bug 27331] New: fr-FR/1-Obligatoire/authorised_values.sql is invalid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 Bug ID: 27331 Summary: fr-FR/1-Obligatoire/authorised_values.sql is invalid Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org ERROR 1064 (42000) at line 724: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '+ +INSERT INTO authorised_values (category, authorised_value, lib) VALUES ('HOLD' at line 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:44:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:44:00 +0000 Subject: [Koha-bugs] [Bug 25534] Add ability to specifying and store a reason when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27331 --- Comment #96 from Jonathan Druart --- (In reply to Jonathan Druart from comment #95) > Created attachment 114788 [details] [review] > Bug 25534: (QA follow-up 2) Add default values for new AV category > > Fix wrong conflict resolution Moved to bug 27331. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:44:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:44:00 +0000 Subject: [Koha-bugs] [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 [Bug 25534] Add ability to specifying and store a reason when cancelling a hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:44:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:44:42 +0000 Subject: [Koha-bugs] [Bug 27328] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27328 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Azis |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:45:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:45:35 +0000 Subject: [Koha-bugs] [Bug 27329] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27329 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Jjj |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:45:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:45:36 +0000 Subject: [Koha-bugs] [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:45:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:45:39 +0000 Subject: [Koha-bugs] [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 --- Comment #1 from Jonathan Druart --- Created attachment 114789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114789&action=edit Bug 27331: (bug 27331 follow-up) Fix syntax error in authorised_values.sql for fr-FR ERROR 1064 (42000) at line 724: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '+ +INSERT INTO authorised_values (category, authorised_value, lib) VALUES ('HOLD' at line 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:45:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:45:46 +0000 Subject: [Koha-bugs] [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:46:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:46:15 +0000 Subject: [Koha-bugs] [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:46:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:46:31 +0000 Subject: [Koha-bugs] [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:53:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:53:35 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #89 from Jonathan Druart --- acqui/addorder.pl is logging a MODIFY_BASKET, is that expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:54:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:54:02 +0000 Subject: [Koha-bugs] [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 --- Comment #2 from Kyle M Hall --- File appears to still be invalid do to unrelated issues: ERROR 1062 (23000) at line 121: Duplicate entry 'COUNTRY-ER' for key 'av_uniq' INSERT INTO `authorised_values` ( `category`, `authorised_value`, `lib`) VALUES ( 'COUNTRY', 'ER', 'Érythrée'); INSERT INTO `authorised_values` ( `category`, `authorised_value`, `lib`) VALUES ( 'COUNTRY', 'ER', 'Allemagne'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:54:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:54:34 +0000 Subject: [Koha-bugs] [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:54:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:54:36 +0000 Subject: [Koha-bugs] [Bug 27332] New: When renewing a serial subscription library from subscripton is not used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27332 Bug ID: 27332 Summary: When renewing a serial subscription library from subscripton is not used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When renewing a serial subscription using the renew button on the serial detail page, the library pull down in the dialog window is set to "-", although a library was set and saved for the subscription before. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:55:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:55:03 +0000 Subject: [Koha-bugs] [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 14:55:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 13:55:08 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #90 from Jonathan Druart --- I squashed the patches for review and found: +++ b/acqui/basketgroup.pl @@ -307,7 +307,8 @@ if ( $op eq "add" ) { my $basketno=$input->param('basketno'); my $basketgroupid=$input->param('basketgroupid'); ModBasket( { basketno => $basketno, - basketgroupid => $basketgroupid } ); + basketgroupid => $basketgroupid, + borrowernumber => $loggedinuser } ); Why are you adding borrowernumber? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 4 15:06:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jan 2021 14:06:28 +0000 Subject: [Koha-bugs] [Bug 25954] Header search forms should be labeled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #24 from Jonathan Druart --- Owen, the following changes is causing t/db_dependent/selenium/administration_tasks.t to fail: diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc index a77b92c6d5..8640c2268e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc @@ -3,18 +3,22 @@

    [% LibraryName | html %]