[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
Cheers, Lucas. I think that this is looking quite nice.

I do have a few suggestions though. 

1. I'd change "shibboleth_login" to something more generic like
"external_login" (or idp_login or remote_login), so that we can add additional
methods more easily in the future. (I think it's a fairly easy change to make
for future proofing.)

2. Wrap the word "Shibboleth" in a span with an ID like "shibboleth_name". I
like the sound of Bug 27318, but I suspect that rewriting the word Shibboleth
with some Javascript would be sufficient for many cases. 

Alternatively, we replace the existing text with a new default news item that
just says "Shibboleth" and maybe includes a generic Shibboleth icon? (As you
can tell, I really like how Gitlab does multi provider auth heh.)

I agree that Shibboleth is meaningless to most users, and honestly it's
actually incorrect for most of my clients, since their actual Identity Provider
is not Shibboleth and is instead something like Microsoft ADFS with
institutional branding (like "Department of X").

3. Wrap the Shibboleth text in another border box. (This would be to
differentiate it from additional methods added later.)

-- 
You are receiving this mail because:
You are watching all bug changes.