[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Joonas Kylmälä from comment #5)
> To further elaborate on the idea when we have 
> 
> Koha::Holds::get_items_that_can_fill 
> 
> then we could have in pendingreserves.pl something like this
> 
> for biblio in biblios_with_holds:
>  holds = biblio->holds
>  items = holds->get_items_that_can_fill
>  callnums = _get_callnumbers(items)
>  itemtypes = _get_itypes(items)
>  first_hold = biblio->first_hold_to_fill
> 
>  push @reservedata, { biblio->biblionumber, first_hold->hold_id, callnums,
> itemtypes .. }

We need to limit the number of queries. Doing that will be linear and will
depend on the number of biblios, I am not sure it's a good idea.

I've attached some tests, I don't think we can do more here.

-- 
You are receiving this mail because:
You are watching all bug changes.