[Koha-bugs] [Bug 27034] $c->objects->search shouldn't use path parameters

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 5 13:44:07 CET 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27034

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #3)
> Patch "Bug 27015: Make pickup locations searchable" is going to add a FIXME
> about this.
> 
> This patch must remove it then.
> 
> +++ b/Koha/REST/V1/Holds.pm
> @@ -445,6 +445,8 @@ sub pickup_locations {
>      my $c = shift->openapi->valid_input or return;
> 
>      my $hold_id = $c->validation->param('hold_id');
> +    # FIXME: We should really skip the path params in $c->objects->search
> +    delete $c->validation->output->{hold_id};

Thanks for taking the time to review at this point!

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list