[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795

--- Comment #21 from Johanna Räisä <johanna.raisa at koha-suomi.fi> ---
(In reply to Tomás Cohen Arazi from comment #20)
> Hi Johanna. Nice and clean work!
> 
> A few remarks from the QA POV:
> - Our API design mojo is: 'As RESTful as we can'. In this context, we should
> consider the 'checkout history of a patron' a resource, and as such it feels
> more appropriate to put the patron id on the path, like in:
> 
> DELETE /patrons/{patron_id}/checkouts/history
> 
> Then we can reserve this route you were using for batch anonymizing :-D like
> in
> 
> DELETE /checkouts/history?q=more_complex_query_on_patrons
> 
> - There are some response definitions missing on the spec, (503 for
> maintenance mode, 500 for internal server error, and so on).
> 
> - Put the tests on a separate subtest please to avoid interference if some
> changes are made to the previous tests/data.

Hi Tomás, now that I'm back in business I will look those things as you
suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.