[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #123 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #117)
> 1. We need a delay between the different AJAX request when filtering the
> table, otherwise we face weird behaviour and lag (server and browser)

I didn't manage to reproduce the problem.

> 2. Prior to this patch, the "pending orders" table contained orders with
> status (orderstatus) set to "ordered" or "partial". Now we see them all.
> See 'pending' and 'ordered' flag of SearchOrders

This got fixed on the corresponding bug.

> 9. There are several places where strings are not escaped

Fixed them all with the follow-up.

> Side notes (and my opinion), I don't think we are going into the right
> direction. The JS code we are adding in our template is not robust, hard to
> read, and so hard to maintain.

I believe we need to pick a JS framework, and start using it. In the meantime,
we should do our best in terms of code reliability and maintainability, as we
do. I'd add, that with the complexity this table has, it will look bad no
matter what. It contains many layers of nested data, that are now (with the API
use) readable, intuitively organized and fully covered by tests. As opposed to
the lengthy and hard to maintain .pl files.

> Also we will have to rewrite things we have done in TT, like display of
> patron's name for instance (patron-title.inc).
> I really would like to see some efforts in improving the readability of the
> code we have already before adding more.

Yeah, I would love the same. There are many good templating tools for using out
there, to pair with the new APIs.

-- 
You are receiving this mail because:
You are watching all bug changes.