[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Victor Grousset/tuxayo from comment #16)
> Created attachment 114735 [details] [review]
> Bug 11983: Centralised Koha::Patrons method OPTION 2
> 
> == Test plan ==
> prove t/db_dependent/Koha/Patrons.t
> 
> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

Couple questions:
1 - It looks like the wording from commet 9 was not done? has->have
issues->checkouts
2 - filter_by_in_lists/filter_by_not_in_lists - for guarantors/guarantees the
in/not-in option is a parameter, couldn't we do the same here?
3 - Where did the list for which functions we are defining come from?
search_patrons_to_update_category could use some of these, but also needs a
'filter_by_age' or similar
4 - Is there a second bug for using these new methods? An example one would be
nice

-- 
You are receiving this mail because:
You are watching all bug changes.