[Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of too_much reserves

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Jonathan,

For me this patch works. I followed a test plan like so:


1 Set an issuing rule's 'Holds allowed (total)'' to a low number (1 or 2);
2 Place more holds than you are allowed and note the error: 'There are no items
that can be placed on hold.'
3. Set the issuing rule 'Holds allowed (total)' to 3 or 4 and set the issuing
rule 'Holds allowed (daily)' to 1. Note the error 'There are no items that can
be placed on hold.'
4. Set the issuning rule 'Holds per record (count)' to 1 then set 'Holds
allowed (total)' and 'Holds allowed (daily)' to a high number.
6. Set the issuing rule 'OPAC item level holds' to allow.
7. Find an record with multiple items attached. Place a hold on 2 of the items
in the record. Note the error 'There are no items that can be placed on hold.'
8. Make sure issuing rule 'OPAC item level holds' to allow and place an item
level hold.
9. Try to place a 2nd hold on that same record. Note the error: 'There are no
items that can be placed on hold.'

Apply patch 
repeat step 1: error message should read: 'This title cannot be requested
because you reached the maximum number of holds.'
repeat step 3: error message should now read: 'his title cannot be requested
because you reached the daily hold limit'.
repeat step 6 and 7: error message should no read 'This title cannot be
requested because you exceeded max holds per record.'
repeat steps 8 and 9: error message should read: 'This title cannot be
requested because you already have hold for this item.'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.