[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115074|0                           |1
        is obsolete|                            |
 Attachment #115075|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 115093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115093&action=edit
Bug 27308: Skip blank lines when inserting new

The intent of the macro insert new function is to add a new field at the
correct numerical place in the record. If you have a blank line while editing,
however, the new line will be inserted at the blank line, rather than checking
the rest of the record.

To test:
1 - Create a macro like
    new 690=‡aLOCAL SUBJECT
2 - Insert a blank line into your record somewhere before where the 690 should
be inserted
3 - Run the macro
4 - Line is inserted before the blank line
5 - Apply patch
6 - Reload (ensure cache is cleared and JS files are reloaded)
7 - Remove the previously created field, but leave the blank
8 - Run the macro
9 - Field is created at correct position

Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Bug 27308: (QA follow-up) Remove commented line

I don't think we need to keep the original line as a comment.. this
patch simply cleans it up.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.