[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jan 13 12:33:12 CET 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #148 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #147)
> Tomas, if you agree with this last patch please reset the status to NSO.

A proper solution should be implemented in Koha::REST::Plugin::Query, in the
merge_q_params and dbic_merge_prefetch helpers. They both have the resultset
object available, so if we added the mapping at Koha::Object level, we could
make the translations there, and thus have a 'global' solution in a fairly easy
way.

To do:

- Add the attribute mapping hash in Koha::Biblio and make it available in
Koha::Biblios too. A sample mapping would be isbn => biblioitem.isbn. It could
be hardcoded (as the table doesn't change, or calculated.

- Add a way for Koha::Biblio(s) to tell 'biblioitem' needs to be prefetch (a
way for a Koha::Object to tell which other tables need to be prefect).

- Make Koha::REST::Plugin::Query::_parse_prefetch add those prefetches using
the above. Note that the 'biblio' name in this case is used because
x-koha-embed calls it 'biblio' but it could (a) not exist, as in /biblios,
where the biblio is top level (b) it could be named in a different way, as
happens to (say) 'biblio.suggestions.suggester' which is a Koha::Patron object,
but it is not called 'patron'.

- Make Koha::REST::Plugin::Query::_parse_dbic_query accumulate the translations
to be done while building the query. Then merge_q_params should call a new
helper that applies those translations to the already created DBIC query
(pretty much a copy and paste of fix_query).

That said, we could move forward with the ugly-but-simple implementation. And
once I'm back I can work on the above, unless someone does it first ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list