[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Signed Off                  |Passed QA

--- Comment #58 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #57)
> I don't think my concerns have been taken into account. QA please have a
> look at bug 24841 comment 4.

I think this fix is okay. Current code for this check exists in the opac
scripts and not the modules. Possibly these checks should be moved to the
modules, but that is a larger refactoring.

ILS-DI behaviour vs REST API behaviour I think are expected to be different.
ILS-DI is unprivileged but meant to act as the OPAC itself (these functions
live in Level 3: Elementary OPAC alternative) and presumes the caller has
sorted out the rights etc.

The REST API is called by a user - that user's privileges decide whether the
action can be completed or not.

Moving the check into CanItemBeReserved means we need to make that function
interface aware and is a bigger change

TL/DR: BlockExpiredOpacActions should affect the opac only, ILS-DI is the OPAC,
REST API is not

-- 
You are receiving this mail because:
You are watching all bug changes.