[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #3 from Thomas Klausner <domm at plix.at> ---
(In reply to Jonathan Druart from comment #1)

> > * Can I actually use BatchStageMarcRecords in BackgroundJob?
> 
> Why not? Did you face a problem?

No, it's working. I just wasn't sure if this code might also need some work,
because it's API feels a bit "old" (exported from C4::ImportBatch, long list of
positional args..)

> > * I see I can pass a batch size to BatchStageMarcRecords. But this will not
> > result in more forking? This is "only" used to fire the progress callback?
> 
> I don't understand the question. Isn't BatchStageMarcRecords used to import
> the record? No fork will be done if you are using Koha::BackgroundJob.

It helps to actually read the code before asking questions. (Well, it also
helps to read it *after* asking..).

I wasn't sure if maybe BatchStageMarcRecords would start a few seperate
processes, passing each a number of elements. But $progress_interval is "just"
used to count the progress and potentially fire the progress_callback. So all
is good :-)

Thanks for the feedback, I will now continue here...

-- 
You are receiving this mail because:
You are watching all bug changes.