[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408

--- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1. Not sure I understand, CanItemBeReserved is called from other C4::Reserves
subroutines where the context is not passed. Why only passing it from direct
calls from controller scripts?

2. 
The following change is not needed:
 sub CanBookBeReserved{
     my ($borrowernumber, $biblionumber, $pickup_branchcode, $params) = @_;
+    my $patron = Koha::Patrons->find( $borrowernumber );
+    my $borrower = $patron->unblessed;

3. Commit messages "(QA follow-up)" are not meaningful. Add more info or
squash.

-- 
You are receiving this mail because:
You are watching all bug changes.