[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Signed Off                  |Failed QA

--- Comment #39 from Nick Clemens <nick at bywatersolutions.com> ---
Hi Alex,

This looks good, that's a long column name :-)
Few things:
1 - We should check the itemtype outside of the loop, I would actually check it
before loading and parsing the pref
2 - You can use effective_itemtype to avoid the conditional, in fact there is a
fetch of that in code above, so you just need to get the object
3 - I am not sure what the behvaiour should be if the itemtype isn't defined or
doesn't match a defined value - just mentioning as it may error when you try to
fetch the object

-- 
You are receiving this mail because:
You are watching all bug changes.