[Koha-bugs] [Bug 27529] New: Cannot place hold on OPAC if hold_fullfillment_policy is set to group and OPACAllowUserToChooseBranch not allowed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27529

            Bug ID: 27529
           Summary: Cannot place hold on OPAC if hold_fullfillment_policy
                    is set to group and  OPACAllowUserToChooseBranch  not
                    allowed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In opac/opac-reserve.pl:
243         # When choosing a specific item, the default pickup library should
be dictated by the default hold policy
244         if ( ! C4::Context->preference("OPACAllowUserToChooseBranch") &&
$itemNum ) {
245             my $item = Koha::Items->find( $itemNum );
246             my $type = $item->effective_itemtype;
247             my $rule = GetBranchItemRule( $patron->branchcode, $type );
248             if ( $rule->{hold_fulfillment_policy} eq 'any' ) {
249                 $branch = $patron->branchcode;
250             } else {
251                 my $policy = $rule->{hold_fulfillment_policy};
252                 $branch = $item->$policy;
253             }   
254         }
255 

$branch = $item->$policy; is problematic for group values


To test:
1 - Set 'Default checkout, hold and return policy' -> 'Hold pickup library
match' to item's hold group or patron's hold group 
2 - Set  OPACAllowUserToChooseBranch to 'Don't allow'
3 - Try to place an item level hold on the opac
4 - Ka-boom
    The method Koha::Item->patrongroup is not covered by tests!
    The method Koha::Item->itemgroup is not covered by tests!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.