[Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029

--- Comment #7 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to PTFS Europe Sandboxes from comment #2)
> Created attachment 115446 [details] [review]
> Bug 25029: Add autorenew_checkouts column to preferences json
> 
> Bug 24476 added autorenew_checkouts as a borrower column, intending it to be
> able to be
> hidden if a library was not using the feature.
> 
> When the column chooser was added, this column was not included.
> 
> To test:
> 1 - Search system preferences for "BorrowerUnwantedFields"
> 2 - Click the box to change the value
> 3 - "autorenew_checkouts" is not an option
> 4 - Confirm that you see the option to opt patron out of autorenewal when
> editing patron on staff side
> 5 - Apply patch and restart everythign
> 6 - Search for the syspref again
> 7 - Note that now you can select "autorenew_checkouts"
> 8 - Check the box and save
> 9 - Confirm the opt out option is no longer visible during patron editing
> 
> Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

I don't know that I agree with this approach.  This patch provides a way to
clean up the mess left behind when a feature is not used.  A straight forward
approach would be to have an option to turn off this feature and have all
related pieces go away.  Instead, we have various options to hide it in
different places.

It doesn't make sense that if a library doesn't want a feature that we have to
go to other controls and hide it.  It should either be on and in use, or off,
and not shown anywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.