[Koha-bugs] [Bug 27554] Wrong test for Koha::Patrons->update_category_to child to adult

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27554

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Nick Clemens from comment #5)
> I see what you thought here, but actually the patron was updated because
> they were too young
> 
> child1 is 4 years old - too young for child account
> 
> The script will move you to the next category without checking the age limits
> for that category - i believe this is how the past script worked too. It is
> not a logical test, but valid
OK but I'm working on adding a check on age limits so it breaks this test.

> 
> child3 is 18 - you make your tests affect this patron instead - maybe we
> want your test in addition to the existing tests?
Yes, in my opinion test should verify which patron is impacted.

But the test also checks that a child looses its guarantor so it must be from
child to adult.

Why not fix the test ?
It would me more clear in case it fails.

-- 
You are receiving this mail because:
You are watching all bug changes.