[Koha-bugs] [Bug 26298] If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 115988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115988&action=edit
Bug 26298: Don't set too_many_items_to_process if equal to limit

In the code we prepare items for display if less than or equal to the pref, but
we don't allow
the edit if greater than or equal to the pref. The second case should be only
'greater than'

To test:
 1- Set MaxItemsToProcessForBatchMod to 1000
 2- Go to Reports
 3- Make a report for itemnumbers that will give you at least 1000 items (ex.
SELECT itemnumber FROM items)
 4- Save and run the report
 5- In "Rows per page", choose 1000
 6- Click on "Batch operations with 1000 visible records" > Batch item
modification
 7- Notice that the item modification form isn't there and that the message
says "Too many items (1000): You are not allowed to edit more than 1000 items
in a batch."
 8- Apply patch
 9- Restart all the things
10- Run the report again and display 1000 rows
11- Click on "Batch operations with 1000 visible records" > Batch item
modification
12 - Sucess!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.