[Koha-bugs] [Bug 23830] Koha::AuthorisedValues should use Koha::Objects::Limit::Library
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Jan 28 21:40:39 CET 2021
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23830
--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 115989
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115989&action=edit
Bug 23830: Make Koha::AuthorisedValues use Koha::Objects::Limit::Library
This patch makes Koha::AuthorisedValues inherit the
'search_with_library_limits' method from Koha::Objects::Limit::Library.
This was left out of the original implementation and this patch makes
this library have a similar implementation to that of Koha::ItemTypes,
etc.
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/AuthorisedValues.t
=> SUCCESS: Tests pass!
2. Apply this patch
3. Notice Koha::AuthorisedValues now inherits this new library
4. Notice the overloaded ->search method is removed
5. Repeat (1)
=> SUCCESS: The behavior of the newly used method on the tests is the
same as before. We only changed the method name and how we pass the
library_id.
6. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list