From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:46:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 02:46:03 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Large patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:46:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 02:46:10 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #114650|0 |1
is obsolete| |
Attachment #114651|0 |1
is obsolete| |
Attachment #114652|0 |1
is obsolete| |
Attachment #114653|0 |1
is obsolete| |
Attachment #114654|0 |1
is obsolete| |
Attachment #114655|0 |1
is obsolete| |
Attachment #114656|0 |1
is obsolete| |
Attachment #114657|0 |1
is obsolete| |
Attachment #114658|0 |1
is obsolete| |
Attachment #114659|0 |1
is obsolete| |
--- Comment #280 from Aleisha Amohia ---
Created attachment 117423
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117423&action=edit
Bug 15516: Database and installer updates
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:46:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 02:46:17 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
--- Comment #281 from Aleisha Amohia ---
Created attachment 117424
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117424&action=edit
Bug 15516: Relevant controller changes and tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:46:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 02:46:24 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
--- Comment #282 from Aleisha Amohia ---
Created attachment 117425
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117425&action=edit
Bug 15516: Allow to reserve first available item from a group of titles
It can be useful, for instance, if a library has the same title from
different publishers (so 1 title but several biblio records) but the
user only wants a copy of the book, regardless of the publisher.
This feature only applies to the staff client.
Test plan:
0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl
1. Go to intranet search, display some results, click on some checkboxes
and click on 'Place hold' button at the top of the results.
2. Search for a patron
3. Check the 'Treat as hold group' checkbox
4. Click on 'Place hold'
5. In the next screen you should see all the holds you placed with the
additional text '(part of a hold group)' in Details column.
6. Click on the "hold group" link. A modal window should appear with
the content of the hold group (a list of holds)
7. Check in an item of one of the reserved biblios and confirm the hold
8. The hold status is changed to Waiting, and all other holds are deleted.
Note: the "hold group" link is displayed in the following pages:
- reserve/request.pl
- circ/circulation.pl
- members/moremember.pl
- circ/pendingreserves.pl
Note: A hold group is counted as only one hold
Sponsored-by: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:46:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 02:46:31 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
--- Comment #283 from Aleisha Amohia ---
Created attachment 117426
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117426&action=edit
Bug 15516: Schema updates
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:49:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 02:49:12 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Change sponsored?|--- |Sponsored
Text to go in the| |This features allows a
release notes| |patron to place a hold on
| |the first available item
| |from a group of titles on
| |the staff interface.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 07:47:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 06:47:55 +0000
Subject: [Koha-bugs] [Bug 27820] New: plugins_nightly.pl script fails with:
Undefined subroutine &main::cronlogaction
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
Bug ID: 27820
Summary: plugins_nightly.pl script fails with: Undefined
subroutine &main::cronlogaction
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Plugin architecture
Assignee: koha-bugs at lists.koha-community.org
Reporter: solaris.smoke at gmail.com
QA Contact: testopia at bugs.koha-community.org
The new plugins_nightly.pl script that was introduced in Koha 20.11.03 doesn't
work - it fails with the following error:
/etc/cron.daily/koha-common:
Undefined subroutine &main::cronlogaction called at
/usr/share/koha/bin/cronjobs/plugins_nightly.pl line 8.
The issue appears to be a missing import - from looking at other files that use
cronlogaction, the following is missing from this file:
use C4::Log;
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 08:32:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 07:32:25 +0000
Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with:
Undefined subroutine &main::cronlogaction
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |25245
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245
[Bug 25245] Add a plugin hook to allow running code on a nightly basis
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 08:32:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 07:32:25 +0000
Subject: [Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on
a nightly basis
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |27820
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
[Bug 27820] plugins_nightly.pl script fails with: Undefined subroutine
&main::cronlogaction
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 08:33:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 07:33:05 +0000
Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with:
Undefined subroutine &main::cronlogaction
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 08:51:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 07:51:11 +0000
Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with:
Undefined subroutine &main::cronlogaction
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
Samir Shah changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |solaris.smoke at gmail.com
--- Comment #1 from Samir Shah ---
Created attachment 117427
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117427&action=edit
Fix missing import in plugins_nightly.pl
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 08:52:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 07:52:17 +0000
Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with:
Undefined subroutine &main::cronlogaction
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
Samir Shah changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
--- Comment #2 from Samir Shah ---
I've added a patch that I think resolves the issue. I'm not familiar enough
with Perl to be able to contribute more (e.g., tests, if required).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 09:26:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 08:26:54 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
search results screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547
--- Comment #20 from Jonathan Druart ---
(In reply to Christopher Brannon from comment #19)
> Jonathan,
> Can the work you've done here be applied to the cart? If so, I could create
> a ticket suggesting that enhancement.
What exactly? I have tested on master and I see the item info for a single hold
and the "multi holds view" if more than 1 is selected.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:11:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:11:29 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
(Elasticsearch)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
--- Comment #96 from Martin Renvoize ---
Comment on attachment 113967
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113967
Bug 22690: Refactor merging of records to improve performance (Elasticsearch)
Review of attachment 113967:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22690&attachment=113967)
-----------------------------------------------------------------
::: Koha/Item.pm
@@ +1082,5 @@
> +
> +$params:
> + skip_record_index => 1|0
> +
> +Returns undef if the move failed or the biblionumber of the destination record otherwise
I wonder if this might be nicer as a fluent interface (i.e returning $self so
it can be chained.. the undef return would become a no-op and the final return
would be the updated Koha::Item object?)
One for later perhaps
::: Koha/Schema/Result/Item.pm
@@ +778,4 @@
> '+exclude_from_local_holds_priority' => { is_boolean => 1 },
> );
>
> +# Relationship with orders via the aqorders_item table that not have foreign keys
Was there a reason not to add the foreign key and let dbic generate the
relationship?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:14:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:14:04 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
(Elasticsearch)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
--- Comment #97 from Martin Renvoize ---
(In reply to Ere Maijala from comment #95)
> (In reply to Jonathan Druart from comment #94)
> > So the problem is actually that the reindex is not async.
> > Bug 27344 is trying to provide a solution for that.
>
> That's part of it, but I believe the refactoring improves the flow and
> readability of the code as well.
I think I agree, the code flow is clearer with this work.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:18:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:18:19 +0000
Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in
value_builder/unimarc_field_4XX.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537
--- Comment #7 from Fridolin Somers ---
- $to = $from + $resultsperpage ;
+ $to = $startfrom * $resultsperpage + $resultsperpage ;
I dont understand this change.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:27:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:27:32 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
(Elasticsearch)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
--- Comment #98 from Martin Renvoize ---
Comment on attachment 113967
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113967
Bug 22690: Refactor merging of records to improve performance (Elasticsearch)
Review of attachment 113967:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22690&attachment=113967)
-----------------------------------------------------------------
::: Koha/Item.pm
@@ +1064,5 @@
> +sub item_orders {
> + my ( $self ) = @_;
> +
> + my $orders = $self->_result->item_orders;
> + return Koha::Acquisition::Orders->_new_from_dbic($orders);
In it's current form, this can result in failure.. I'm not seeing any handling
for that...
i.e. if an item is deleted it gets moved to deleted_items but the itemnumber
remains in the aqorder_items table as there is no foreign key constraint.. have
you tested this case?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:31:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:31:28 +0000
Subject: [Koha-bugs] [Bug 27597] Searching "kw:term" does not work with
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27597
--- Comment #7 from Fridolin Somers ---
# Remove unquoted colons that have whitespace on either side of them
- $term =~ s/(:+)(\s+)$lookahead/$2/g;
+ $term =~ s/(:+)(\s+)$lookahead//g;
$term =~ s/(\s+)(:+)$lookahead/$1/g;
Could you explain this change please ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:33:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:33:32 +0000
Subject: [Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to
Update During Upgrade
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117180|0 |1
is obsolete| |
Attachment #117181|0 |1
is obsolete| |
--- Comment #23 from Jonathan Druart ---
Created attachment 117428
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117428&action=edit
Bug 26997: CAST AS CHAR to prevent the error
To prevent the DBMS to fail on 0000-00-00 we can cast it as a char and
compare.
This patch also moves to a subroutine, in case we need to adjust (or
reuse) it later.
Signed-off-by: Martin Renvoize
Signed-off-by: Jonathan Druart
Bug 26997: (QA follow-up) Fix Typo
Feel free to squash this ;)
Signed-off-by: Martin Renvoize
Signed-off-by: Jonathan Druart
JD Amended patch - remove changes prior to 3.20
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:42:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:42:40 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
(Elasticsearch)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
--- Comment #99 from Martin Renvoize ---
Comment on attachment 113967
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113967
Bug 22690: Refactor merging of records to improve performance (Elasticsearch)
Review of attachment 113967:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22690&attachment=113967)
-----------------------------------------------------------------
::: Koha/Item.pm
@@ +1102,5 @@
> + biblioitemnumber => $to_biblio->biblioitem->biblioitemnumber
> + })->store({ skip_record_index => $params->{skip_record_index} });
> +
> + # Acquisition orders
> + $self->item_orders->update({ biblionumber => $biblionumber }, { no_triggers => 1 });
no_triggers: Varified this one is OK.. we don't have any code level triggers
based on biblionumber that I can see.. happy with this and understand why your
using it.
@@ +1105,5 @@
> + # Acquisition orders
> + $self->item_orders->update({ biblionumber => $biblionumber }, { no_triggers => 1 });
> +
> + # Holds
> + $self->holds->update({ biblionumber => $biblionumber }, { no_triggers => 1 });
I don't see any code level triggers at all for Koha::Hold or Koha::Holds.. as
such I don't think we should call 'no_triggers' here..
Without a local ->store method in Koha::Hold, or a local ->update method in
Koha::Holds the result of calling Koha::Objects->update should be the same as
without no_triggers passed. As such, I feel for future-proofing we should not
pass no_triggers as we don't currently know that our biblionumber change here
wouldn't be part of a trigger in the future.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:45:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:45:18 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #14 from Jonathan Druart ---
Don't we need a DBrev to adjust items.onloan?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:48:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:48:03 +0000
Subject: [Koha-bugs] [Bug 27432] Add report run to action logs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432
--- Comment #13 from Fridolin Somers ---
(In reply to Katrin Fischer from comment #12)
> I feel something is out of order here - patches don't apply in the current
> sequence.
>
> Apply? [(y)es, (n)o, (i)nteractive] y
> Applying: Bug 27432: (follow-up) Correct grammar of preference description
> error: sha1 information is lacking or useless
> (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref).
> error: could not build fake ancestor
> Patch failed at 0001 Bug 27432: (follow-up) Correct grammar of preference
> description
> The copy of the patch that failed is found in: .git/rebase-apply/patch
> When you have resolved this problem run "git bz apply --continue".
> If you would prefer to skip this patch, instead run "git bz apply --skip".
> To restore the original branch and stop patching run "git bz apply --abort".
> Patch left in
> /tmp/Bug-27432-follow-up-Correct-grammar-of-preference--qT_FEt.patch
Ah indeed, patch :
Bug 27432: (follow-up) Correct grammar of preference description
Is from 17:45 and other patches are from 17:54.
I think this patch must be moved after main patch :
Bug 27432: Add report run to action logs
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:49:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:49:39 +0000
Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with:
Undefined subroutine &main::cronlogaction
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #3 from Fridolin Somers ---
Good catch, I set status to need signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:51:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:51:09 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
(Elasticsearch)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #100 from Martin Renvoize ---
Failing QA to get some attention.. I don't think anything is major here.. it's
more that I want to get verification that things have been considered and taken
care of.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:54:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:54:28 +0000
Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Attachment #114943|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:56:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:56:04 +0000
Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=24997
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:56:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 09:56:04 +0000
Subject: [Koha-bugs] [Bug 24997] Test to ensure mappings.yaml is in the
correct order
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24997
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=27316
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:00:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:00:06 +0000
Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #115938|0 |1
is obsolete| |
--- Comment #17 from Martin Renvoize ---
Created attachment 117429
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117429&action=edit
Bug 27316: Convert 'undef' for sort to Yes and use Yes/No instead of 0/1
This patch changes the interface to remove the undef option
We also update existing mappings and set default of 1
Comment previously indicated undef was treated differently, but in the code we
treat undef as 1
That code is untoched to avoid creating problems for older mappings that may be
reloaded
To test:
1 - View the ES mappings, note you can set columns to Undef, 0, 1
2 - Set some to undef
3 - Apply patches
4 - Update database
5 - Undef now show as 'Yes'
6 - Confirm you can set columns as Yes/no
7 - Confirm that mandatory columns display correct value when readonly (see
issues field)
Signed-off-by: Fridolin Somers
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:00:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:00:10 +0000
Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #115939|0 |1
is obsolete| |
--- Comment #18 from Martin Renvoize ---
Created attachment 117430
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117430&action=edit
Bug 27316: (follow-up) Default to 1 if undef in mappings
Signed-off-by: Fridolin Somers
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:00:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:00:48 +0000
Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #19 from Martin Renvoize ---
Works nicely and is much cleaner/clearer. No regressions found.. Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:06:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:06:27 +0000
Subject: [Koha-bugs] [Bug 27795] Misalignment of TOTAL value in lateorders
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117331|0 |1
is obsolete| |
--- Comment #2 from Martin Renvoize ---
Created attachment 117431
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117431&action=edit
Bug 27795: Misalignment of TOTAL value in lateorders page
This patch corrects the colspan in the footer of the late orders page.
It also adds a quantity total cell to the footer and changes the
container of the buttons at the bottom of the page from a tag to
the standard
.
To test, apply the patch and go to Acquisitions -> Late orders.
In the footer of the late orders page, there should be a total under the
"Quantity" column. The total cost number should be correctly aligned
under the "total cost" header cell.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:06:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:06:54 +0000
Subject: [Koha-bugs] [Bug 27795] Misalignment of TOTAL value in lateorders
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Needs Signoff |Signed Off
--- Comment #3 from Martin Renvoize ---
Looks good, signing off.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:11:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:11:54 +0000
Subject: [Koha-bugs] [Bug 27161] Base.pm complains about unitialized value
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #8 from Martin Renvoize ---
I'm wondering if we ought to instead define a default..
i.e.
my $metadata = $self->{metadata};
vs
my $metadata = $self->{metadata} // {};
?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:12:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:12:46 +0000
Subject: [Koha-bugs] [Bug 27821] New: sanitize_zero_date does not handle
datetime
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821
Bug ID: 27821
Summary: sanitize_zero_date does not handle datetime
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: major
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart at bugs.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
Only datatype "date" is handled correctly.
Atomic update generated errors: main::sanitize_zero_date(): DBI Exception:
DBD::mysql::db do failed: Truncated incorrect CHAR(10) value: '2021-03-01
09:43:56' [for Statement "
UPDATE old_issues
SET returndate = NULL
WHERE CAST(returndate AS CHAR(10)) = '0000-00-00';
"] at (eval 1481) line 5
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:14:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:14:02 +0000
Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andrew at bywatersolutions.com
| |,
| |fridolin.somers at biblibre.co
| |m, victor at tuxayo.net
Depends on| |26997
--- Comment #1 from Jonathan Druart ---
RMaints, keep an eye on this one, you may need to backport it quickly.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997
[Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:14:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:14:02 +0000
Subject: [Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to
Update During Upgrade
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |27821
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821
[Bug 27821] sanitize_zero_date does not handle datetime
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:14:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:14:54 +0000
Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:14:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:14:57 +0000
Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821
--- Comment #2 from Jonathan Druart ---
Created attachment 117432
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117432&action=edit
Bug 27821: Make sanitize_zero_date support datetime and timestamp
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:15:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:15:08 +0000
Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:15:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:15:15 +0000
Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:15:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:15:58 +0000
Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a
non-existing date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |27821
--- Comment #26 from Jonathan Druart ---
I wrote bug 27821, otherwise the cast on old_issues.returndate didn't work.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821
[Bug 27821] sanitize_zero_date does not handle datetime
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:15:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:15:58 +0000
Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |7806
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806
[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:20:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:20:17 +0000
Subject: [Koha-bugs] [Bug 27718] Holds to Pull list doesn't respect
holdallowed circulation rule anymore
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27718
--- Comment #19 from Jonathan Druart ---
Thanks Andrew for the follow-up!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:26:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:26:22 +0000
Subject: [Koha-bugs] [Bug 27798] Independent branches should have a warning
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27798
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117363|0 |1
is obsolete| |
--- Comment #5 from Jonathan Druart ---
Created attachment 117433
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117433&action=edit
Bug 27798: Add warning to IndependentBranches system preference
Test Plan:
1) Apply this patch
2) Search system preferences for IndependentBranches
3) Note the warning about changing the setting on a production system
Signed-off-by: David Nind
Signed-off-by: Marcel de Rooy
JD Amended patch:
* Fix commit title
* Don't split the syspref's description, otherwise the sentence will be
split in the POs
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:28:40 +0000
Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a
non-existing date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |21.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:28:42 +0000
Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a
non-existing date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806
--- Comment #27 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:28:45 +0000
Subject: [Koha-bugs] [Bug 25777] Datatables on z3950_search.pl show
incorrect number of entries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |21.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:28:47 +0000
Subject: [Koha-bugs] [Bug 25777] Datatables on z3950_search.pl show
incorrect number of entries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777
--- Comment #24 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:28:49 +0000
Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for
background_jobs_worker
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |21.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:28:51 +0000
Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for
background_jobs_worker
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363
--- Comment #31 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:28:53 +0000
Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |21.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:28:56 +0000
Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457
--- Comment #38 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:28:58 +0000
Subject: [Koha-bugs] [Bug 27071] Hold pickup library match not enforced
correctly on intranet when using hold groups
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |21.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:00 +0000
Subject: [Koha-bugs] [Bug 27071] Hold pickup library match not enforced
correctly on intranet when using hold groups
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071
--- Comment #37 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:03 +0000
Subject: [Koha-bugs] [Bug 27578] Searchid not initialized when adding a new
record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27578
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |21.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:05 +0000
Subject: [Koha-bugs] [Bug 27578] Searchid not initialized when adding a new
record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27578
--- Comment #4 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:07 +0000
Subject: [Koha-bugs] [Bug 27718] Holds to Pull list doesn't respect
holdallowed circulation rule anymore
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27718
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |21.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:09 +0000
Subject: [Koha-bugs] [Bug 27718] Holds to Pull list doesn't respect
holdallowed circulation rule anymore
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27718
--- Comment #20 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:11 +0000
Subject: [Koha-bugs] [Bug 27754] Correct eslint errors in basket.js
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27754
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |21.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:13 +0000
Subject: [Koha-bugs] [Bug 27754] Correct eslint errors in basket.js
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27754
--- Comment #6 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:15 +0000
Subject: [Koha-bugs] [Bug 27798] Independent branches should have a warning
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27798
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |21.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:17 +0000
Subject: [Koha-bugs] [Bug 27798] Independent branches should have a warning
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27798
--- Comment #6 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:19 +0000
Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |21.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:21 +0000
Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821
--- Comment #3 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:34 +0000
Subject: [Koha-bugs] [Bug 8426] Diacritics not being mapped for searching
(Non-ICU)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #10783|0 |1
is obsolete| |
--- Comment #13 from Martin Renvoize ---
Created attachment 117434
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117434&action=edit
Bug 8426 - Diacritics not being mapped for searching
Add mappings for ︡a to a, and for t︠ to t.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:29:46 +0000
Subject: [Koha-bugs] [Bug 8426] Diacritics not being mapped for searching
(Non-ICU)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:31:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:31:45 +0000
Subject: [Koha-bugs] [Bug 27597] Searching "kw:term" does not work with
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27597
--- Comment #8 from Jonathan Druart ---
(In reply to Fridolin Somers from comment #7)
> # Remove unquoted colons that have whitespace on either side of them
> - $term =~ s/(:+)(\s+)$lookahead/$2/g;
> + $term =~ s/(:+)(\s+)$lookahead//g;
> $term =~ s/(\s+)(:+)$lookahead/$1/g;
>
> Could you explain this change please ?
Look at the unit tests, it removes extra spaces.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:45:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:45:18 +0000
Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with:
Undefined subroutine &main::cronlogaction
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
--- Comment #4 from Fridolin Somers ---
Created attachment 117435
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117435&action=edit
Bug 27820: fix missing import in plugins_nightly.pl
Signed-off-by: Fridolin Somers
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:45:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:45:31 +0000
Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with:
Undefined subroutine &main::cronlogaction
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
--- Comment #5 from Fridolin Somers ---
Created attachment 117436
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117436&action=edit
Bug 27820: add all missing use in misc/cronjobs/plugins_nightly.pl
Koha::Plugins and C4::Context where missing.
Try::Tiny was missing for try/catch.
Test plan :
1) Use a plugin using hook 'cronjob_nightly'
2) Run script : misc/cronjobs/plugins_nightly.pl
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:54:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:54:02 +0000
Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script missing use
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|plugins_nightly.pl script |plugins_nightly.pl script
|fails with: Undefined |missing use
|subroutine |
|&main::cronlogaction |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:55:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:55:06 +0000
Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script missing use
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
--- Comment #6 from Fridolin Somers ---
Piouf nearly all use where missing :D
In order to test, I've added a pull request on KitchenSink Koha plugin :
https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/pull/15
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:55:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 10:55:39 +0000
Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script missing use
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117427|0 |1
is obsolete| |
--- Comment #7 from Fridolin Somers ---
Comment on attachment 117427
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117427
Fix missing import in plugins_nightly.pl
I've signed first patch and created a second one that needs signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 12:18:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 11:18:59 +0000
Subject: [Koha-bugs] [Bug 27267] Create more efficient daemon for indexing
Zebra
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #114884|0 |1
is obsolete| |
--- Comment #9 from Martin Renvoize ---
Created attachment 117437
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117437&action=edit
Bug 27267: Add memory efficient Zebra indexing daemon
This patch adds an alternate Zebra indexing daemon which
is much more memory efficient than the current default daemon.
(For instance, zebra_indexer.pl uses 6MB of RAM vs rebuild_zebra.pl
which uses about 180MB of RAM out of the box while idle.)
To test:
0. Apply patch
1. koha-indexer --stop kohadev
2. vi /etc/default/koha-common
3. Update ALTERNATE_INDEXER_DAEMON to be
"/kohadevbox/koha/misc/zebra_indexer.pl"
4. koha-indexer --start kohadev
5. Go to
http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29
6. Change 245$a to "Gone" instead of "Gairm" and save the record
7. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=Gairm
8. Repeat Step 7 for 5+ seconds until your search returns no results
9. Go to
http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29
10. Change 245$a from "Gone" to "Gairm"
11. Repeat Step 7 for 5+ seconds until your search redirects you to
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29&found1=1
To confirm lower memory usage:
12. ps -efww | grep "zebra_indexer"
13. top -p
14. The top tool should show about 6.1MB usage.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 12:20:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 11:20:37 +0000
Subject: [Koha-bugs] [Bug 27267] Create more efficient daemon for indexing
Zebra
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #10 from Martin Renvoize ---
This works well and is a nice clean implementation.
There is one minor QA script failure.. you open 'my $child_in' in the open3
call, but never actually use it... this causes some noise in our QA script
understandably but I'm not sure it's a real issue in reality.
Signing off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 12:23:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 11:23:35 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
--- Comment #15 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #14)
> Don't we need a DBrev to adjust items.onloan?
Totally agree!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:18:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:18:20 +0000
Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on
multiple columns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org,
| |tomascohen at gmail.com
Keywords| |rel_21_05_candidate
Severity|enhancement |normal
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:19:20 +0000
Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering
on multi-data-field columns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:19:25 +0000
Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering
on multi-data-field columns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117389|0 |1
is obsolete| |
Attachment #117390|0 |1
is obsolete| |
Attachment #117391|0 |1
is obsolete| |
Attachment #117392|0 |1
is obsolete| |
Attachment #117393|0 |1
is obsolete| |
Attachment #117394|0 |1
is obsolete| |
--- Comment #37 from Jonathan Druart ---
Created attachment 117438
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117438&action=edit
Bug 27680: Take first order column for ordering
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:19:29 +0000
Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering
on multi-data-field columns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680
--- Comment #38 from Jonathan Druart ---
Created attachment 117439
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117439&action=edit
Bug 27680: Add support for sorting fields with multiple data points
This patch adds proper handling for sorting a single column that is
constructed of multiple data entities.. i.e `"data": "string1:string2"`
It does NOT add support for filtering on multiple columns yet.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:19:33 +0000
Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering
on multi-data-field columns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680
--- Comment #39 from Jonathan Druart ---
Created attachment 117440
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117440&action=edit
Bug 27680: Add tests for various ways of passing multi-params
This patch adds unit test to increase the coverage of parameter that
accept multiple values. There are a number of different ways end users
can send such parameters and we should test to ensure we are recieving
the correct option.
Options
`?param1=this¶m1=that` - traditional multiple pass params
`?param1[]=this¶m1[]=that` - php multiple pass params
`?param1=this,that` - comma delimited list param
`?param1=this|that` - pipe delimited list param
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:19:37 +0000
Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering
on multi-data-field columns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680
--- Comment #40 from Jonathan Druart ---
Created attachment 117441
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117441&action=edit
Bug 27680: Allow traditional multi-params to work
This patch allows the preceeding test to pass. Strictly, we want a comma
delimited string for our _order_by parameter, but we cannot easily block
a traditional multi-passed parameter. As such the 'nice' thing to do is
handle it when such a thing is passed as it will pass through validation
regardless.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:19:40 +0000
Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering
on multi-data-field columns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680
--- Comment #41 from Jonathan Druart ---
Created attachment 117442
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117442&action=edit
Bug 27680: Add support for param[] syntax
While not that common nowadays, it is the syntax PHP uses, and
DataTables also generates such thing in 'traditional' mode. We should
support it as well.
This patch adds support for that. It does so by adding _order_by[] to
the reserved param names, and proper handling on the dbic_merge_sorting
helper.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3- Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Bug 27680: (QA follow-up) Minor perlcritic issue
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:35:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:35:44 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:35:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:35:47 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
--- Comment #16 from Jonathan Druart ---
Created attachment 117443
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117443&action=edit
Bug 27808: DB changes - adjust items.onloan when needed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:38:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:38:46 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |ASSIGNED
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:39:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:39:20 +0000
Subject: [Koha-bugs] [Bug 27815] "Remove" in point of sale untranslatable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:39:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:39:23 +0000
Subject: [Koha-bugs] [Bug 27815] "Remove" in point of sale untranslatable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815
--- Comment #1 from Owen Leonard ---
Created attachment 117444
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117444&action=edit
Bug 27815: "Remove" in point of sale untranslatable
This patch modifies the Point of Sale template so that the "Remove"
button can be translated. The string in the JavaScript block wasn't
wrapped in the correct function.
To test, apply the patch and test that the correct strings are
translatable. In this example I'm testing fr-FR:
- Update a translation:
> cd misc/translator
> perl translate update fr-FR
- Open the corresponding .po file for the strings pulled from
the template: e.g. misc/translator/po/fr-FR-staff-prog.po
- Locate strings pulled from pos/pay.tt for translation to confirm the
update, e.g.:
#: koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt:189
#, c-format
msgid "Remove"
msgstr "Enlever"
- Install the updated translation:
> perl translate install fr-FR
- In the staff client, go to Point of Sale.
- Switch to the French translation and click the "Ajouter" button next
to one of the items for purchase.
- In the "This sale" table, the item you added should have a
corresponding "Enlever" button.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:49:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:49:10 +0000
Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:49:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:49:17 +0000
Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:53:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:53:18 +0000
Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved
should check 'On shelf holds allowed' policy
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|25408 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408
[Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds"
policy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:53:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:53:18 +0000
Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved
should check "opacitemholds" policy
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408
Arthur Suzuki changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|20985 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
[Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf
holds allowed' policy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:55:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:55:24 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:55:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:55:27 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117400|0 |1
is obsolete| |
Attachment #117443|0 |1
is obsolete| |
--- Comment #17 from Kyle M Hall ---
Created attachment 117445
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117445&action=edit
Bug 27808: Refresh the item object when AddReturn is called
This patch changes the original implementation so the item object is
refreshed altogether instead of explicitly pinpointing a specific field
we identified an edge case can leave out from ->store. I propose this
alterate implementation because what this bug highlights is the fact we
don't code thinking calls to things can have side-effects (like this
case, with AddReturn updating the onloan status (and maybe other
things?).
To test:
1. Make sure circ tests pass with and without this patch
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:55:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 12:55:43 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
--- Comment #18 from Kyle M Hall ---
Created attachment 117446
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117446&action=edit
Bug 27808: DB changes - adjust items.onloan when needed
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:10:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:10:14 +0000
Subject: [Koha-bugs] [Bug 27048] Add timestamps to verbose output of
rebuild_zebra.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #13 from Jonathan Druart ---
60 seconds:
exporting authority 13:06:38 [1:0]
61 seconds:
exporting authority 13:05:30 [1:1]
54321 seconds:
exporting authority 13:07:06 [15:5:21]
It's not displayed as a duration and it's confusing IMO. It should at least
display the HH, MM and SS parts on 2 digits.
Why not "15 hours, 5 minutes, 21 seconds" instead? Or "15h 5m 21s"?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:11:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:11:27 +0000
Subject: [Koha-bugs] [Bug 27473] Improve link text in the installer
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|String patch |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:11:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:11:30 +0000
Subject: [Koha-bugs] [Bug 27473] Improve link text in the installer
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473
--- Comment #13 from Owen Leonard ---
Created attachment 117447
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117447&action=edit
Bug 27473: (follow-up) Remove the redirect message
I don't think it's necessary to remove the redirect because I don't
think it does any harm, but why include a message about it? I think we
should treat this step like all the others and provide a button to take
the user to the next page.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:16:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:16:53 +0000
Subject: [Koha-bugs] [Bug 27473] Improve link text in the installer
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473
--- Comment #14 from Jonathan Druart ---
Created attachment 117448
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117448&action=edit
Bug 27473: Remove the redirect after 10sec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:17:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:17:43 +0000
Subject: [Koha-bugs] [Bug 27473] Improve link text in the installer
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #15 from Jonathan Druart ---
Then going a bit further and removing the redirect. Katrin, Martin, would you
agree?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:20:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:20:48 +0000
Subject: [Koha-bugs] [Bug 27822] New: Wrong systempreference for
AddressFormat in 20.11
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822
Bug ID: 27822
Summary: Wrong systempreference for AddressFormat in 20.11
Change sponsored?: ---
Product: Koha
Version: 20.11
Hardware: All
OS: Linux
Status: NEW
Severity: minor
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs at lists.koha-community.org
Reporter: verolencinas at yahoo.com.ar
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Koha 20.11 has as default "AddressFormat" systempreference "US". If you want to
create a new user, you get the error "Template process failed: file error -
member-main-address-style-US: not found at /usr/share/koha/lib/C4/Templates.pm
line 122" because the system expects "us", not "US".
Changing the systempreference solves the problem.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:36:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:36:04 +0000
Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks
our REST API routes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19735
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:36:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:36:04 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=26893
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:36:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:36:23 +0000
Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks
our REST API routes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=17092
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:36:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:36:23 +0000
Subject: [Koha-bugs] [Bug 17092] Generate debian/control with version
numbers from cpanfile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17092
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=26893
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:43:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:43:22 +0000
Subject: [Koha-bugs] [Bug 27048] Add timestamps to verbose output of
rebuild_zebra.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048
--- Comment #14 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #13)
> 60 seconds:
> exporting authority 13:06:38 [1:0]
> 61 seconds:
> exporting authority 13:05:30 [1:1]
> 54321 seconds:
> exporting authority 13:07:06 [15:5:21]
>
> It's not displayed as a duration and it's confusing IMO. It should at least
> display the HH, MM and SS parts on 2 digits.
> Why not "15 hours, 5 minutes, 21 seconds" instead? Or "15h 5m 21s"?
Hm, you are right. I guess my test db was too small, so the big numbers didn't
make me suspicious. I think the second format you suggest would be better.
Or:
Duration: 00:00:02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:44:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:44:08 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=17092
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:44:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:44:08 +0000
Subject: [Koha-bugs] [Bug 17092] Generate debian/control with version
numbers from cpanfile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17092
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19735
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:49:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:49:41 +0000
Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash
register
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #116771|0 |1
is obsolete| |
--- Comment #23 from Martin Renvoize ---
Created attachment 117449
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117449&action=edit
Bug 26273: Add historic cashups table to register page
This patch adds a historic cashups table to the bottom of the register
transaction details page. It will only display if one or more cashups
have taken place and contains links to allow display of the summary
detail modal for each cashup.
Test plan
1/ Enable UseCashRegisters
2/ Undertake a few transactions and cashups
3/ View the 'Register details' page
4/ Note the appearance of a 'Cashup history' section at the bottom of
the page
5/ Note that 'Summary' button displays the relevant modal
6/ Signoff
Signed-off-by: Sally
Signed-off-by: Daniel Jones
Signed-off-by: Sally
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:49:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:49:44 +0000
Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash
register
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #116772|0 |1
is obsolete| |
--- Comment #24 from Martin Renvoize ---
Created attachment 117450
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117450&action=edit
Bug 26273: (follow-up) Format dates and money correctly.
This patch adds the missing formatting for the Datetime and Amount
fields.
Test plan
1/ Apply patch and reload register page to re-display the cashups table
2/ Note that the 'Date' field now displays a nicely formatted date
without an offset.
3/ Note that the 'Amount' field now displays the number according to
your money formatting preferences (with 2 decimal places in most cases)
4/ Signoff
Signed-off-by: Sally
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:49:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:49:47 +0000
Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash
register
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #116773|0 |1
is obsolete| |
--- Comment #25 from Martin Renvoize ---
Created attachment 117451
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117451&action=edit
Bug 26273: (follow-up) Add 'Cashier' to the cashups table
This patch adds the 'Cashier' field as discussed on the bug report.
Test plan
1/ Apply patch and reload the register page to refresh the table
2/ Note that a 'Cashier' field now appears in the table
3/ Sorting and searching on 'Cashier' should work as expected
4/ Default sorting should remain as 'Date' order.
5/ Signoff
Signed-off-by: Sally
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:50:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:50:03 +0000
Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash
register
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:50:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 13:50:33 +0000
Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash
register
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273
--- Comment #26 from Martin Renvoize ---
Rebased against the now PQA dependency bug and set status back to SO
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:01:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:01:18 +0000
Subject: [Koha-bugs] [Bug 27048] Add timestamps to verbose output of
rebuild_zebra.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048
--- Comment #15 from Martin Renvoize ---
Created attachment 117452
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117452&action=edit
Bug 27048: (follow-up) Correction to elapsed printing
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:01:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:01:50 +0000
Subject: [Koha-bugs] [Bug 27048] Add timestamps to verbose output of
rebuild_zebra.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048
--- Comment #16 from Martin Renvoize ---
Fix the duration printing to take the form [00:00:07]
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:04:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:04:03 +0000
Subject: [Koha-bugs] [Bug 27473] Improve link text in the installer
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473
--- Comment #16 from Martin Renvoize ---
Seems reasonable to me :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:07:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:07:05 +0000
Subject: [Koha-bugs] [Bug 27682] Add a floating table header for Search
engine configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Status|Passed QA |Failed QA
--- Comment #4 from Jonathan Druart ---
1. There is a weird behaviour, when you hit land on the page the floating
header is wider than the thead.
However if you go to the bibliographic or authorities tab and come back, it's
ok.
2.
tableInit( "", "search_fields");
In tableInit we should test if oldtabid is passed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:16:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:16:46 +0000
Subject: [Koha-bugs] [Bug 27048] Add timestamps to verbose output of
rebuild_zebra.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048
--- Comment #17 from Jonathan Druart ---
Martin, don't you think we should add a "elapsed" or "duration" to explain what
it is?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:20:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:20:36 +0000
Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem
value is not "placing an order"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708
Peter Vashchuk changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:20:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:20:39 +0000
Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem
value is not "placing an order"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708
--- Comment #1 from Peter Vashchuk ---
Created attachment 117453
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117453&action=edit
Bug 27708: unify two item object creation blocks to be stored as hash
Previously for existing item data was stored as an object and
then treated as one, but in the former item data was stored as
hash keys in the same variable so later it was treated like an object,
hence why it crashed. This patch unifies that variable in both cases
filled as hash and treated as such.
To reproduce:
1) Go to "Administration->System preferences" and change
"AcqCreateItem" to "receiving an order."
2) Now, go to "Acquisitions" and create a new Vendor,
or use an existing one.
3) Next, go to "Administration->EDI Account" and add EDI account
(pick that Vendor that you created recently, or the one that you will
use for this test).
4) Also in "Administration->Library EANs" add EAN if you didn't
have one previously.
5) Go back to "Acquisitions" and add a new basket to your Vendor
that you will use for this test.
6) Press "Create EDIFACT order" button. It should throw
"Can't call method "homebranch" on unblessed reference..."
software error.
7) Apply the patch.
8) Reload the page that threw software error previously
(or repeat steps 5, 6 if you need another basket),
it should go through now.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:21:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:21:31 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
--- Comment #19 from Tomás Cohen Arazi ---
Created attachment 117454
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117454&action=edit
Bug 27808: (QA follow-up) Make sure the update catches the items we want
This query:
SELECT *
FROM items
LEFT JOIN issues
ON issues.itemnumber=items.itemnumber
WHERE items.onloan IS NULL;
returns 961 rows on the sample data, with 2 items checked out and onloan
set to NULL.
With this tweak, the query only matches the 2 checkout items with onloan
set to NULL:
SELECT *
FROM items
LEFT JOIN issues
ON issues.itemnumber=items.itemnumber
WHERE items.onloan IS NULL AND issues.issue_id IS NOT NULL;
This is the query that needs to be used on the atomic update for
filtering the items to be updated.
This patch does that.
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:23:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:23:58 +0000
Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing
editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |21.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:00 +0000
Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing
editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976
--- Comment #48 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:03 +0000
Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on
catalog search results in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |21.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:05 +0000
Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on
catalog search results in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846
--- Comment #9 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:07 +0000
Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or
warn the user if CheckPrevCheckout is used via SIP2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |21.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:09 +0000
Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or
warn the user if CheckPrevCheckout is used via SIP2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591
--- Comment #12 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:11 +0000
Subject: [Koha-bugs] [Bug 26937] Add an optional delay to the
CheckPrevCheckout system preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |21.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:12 +0000
Subject: [Koha-bugs] [Bug 26937] Add an optional delay to the
CheckPrevCheckout system preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937
--- Comment #10 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:14 +0000
Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |21.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:16 +0000
Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316
--- Comment #20 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:18 +0000
Subject: [Koha-bugs] [Bug 27592] Link audio alerts to corresponding
preference and back
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27592
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |21.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:19 +0000
Subject: [Koha-bugs] [Bug 27592] Link audio alerts to corresponding
preference and back
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27592
--- Comment #4 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:21 +0000
Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:23 +0000
Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673
--- Comment #30 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:25 +0000
Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering
on multi-data-field columns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |21.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:26 +0000
Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering
on multi-data-field columns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680
--- Comment #42 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:28 +0000
Subject: [Koha-bugs] [Bug 27792] Improve jEditable configuration for point
of sale fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |21.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:30 +0000
Subject: [Koha-bugs] [Bug 27792] Improve jEditable configuration for point
of sale fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792
--- Comment #6 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:32 +0000
Subject: [Koha-bugs] [Bug 27794] Add link to biblio in lateorders page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27794
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |21.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:33 +0000
Subject: [Koha-bugs] [Bug 27794] Add link to biblio in lateorders page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27794
--- Comment #5 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:35 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |21.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:24:37 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
--- Comment #20 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:25:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:25:52 +0000
Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem
value is not "placing an order"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708
Peter Vashchuk changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |stalkernoid at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:26:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:26:22 +0000
Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem
value is not "placing an order"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708
Peter Vashchuk changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117453|0 |1
is obsolete| |
--- Comment #2 from Peter Vashchuk ---
Created attachment 117455
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117455&action=edit
Bug 27708: unify two item object creation blocks to be stored as hash
Previously for existing item data was stored as an object reference and
then treated as one, but for not yet existing item data was stored as
keys in hash reference in the same variable and later it was treated
like an object, hence why it crashed with "no method".
This patch unifies that variable in both cases filled as hash and
treated as such.
To reproduce:
1) Go to "Administration->System preferences" and change
"AcqCreateItem" to "receiving an order."
2) Now, go to "Acquisitions" and create a new Vendor,
or use an existing one.
3) Next, go to "Administration->EDI Account" and add EDI account
(pick that Vendor that you created recently, or the one that you will
use for this test).
4) Also in "Administration->Library EANs" add EAN if you didn't
have one previously.
5) Go back to "Acquisitions" and add a new basket to your Vendor
that you will use for this test.
6) Press "Create EDIFACT order" button. It should throw
"Can't call method "homebranch" on unblessed reference..."
software error.
7) Apply the patch.
8) Reload the page that threw software error previously
(or repeat steps 5, 6 if you need another basket),
it should go through now.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:27:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:27:05 +0000
Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673
--- Comment #31 from Jonathan Druart ---
Mason, I pushed your follow-up, but did you see Joonas's comment about it?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:29:09 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:29:09 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
--- Comment #21 from Jonathan Druart ---
I missed your patch Tomas, can you resubmit for updatedatabase.pl please?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:30:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:30:18 +0000
Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem
value is not "placing an order"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |stalkernoid at gmail.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:40:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:40:47 +0000
Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on
catalog search results in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #10 from Jonathan Druart ---
> - Local cover images (including multiple local cover images)
Hum, this does not work actually. Only the first image is displayed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:42:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:42:35 +0000
Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on
catalog search results in the staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846
--- Comment #11 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #10)
> > - Local cover images (including multiple local cover images)
>
> Hum, this does not work actually. Only the first image is displayed.
Nevermind, it's already how it works.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:57:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 14:57:16 +0000
Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a
checked out item is issued to another patron without being returned first
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117454|0 |1
is obsolete| |
--- Comment #22 from Tomás Cohen Arazi ---
Created attachment 117456
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117456&action=edit
Bug 27808: (QA follow-up) Make sure the update catches the items we want
This query:
SELECT *
FROM items
LEFT JOIN issues
ON issues.itemnumber=items.itemnumber
WHERE items.onloan IS NULL;
returns 961 rows on the sample data, with 2 items checked out and onloan
set to NULL.
With this tweak, the query only matches the 2 checkout items with onloan
set to NULL:
SELECT *
FROM items
LEFT JOIN issues
ON issues.itemnumber=items.itemnumber
WHERE items.onloan IS NULL AND issues.issue_id IS NOT NULL;
This is the query that needs to be used on the atomic update for
filtering the items to be updated.
This patch does that.
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 16:17:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 15:17:42 +0000
Subject: [Koha-bugs] [Bug 27717] Date of birth fails to display for babies
under 1 year
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27717
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|minor |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 16:42:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 15:42:41 +0000
Subject: [Koha-bugs] [Bug 27823] New: List upcoming steps during
installation process
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27823
Bug ID: 27823
Summary: List upcoming steps during installation process
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Installation and upgrade (web-based installer)
Assignee: oleonard at myacpl.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
Created attachment 117457
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117457&action=edit
Screenshot of the proposed change
I think it would be nice for the user installing Koha to be able to see what
the upcoming steps were. See attached.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 16:53:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 15:53:14 +0000
Subject: [Koha-bugs] [Bug 27823] List upcoming steps during installation
process
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27823
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 16:53:17 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 15:53:17 +0000
Subject: [Koha-bugs] [Bug 27823] List upcoming steps during installation
process
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27823
--- Comment #1 from Owen Leonard ---
Created attachment 117458
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117458&action=edit
Bug 27823: List upcoming steps during installation process
This patch adds text to each step of the installation process showing
which steps have been completed, which step is current, and which steps
come next. This helps the user know where they are in the process.
To test, apply the patch and begin the process of installing Koha. In my
testing environment I drop the Koha database and create it again.
On each step of the installation process, confirm that the list of steps
is correct, showing the right stage in the process.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 16:54:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 15:54:51 +0000
Subject: [Koha-bugs] [Bug 27823] List upcoming steps during installation
process
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27823
--- Comment #2 from Owen Leonard ---
It feels dumb to repeat the block of markup again and again but when I thought
about how I could use an include file the logic looked just as convoluted. If
someone has a good idea I'd love to hear it!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:02:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:02:08 +0000
Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering
on multi-data-field columns
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680
--- Comment #43 from Jonathan Druart ---
We have a test that is failing:
# Failed test 'exact match for JSON Pointer "/order_by"'
# at t/Koha/REST/Plugin/Query.t line 338.
# Structures begin differing at:
# $got = ARRAY(0x55702f09b360)
# $expected = HASH(0x55702f094400)
# Looks like you failed 1 test of 20.
# Failed test 'dbic_merge_sorting() tests'
# at t/Koha/REST/Plugin/Query.t line 343.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:12:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:12:16 +0000
Subject: [Koha-bugs] [Bug 27824] New: Report batch operations break with
space in placeholder
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824
Bug ID: 27824
Summary: Report batch operations break with space in
placeholder
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Reports
Assignee: koha-bugs at lists.koha-community.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
Depends on: 23390
I found this bug while testing Bug 5697:
Using the system for defining a column name placeholder (Bug 23390), if there
is a space inside the column name placeholder it won't work. The SQL example in
Bug 5697:
SELECT
i.itemnumber,
i.itemnumber as Exemplarnummber,
[[i.itemnumber| itemnumber for batch]],
CONCAT('', i.itemnumber,
' ' ) AS "itemnumber as edit link"
FROM items i
"[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for
batch." With that space removed it works as expected.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390
[Bug 23390] Add placeholder syntax for column names
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:12:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:12:16 +0000
Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |27824
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824
[Bug 27824] Report batch operations break with space in placeholder
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:13:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:13:25 +0000
Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697
--- Comment #12 from Owen Leonard ---
(In reply to Owen Leonard from comment #11)
> I think this must be
> considered a bug in the placeholder parsing
I have filed Bug 27824
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:14:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:14:11 +0000
Subject: [Koha-bugs] [Bug 27784] Unknown authority types break elasticsearch
authorities indexing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27784
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:14:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:14:14 +0000
Subject: [Koha-bugs] [Bug 27784] Unknown authority types break elasticsearch
authorities indexing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27784
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117378|0 |1
is obsolete| |
--- Comment #4 from David Nind ---
Created attachment 117459
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117459&action=edit
Bug 27784: Unit tests
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:14:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:14:18 +0000
Subject: [Koha-bugs] [Bug 27784] Unknown authority types break elasticsearch
authorities indexing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27784
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #117379|0 |1
is obsolete| |
--- Comment #5 from David Nind ---
Created attachment 117460
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117460&action=edit
Bug 27784: Don't parse subdivision authorities as headings
Subdivision authorities are not used for linking, however, they are recognized
by
C4::AuthoritiesMarc
While these records are not used for linking, they could provide reference and
should be allowed to exist in the catalog without breaking ES indexing
THis patch simply skips the step of parsing the authorities into the linking
form
if the type contains '_SUBD'
To test:
1 - Import a subdivision authority record via Z39 or use the one attached to
this bug
2 - perl misc/search_tools/rebuild_elasticsearch.pl -v -d
3 - Authority indexing dies:
Use of uninitialized value $tag in hash element at
/usr/share/perl5/MARC/Record.pm line 202.
Use of uninitialized value $tag in regexp compilation at
/usr/share/perl5/MARC/Record.pm line 206.
Use of uninitialized value $tag in hash element at
/usr/share/perl5/MARC/Record.pm line 207.
Can't call method "tag" on an undefined value at
/kohadevbox/koha/C4/Heading.pm line 71.
4 - Apply patches
5 - reindex
6 - Success!
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:15:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:15:57 +0000
Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing
editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com,
| |nick at bywatersolutions.com
--- Comment #49 from Jonathan Druart ---
Hum, there is a test failing that may be related to this, but I don't recreate
locally (D9_My8):
16:25:53 koha_1 | # Failed test 'Module
Koha::AuthSubfieldStructures should have koha_object[s]_class method if needed'
16:25:53 koha_1 | # at t/db_dependent/TestBuilder.t line 402.
16:25:53 koha_1 | # got: 'Can't locate object method
"_new_from_dbic" via package "Koha::Authority::Subfield" (perhaps you forgot to
load "Koha::Authority::Subfield"?) at /kohadevbox/koha/Koha/Object.pm line 335.
16:25:53 koha_1 | # '
16:25:53 koha_1 | # expected: ''
16:26:47 koha_1 | # Looks like you failed 1 test of 526.
16:26:47 koha_1 |
16:26:47 koha_1 | # Failed test 'Test all classes'
16:26:47 koha_1 | # at t/db_dependent/TestBuilder.t line 413.
16:26:48 koha_1 | # Looks like you failed 1 test of 5.
However I found an inconsistency. Those patches introduced
Koha::AuthSubfieldStructure[s], but we already had
Koha::Authority::Subfield[s].
It also introduced Koha::MarcSubfieldStructure[s].
What about:
Koha::Framework::Biblio::Subfield[s]
Koha::Framework::Authority::Subfield[s]
Then later:
Koha::Framework::Biblio::Tag[s]
Koha::Framework::Authority::Tag[s]
Or... Koha::MARC::Biblio::Subfield? Koha::MARCStructure::Biblio::Subfield?
Or... Koha::Framework::Subfield::Biblio and Koha::FrameworkSubfield::Authority
that would inherit from Koha::Framework::Subfield. But then we need to drop the
plural forms.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:16:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:16:33 +0000
Subject: [Koha-bugs] [Bug 27784] Unknown authority types break elasticsearch
authorities indexing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27784
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #6 from David Nind ---
Thanks Nick for providing a sample record!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:28:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:28:39 +0000
Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks
our REST API routes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893
--- Comment #26 from Martin Renvoize ---
Mojolicious uses pretty standard semantic versioning.. jump a major and you
can't really expect things to work.
The latest combination of dependencies I found to work with current Koha is:
Mojolicous 8.73
JSON::Validator 4.05
Mojolicious::Plugin::OpenAPI 3.39
If we wanted to jump beyond that we'll need to change the Koha codebase to
accommodate the changes in the libraries.
What's easier, backporting new libraries to older Debian (and updating our
codebase for the newer libraries) or downgrading/pinning older libraries on
newer Debian?
Or, dare I say it.. shipping a local clone of the Mojo stack inside Koha.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:38:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:38:55 +0000
Subject: [Koha-bugs] [Bug 23780] Batch check out fails to inform or trap
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #6 from David Nind ---
I'm not sure how to trigger this when testing.
Before applying the patch, and if I add an invoice for $50 (which is over the
limit), I get this message on batch check out screen:
Cannot check out!
Charges: Patron has outstanding charges of 50.00. Checkouts are BLOCKED because
fine balance is OVER THE LIMIT. [Make payment][Pay all fines]
Patch still applies.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:40:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:40:45 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
creates UX inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247
--- Comment #6 from Nick Clemens ---
Created attachment 117461
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117461&action=edit
Bug 26247: Atomic update
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:41:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:41:13 +0000
Subject: [Koha-bugs] [Bug 26777] Give the user the option to display their
patron card barcode from the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777
--- Comment #5 from Owen Leonard ---
Looks like this tool has more options, including all the options we offer in
the patron card creator:
https://github.com/metafloor/bwip-js
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:46:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 16:46:36 +0000
Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks
our REST API routes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893
--- Comment #27 from Jonathan Druart ---
The short term solution is to package a 4.99+really3.25-koha
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 18:08:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 17:08:29 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=24359
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 18:08:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 17:08:29 +0000
Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked
in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=15516
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 18:13:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 17:13:26 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
--- Comment #284 from Kyle M Hall ---
What impact will this feature have on the holds queue. As it stands, there will
be a request in the queue for each available item in the hold group. I see the
holds to pull report gives a link to the holds group. I think the same
functionality would be needed for the holds queue report as well.
In addition, we'll need to make sure this bug and bug 24359 work together.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 18:13:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 17:13:54 +0000
Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked
in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:40:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 18:40:12 +0000
Subject: [Koha-bugs] [Bug 27825] New: Add preference for choosing the
default format for patron barcodes
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27825
Bug ID: 27825
Summary: Add preference for choosing the default format for
patron barcodes
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: System Administration
Assignee: koha-bugs at lists.koha-community.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
CC: barbara.johnson at bedfordtx.gov, gmcharlt at gmail.com,
lisetteslatah at gmail.com, magnus at libriotech.no,
martin.renvoize at ptfs-europe.com,
testopia at bugs.koha-community.org
Blocks: 26777
Whether we add scannable barcodes to the OPAC via a JS library (as suggested in
Bug 26777) or via an API (Bug 26692), it would be good to provide the library
with a way to define the format for the barcode output. This could also be used
as the default in the patron card creator.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777
[Bug 26777] Give the user the option to display their patron card barcode from
the OPAC
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:40:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 18:40:12 +0000
Subject: [Koha-bugs] [Bug 26777] Give the user the option to display their
patron card barcode from the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |27825
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27825
[Bug 27825] Add preference for choosing the default format for patron barcodes
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:40:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 18:40:12 +0000
Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=27825
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:46:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 18:46:30 +0000
Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked
in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:46:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 18:46:33 +0000
Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked
in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #114405|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:46:37 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 18:46:37 +0000
Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked
in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #114406|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:47:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 18:47:22 +0000
Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked
in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:47:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 18:47:27 +0000
Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked
in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359
--- Comment #10 from Tomás Cohen Arazi ---
Created attachment 117462
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117462&action=edit
Bug 24359: Add test
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:47:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 01 Mar 2021 18:47:31 +0000
Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked
in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359
--- Comment #11 from Tomás Cohen Arazi ---
Created attachment 117463
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117463&action=edit
Bug 24359: Remove hold from holds queue when captured
This patch removes a hold from holds queue when captured by check in.
To test:
1. check out an item from a book with multiple items for patron_1
2. place a biblio level hold for patron_2
3. perl misc/cronjobs/holds/build_holds_queue.pl
CHECK => holds queue shows the placed hold
4. check in the item from step 1 and confirm hold for patron_2
SUCCESS => hold for patron_2 is no longer in holds queue
5. prove t/db_dependent/HoldsQueue.t
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi