From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:46:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 02:46:03 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:46:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 02:46:10 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114650|0 |1 is obsolete| | Attachment #114651|0 |1 is obsolete| | Attachment #114652|0 |1 is obsolete| | Attachment #114653|0 |1 is obsolete| | Attachment #114654|0 |1 is obsolete| | Attachment #114655|0 |1 is obsolete| | Attachment #114656|0 |1 is obsolete| | Attachment #114657|0 |1 is obsolete| | Attachment #114658|0 |1 is obsolete| | Attachment #114659|0 |1 is obsolete| | --- Comment #280 from Aleisha Amohia --- Created attachment 117423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117423&action=edit Bug 15516: Database and installer updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:46:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 02:46:17 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #281 from Aleisha Amohia --- Created attachment 117424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117424&action=edit Bug 15516: Relevant controller changes and tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:46:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 02:46:24 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #282 from Aleisha Amohia --- Created attachment 117425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117425&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This feature only applies to the staff client. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:46:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 02:46:31 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #283 from Aleisha Amohia --- Created attachment 117426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117426&action=edit Bug 15516: Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 03:49:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 02:49:12 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Text to go in the| |This features allows a release notes| |patron to place a hold on | |the first available item | |from a group of titles on | |the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 07:47:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 06:47:55 +0000 Subject: [Koha-bugs] [Bug 27820] New: plugins_nightly.pl script fails with: Undefined subroutine &main::cronlogaction Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 Bug ID: 27820 Summary: plugins_nightly.pl script fails with: Undefined subroutine &main::cronlogaction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: solaris.smoke at gmail.com QA Contact: testopia at bugs.koha-community.org The new plugins_nightly.pl script that was introduced in Koha 20.11.03 doesn't work - it fails with the following error: /etc/cron.daily/koha-common: Undefined subroutine &main::cronlogaction called at /usr/share/koha/bin/cronjobs/plugins_nightly.pl line 8. The issue appears to be a missing import - from looking at other files that use cronlogaction, the following is missing from this file: use C4::Log; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 08:32:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 07:32:25 +0000 Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with: Undefined subroutine &main::cronlogaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 [Bug 25245] Add a plugin hook to allow running code on a nightly basis -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 08:32:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 07:32:25 +0000 Subject: [Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 [Bug 27820] plugins_nightly.pl script fails with: Undefined subroutine &main::cronlogaction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 08:33:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 07:33:05 +0000 Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with: Undefined subroutine &main::cronlogaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 08:51:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 07:51:11 +0000 Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with: Undefined subroutine &main::cronlogaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 Samir Shah changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |solaris.smoke at gmail.com --- Comment #1 from Samir Shah --- Created attachment 117427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117427&action=edit Fix missing import in plugins_nightly.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 08:52:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 07:52:17 +0000 Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with: Undefined subroutine &main::cronlogaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 Samir Shah changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch --- Comment #2 from Samir Shah --- I've added a patch that I think resolves the issue. I'm not familiar enough with Perl to be able to contribute more (e.g., tests, if required). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 09:26:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 08:26:54 +0000 Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 --- Comment #20 from Jonathan Druart --- (In reply to Christopher Brannon from comment #19) > Jonathan, > Can the work you've done here be applied to the cart? If so, I could create > a ticket suggesting that enhancement. What exactly? I have tested on master and I see the item info for a single hold and the "multi holds view" if more than 1 is selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:11:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:11:29 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #96 from Martin Renvoize --- Comment on attachment 113967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113967 Bug 22690: Refactor merging of records to improve performance (Elasticsearch) Review of attachment 113967: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22690&attachment=113967) ----------------------------------------------------------------- ::: Koha/Item.pm @@ +1082,5 @@ > + > +$params: > + skip_record_index => 1|0 > + > +Returns undef if the move failed or the biblionumber of the destination record otherwise I wonder if this might be nicer as a fluent interface (i.e returning $self so it can be chained.. the undef return would become a no-op and the final return would be the updated Koha::Item object?) One for later perhaps ::: Koha/Schema/Result/Item.pm @@ +778,4 @@ > '+exclude_from_local_holds_priority' => { is_boolean => 1 }, > ); > > +# Relationship with orders via the aqorders_item table that not have foreign keys Was there a reason not to add the foreign key and let dbic generate the relationship? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:14:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:14:04 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #97 from Martin Renvoize --- (In reply to Ere Maijala from comment #95) > (In reply to Jonathan Druart from comment #94) > > So the problem is actually that the reindex is not async. > > Bug 27344 is trying to provide a solution for that. > > That's part of it, but I believe the refactoring improves the flow and > readability of the code as well. I think I agree, the code flow is clearer with this work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:18:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:18:19 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 --- Comment #7 from Fridolin Somers --- - $to = $from + $resultsperpage ; + $to = $startfrom * $resultsperpage + $resultsperpage ; I dont understand this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:27:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:27:32 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #98 from Martin Renvoize --- Comment on attachment 113967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113967 Bug 22690: Refactor merging of records to improve performance (Elasticsearch) Review of attachment 113967: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22690&attachment=113967) ----------------------------------------------------------------- ::: Koha/Item.pm @@ +1064,5 @@ > +sub item_orders { > + my ( $self ) = @_; > + > + my $orders = $self->_result->item_orders; > + return Koha::Acquisition::Orders->_new_from_dbic($orders); In it's current form, this can result in failure.. I'm not seeing any handling for that... i.e. if an item is deleted it gets moved to deleted_items but the itemnumber remains in the aqorder_items table as there is no foreign key constraint.. have you tested this case? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:31:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:31:28 +0000 Subject: [Koha-bugs] [Bug 27597] Searching "kw:term" does not work with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27597 --- Comment #7 from Fridolin Somers --- # Remove unquoted colons that have whitespace on either side of them - $term =~ s/(:+)(\s+)$lookahead/$2/g; + $term =~ s/(:+)(\s+)$lookahead//g; $term =~ s/(\s+)(:+)$lookahead/$1/g; Could you explain this change please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:33:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:33:32 +0000 Subject: [Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117180|0 |1 is obsolete| | Attachment #117181|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 117428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117428&action=edit Bug 26997: CAST AS CHAR to prevent the error To prevent the DBMS to fail on 0000-00-00 we can cast it as a char and compare. This patch also moves to a subroutine, in case we need to adjust (or reuse) it later. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Bug 26997: (QA follow-up) Fix Typo Feel free to squash this ;) Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart JD Amended patch - remove changes prior to 3.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:42:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:42:40 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #99 from Martin Renvoize --- Comment on attachment 113967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113967 Bug 22690: Refactor merging of records to improve performance (Elasticsearch) Review of attachment 113967: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22690&attachment=113967) ----------------------------------------------------------------- ::: Koha/Item.pm @@ +1102,5 @@ > + biblioitemnumber => $to_biblio->biblioitem->biblioitemnumber > + })->store({ skip_record_index => $params->{skip_record_index} }); > + > + # Acquisition orders > + $self->item_orders->update({ biblionumber => $biblionumber }, { no_triggers => 1 }); no_triggers: Varified this one is OK.. we don't have any code level triggers based on biblionumber that I can see.. happy with this and understand why your using it. @@ +1105,5 @@ > + # Acquisition orders > + $self->item_orders->update({ biblionumber => $biblionumber }, { no_triggers => 1 }); > + > + # Holds > + $self->holds->update({ biblionumber => $biblionumber }, { no_triggers => 1 }); I don't see any code level triggers at all for Koha::Hold or Koha::Holds.. as such I don't think we should call 'no_triggers' here.. Without a local ->store method in Koha::Hold, or a local ->update method in Koha::Holds the result of calling Koha::Objects->update should be the same as without no_triggers passed. As such, I feel for future-proofing we should not pass no_triggers as we don't currently know that our biblionumber change here wouldn't be part of a trigger in the future. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:45:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:45:18 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart --- Don't we need a DBrev to adjust items.onloan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:48:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:48:03 +0000 Subject: [Koha-bugs] [Bug 27432] Add report run to action logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #13 from Fridolin Somers --- (In reply to Katrin Fischer from comment #12) > I feel something is out of order here - patches don't apply in the current > sequence. > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 27432: (follow-up) Correct grammar of preference description > error: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref). > error: could not build fake ancestor > Patch failed at 0001 Bug 27432: (follow-up) Correct grammar of preference > description > The copy of the patch that failed is found in: .git/rebase-apply/patch > When you have resolved this problem run "git bz apply --continue". > If you would prefer to skip this patch, instead run "git bz apply --skip". > To restore the original branch and stop patching run "git bz apply --abort". > Patch left in > /tmp/Bug-27432-follow-up-Correct-grammar-of-preference--qT_FEt.patch Ah indeed, patch : Bug 27432: (follow-up) Correct grammar of preference description Is from 17:45 and other patches are from 17:54. I think this patch must be moved after main patch : Bug 27432: Add report run to action logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:49:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:49:39 +0000 Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with: Undefined subroutine &main::cronlogaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Good catch, I set status to need signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:51:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:51:09 +0000 Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #100 from Martin Renvoize --- Failing QA to get some attention.. I don't think anything is major here.. it's more that I want to get verification that things have been considered and taken care of. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:54:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:54:28 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #114943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:56:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:56:04 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24997 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 10:56:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 09:56:04 +0000 Subject: [Koha-bugs] [Bug 24997] Test to ensure mappings.yaml is in the correct order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24997 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27316 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:00:06 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115938|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 117429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117429&action=edit Bug 27316: Convert 'undef' for sort to Yes and use Yes/No instead of 0/1 This patch changes the interface to remove the undef option We also update existing mappings and set default of 1 Comment previously indicated undef was treated differently, but in the code we treat undef as 1 That code is untoched to avoid creating problems for older mappings that may be reloaded To test: 1 - View the ES mappings, note you can set columns to Undef, 0, 1 2 - Set some to undef 3 - Apply patches 4 - Update database 5 - Undef now show as 'Yes' 6 - Confirm you can set columns as Yes/no 7 - Confirm that mandatory columns display correct value when readonly (see issues field) Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:00:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:00:10 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115939|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 117430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117430&action=edit Bug 27316: (follow-up) Default to 1 if undef in mappings Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:00:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:00:48 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Martin Renvoize --- Works nicely and is much cleaner/clearer. No regressions found.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:06:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:06:27 +0000 Subject: [Koha-bugs] [Bug 27795] Misalignment of TOTAL value in lateorders page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117331|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 117431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117431&action=edit Bug 27795: Misalignment of TOTAL value in lateorders page This patch corrects the colspan in the footer of the late orders page. It also adds a quantity total cell to the footer and changes the container of the buttons at the bottom of the page from a

tag to the standard

. To test, apply the patch and go to Acquisitions -> Late orders. In the footer of the late orders page, there should be a total under the "Quantity" column. The total cost number should be correctly aligned under the "total cost" header cell. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:06:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:06:54 +0000 Subject: [Koha-bugs] [Bug 27795] Misalignment of TOTAL value in lateorders page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Looks good, signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:11:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:11:54 +0000 Subject: [Koha-bugs] [Bug 27161] Base.pm complains about unitialized value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- I'm wondering if we ought to instead define a default.. i.e. my $metadata = $self->{metadata}; vs my $metadata = $self->{metadata} // {}; ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:12:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:12:46 +0000 Subject: [Koha-bugs] [Bug 27821] New: sanitize_zero_date does not handle datetime Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821 Bug ID: 27821 Summary: sanitize_zero_date does not handle datetime Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Only datatype "date" is handled correctly. Atomic update generated errors: main::sanitize_zero_date(): DBI Exception: DBD::mysql::db do failed: Truncated incorrect CHAR(10) value: '2021-03-01 09:43:56' [for Statement " UPDATE old_issues SET returndate = NULL WHERE CAST(returndate AS CHAR(10)) = '0000-00-00'; "] at (eval 1481) line 5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:14:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:14:02 +0000 Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |fridolin.somers at biblibre.co | |m, victor at tuxayo.net Depends on| |26997 --- Comment #1 from Jonathan Druart --- RMaints, keep an eye on this one, you may need to backport it quickly. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:14:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:14:02 +0000 Subject: [Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821 [Bug 27821] sanitize_zero_date does not handle datetime -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:14:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:14:54 +0000 Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:14:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:14:57 +0000 Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821 --- Comment #2 from Jonathan Druart --- Created attachment 117432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117432&action=edit Bug 27821: Make sanitize_zero_date support datetime and timestamp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:15:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:15:08 +0000 Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:15:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:15:15 +0000 Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:15:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:15:58 +0000 Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27821 --- Comment #26 from Jonathan Druart --- I wrote bug 27821, otherwise the cast on old_issues.returndate didn't work. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821 [Bug 27821] sanitize_zero_date does not handle datetime -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:15:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:15:58 +0000 Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 [Bug 7806] Don't use 0000-00-00 to signal a non-existing date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:20:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:20:17 +0000 Subject: [Koha-bugs] [Bug 27718] Holds to Pull list doesn't respect holdallowed circulation rule anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27718 --- Comment #19 from Jonathan Druart --- Thanks Andrew for the follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:26:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:26:22 +0000 Subject: [Koha-bugs] [Bug 27798] Independent branches should have a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117363|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 117433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117433&action=edit Bug 27798: Add warning to IndependentBranches system preference Test Plan: 1) Apply this patch 2) Search system preferences for IndependentBranches 3) Note the warning about changing the setting on a production system Signed-off-by: David Nind Signed-off-by: Marcel de Rooy JD Amended patch: * Fix commit title * Don't split the syspref's description, otherwise the sentence will be split in the POs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:28:40 +0000 Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:28:42 +0000 Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #27 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:28:45 +0000 Subject: [Koha-bugs] [Bug 25777] Datatables on z3950_search.pl show incorrect number of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:28:47 +0000 Subject: [Koha-bugs] [Bug 25777] Datatables on z3950_search.pl show incorrect number of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25777 --- Comment #24 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:28:49 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:28:51 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #31 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:28:53 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:28:56 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #38 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:28:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:28:58 +0000 Subject: [Koha-bugs] [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:00 +0000 Subject: [Koha-bugs] [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071 --- Comment #37 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:03 +0000 Subject: [Koha-bugs] [Bug 27578] Searchid not initialized when adding a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:05 +0000 Subject: [Koha-bugs] [Bug 27578] Searchid not initialized when adding a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27578 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:07 +0000 Subject: [Koha-bugs] [Bug 27718] Holds to Pull list doesn't respect holdallowed circulation rule anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:09 +0000 Subject: [Koha-bugs] [Bug 27718] Holds to Pull list doesn't respect holdallowed circulation rule anymore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27718 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:11 +0000 Subject: [Koha-bugs] [Bug 27754] Correct eslint errors in basket.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:13 +0000 Subject: [Koha-bugs] [Bug 27754] Correct eslint errors in basket.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27754 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:15 +0000 Subject: [Koha-bugs] [Bug 27798] Independent branches should have a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:17 +0000 Subject: [Koha-bugs] [Bug 27798] Independent branches should have a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27798 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:19 +0000 Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:21 +0000 Subject: [Koha-bugs] [Bug 27821] sanitize_zero_date does not handle datetime In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27821 --- Comment #3 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:34 +0000 Subject: [Koha-bugs] [Bug 8426] Diacritics not being mapped for searching (Non-ICU) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10783|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 117434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117434&action=edit Bug 8426 - Diacritics not being mapped for searching Add mappings for ︡a to a, and for t︠ to t. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:29:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:29:46 +0000 Subject: [Koha-bugs] [Bug 8426] Diacritics not being mapped for searching (Non-ICU) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:31:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:31:45 +0000 Subject: [Koha-bugs] [Bug 27597] Searching "kw:term" does not work with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27597 --- Comment #8 from Jonathan Druart --- (In reply to Fridolin Somers from comment #7) > # Remove unquoted colons that have whitespace on either side of them > - $term =~ s/(:+)(\s+)$lookahead/$2/g; > + $term =~ s/(:+)(\s+)$lookahead//g; > $term =~ s/(\s+)(:+)$lookahead/$1/g; > > Could you explain this change please ? Look at the unit tests, it removes extra spaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:45:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:45:18 +0000 Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with: Undefined subroutine &main::cronlogaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 --- Comment #4 from Fridolin Somers --- Created attachment 117435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117435&action=edit Bug 27820: fix missing import in plugins_nightly.pl Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:45:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:45:31 +0000 Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script fails with: Undefined subroutine &main::cronlogaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 --- Comment #5 from Fridolin Somers --- Created attachment 117436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117436&action=edit Bug 27820: add all missing use in misc/cronjobs/plugins_nightly.pl Koha::Plugins and C4::Context where missing. Try::Tiny was missing for try/catch. Test plan : 1) Use a plugin using hook 'cronjob_nightly' 2) Run script : misc/cronjobs/plugins_nightly.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:54:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:54:02 +0000 Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script missing use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|plugins_nightly.pl script |plugins_nightly.pl script |fails with: Undefined |missing use |subroutine | |&main::cronlogaction | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:55:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:55:06 +0000 Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script missing use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 --- Comment #6 from Fridolin Somers --- Piouf nearly all use where missing :D In order to test, I've added a pull request on KitchenSink Koha plugin : https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/pull/15 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 11:55:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 10:55:39 +0000 Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script missing use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117427|0 |1 is obsolete| | --- Comment #7 from Fridolin Somers --- Comment on attachment 117427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117427 Fix missing import in plugins_nightly.pl I've signed first patch and created a second one that needs signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 12:18:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 11:18:59 +0000 Subject: [Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114884|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 117437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117437&action=edit Bug 27267: Add memory efficient Zebra indexing daemon This patch adds an alternate Zebra indexing daemon which is much more memory efficient than the current default daemon. (For instance, zebra_indexer.pl uses 6MB of RAM vs rebuild_zebra.pl which uses about 180MB of RAM out of the box while idle.) To test: 0. Apply patch 1. koha-indexer --stop kohadev 2. vi /etc/default/koha-common 3. Update ALTERNATE_INDEXER_DAEMON to be "/kohadevbox/koha/misc/zebra_indexer.pl" 4. koha-indexer --start kohadev 5. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 6. Change 245$a to "Gone" instead of "Gairm" and save the record 7. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=Gairm 8. Repeat Step 7 for 5+ seconds until your search returns no results 9. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 10. Change 245$a from "Gone" to "Gairm" 11. Repeat Step 7 for 5+ seconds until your search redirects you to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29&found1=1 To confirm lower memory usage: 12. ps -efww | grep "zebra_indexer" 13. top -p 14. The top tool should show about 6.1MB usage. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 12:20:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 11:20:37 +0000 Subject: [Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- This works well and is a nice clean implementation. There is one minor QA script failure.. you open 'my $child_in' in the open3 call, but never actually use it... this causes some noise in our QA script understandably but I'm not sure it's a real issue in reality. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 12:23:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 11:23:35 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #14) > Don't we need a DBrev to adjust items.onloan? Totally agree! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:18:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:18:20 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com Keywords| |rel_21_05_candidate Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:19:20 +0000 Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:19:25 +0000 Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117389|0 |1 is obsolete| | Attachment #117390|0 |1 is obsolete| | Attachment #117391|0 |1 is obsolete| | Attachment #117392|0 |1 is obsolete| | Attachment #117393|0 |1 is obsolete| | Attachment #117394|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart --- Created attachment 117438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117438&action=edit Bug 27680: Take first order column for ordering Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:19:29 +0000 Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #38 from Jonathan Druart --- Created attachment 117439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117439&action=edit Bug 27680: Add support for sorting fields with multiple data points This patch adds proper handling for sorting a single column that is constructed of multiple data entities.. i.e `"data": "string1:string2"` It does NOT add support for filtering on multiple columns yet. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:19:33 +0000 Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #39 from Jonathan Druart --- Created attachment 117440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117440&action=edit Bug 27680: Add tests for various ways of passing multi-params This patch adds unit test to increase the coverage of parameter that accept multiple values. There are a number of different ways end users can send such parameters and we should test to ensure we are recieving the correct option. Options `?param1=this¶m1=that` - traditional multiple pass params `?param1[]=this¶m1[]=that` - php multiple pass params `?param1=this,that` - comma delimited list param `?param1=this|that` - pipe delimited list param Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:19:37 +0000 Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #40 from Jonathan Druart --- Created attachment 117441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117441&action=edit Bug 27680: Allow traditional multi-params to work This patch allows the preceeding test to pass. Strictly, we want a comma delimited string for our _order_by parameter, but we cannot easily block a traditional multi-passed parameter. As such the 'nice' thing to do is handle it when such a thing is passed as it will pass through validation regardless. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:19:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:19:40 +0000 Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #41 from Jonathan Druart --- Created attachment 117442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117442&action=edit Bug 27680: Add support for param[] syntax While not that common nowadays, it is the syntax PHP uses, and DataTables also generates such thing in 'traditional' mode. We should support it as well. This patch adds support for that. It does so by adding _order_by[] to the reserved param names, and proper handling on the dbic_merge_sorting helper. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3- Sign off :-D Signed-off-by: Tomas Cohen Arazi Bug 27680: (QA follow-up) Minor perlcritic issue Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:35:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:35:44 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:35:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:35:47 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 --- Comment #16 from Jonathan Druart --- Created attachment 117443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117443&action=edit Bug 27808: DB changes - adjust items.onloan when needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:38:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:38:46 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:39:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:39:20 +0000 Subject: [Koha-bugs] [Bug 27815] "Remove" in point of sale untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:39:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:39:23 +0000 Subject: [Koha-bugs] [Bug 27815] "Remove" in point of sale untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815 --- Comment #1 from Owen Leonard --- Created attachment 117444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117444&action=edit Bug 27815: "Remove" in point of sale untranslatable This patch modifies the Point of Sale template so that the "Remove" button can be translated. The string in the JavaScript block wasn't wrapped in the correct function. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from the template: e.g. misc/translator/po/fr-FR-staff-prog.po - Locate strings pulled from pos/pay.tt for translation to confirm the update, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt:189 #, c-format msgid "Remove" msgstr "Enlever" - Install the updated translation: > perl translate install fr-FR - In the staff client, go to Point of Sale. - Switch to the French translation and click the "Ajouter" button next to one of the items for purchase. - In the "This sale" table, the item you added should have a corresponding "Enlever" button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:49:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:49:10 +0000 Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:49:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:49:17 +0000 Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:53:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:53:18 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25408 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:53:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:53:18 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:55:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:55:24 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:55:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:55:27 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117400|0 |1 is obsolete| | Attachment #117443|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 117445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117445&action=edit Bug 27808: Refresh the item object when AddReturn is called This patch changes the original implementation so the item object is refreshed altogether instead of explicitly pinpointing a specific field we identified an edge case can leave out from ->store. I propose this alterate implementation because what this bug highlights is the fact we don't code thinking calls to things can have side-effects (like this case, with AddReturn updating the onloan status (and maybe other things?). To test: 1. Make sure circ tests pass with and without this patch Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 13:55:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 12:55:43 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 --- Comment #18 from Kyle M Hall --- Created attachment 117446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117446&action=edit Bug 27808: DB changes - adjust items.onloan when needed Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:10:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:10:14 +0000 Subject: [Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart --- 60 seconds: exporting authority 13:06:38 [1:0] 61 seconds: exporting authority 13:05:30 [1:1] 54321 seconds: exporting authority 13:07:06 [15:5:21] It's not displayed as a duration and it's confusing IMO. It should at least display the HH, MM and SS parts on 2 digits. Why not "15 hours, 5 minutes, 21 seconds" instead? Or "15h 5m 21s"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:11:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:11:27 +0000 Subject: [Koha-bugs] [Bug 27473] Improve link text in the installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:11:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:11:30 +0000 Subject: [Koha-bugs] [Bug 27473] Improve link text in the installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 --- Comment #13 from Owen Leonard --- Created attachment 117447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117447&action=edit Bug 27473: (follow-up) Remove the redirect message I don't think it's necessary to remove the redirect because I don't think it does any harm, but why include a message about it? I think we should treat this step like all the others and provide a button to take the user to the next page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:16:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:16:53 +0000 Subject: [Koha-bugs] [Bug 27473] Improve link text in the installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 --- Comment #14 from Jonathan Druart --- Created attachment 117448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117448&action=edit Bug 27473: Remove the redirect after 10sec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:17:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:17:43 +0000 Subject: [Koha-bugs] [Bug 27473] Improve link text in the installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart --- Then going a bit further and removing the redirect. Katrin, Martin, would you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:20:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:20:48 +0000 Subject: [Koha-bugs] [Bug 27822] New: Wrong systempreference for AddressFormat in 20.11 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 Bug ID: 27822 Summary: Wrong systempreference for AddressFormat in 20.11 Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: verolencinas at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Koha 20.11 has as default "AddressFormat" systempreference "US". If you want to create a new user, you get the error "Template process failed: file error - member-main-address-style-US: not found at /usr/share/koha/lib/C4/Templates.pm line 122" because the system expects "us", not "US". Changing the systempreference solves the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:36:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:36:04 +0000 Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19735 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:36:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:36:04 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26893 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:36:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:36:23 +0000 Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17092 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:36:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:36:23 +0000 Subject: [Koha-bugs] [Bug 17092] Generate debian/control with version numbers from cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17092 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26893 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:43:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:43:22 +0000 Subject: [Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048 --- Comment #14 from Katrin Fischer --- (In reply to Jonathan Druart from comment #13) > 60 seconds: > exporting authority 13:06:38 [1:0] > 61 seconds: > exporting authority 13:05:30 [1:1] > 54321 seconds: > exporting authority 13:07:06 [15:5:21] > > It's not displayed as a duration and it's confusing IMO. It should at least > display the HH, MM and SS parts on 2 digits. > Why not "15 hours, 5 minutes, 21 seconds" instead? Or "15h 5m 21s"? Hm, you are right. I guess my test db was too small, so the big numbers didn't make me suspicious. I think the second format you suggest would be better. Or: Duration: 00:00:02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:44:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:44:08 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17092 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:44:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:44:08 +0000 Subject: [Koha-bugs] [Bug 17092] Generate debian/control with version numbers from cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17092 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19735 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:49:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:49:41 +0000 Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116771|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 117449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117449&action=edit Bug 26273: Add historic cashups table to register page This patch adds a historic cashups table to the bottom of the register transaction details page. It will only display if one or more cashups have taken place and contains links to allow display of the summary detail modal for each cashup. Test plan 1/ Enable UseCashRegisters 2/ Undertake a few transactions and cashups 3/ View the 'Register details' page 4/ Note the appearance of a 'Cashup history' section at the bottom of the page 5/ Note that 'Summary' button displays the relevant modal 6/ Signoff Signed-off-by: Sally Signed-off-by: Daniel Jones Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:49:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:49:44 +0000 Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116772|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 117450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117450&action=edit Bug 26273: (follow-up) Format dates and money correctly. This patch adds the missing formatting for the Datetime and Amount fields. Test plan 1/ Apply patch and reload register page to re-display the cashups table 2/ Note that the 'Date' field now displays a nicely formatted date without an offset. 3/ Note that the 'Amount' field now displays the number according to your money formatting preferences (with 2 decimal places in most cases) 4/ Signoff Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:49:47 +0000 Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116773|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize --- Created attachment 117451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117451&action=edit Bug 26273: (follow-up) Add 'Cashier' to the cashups table This patch adds the 'Cashier' field as discussed on the bug report. Test plan 1/ Apply patch and reload the register page to refresh the table 2/ Note that a 'Cashier' field now appears in the table 3/ Sorting and searching on 'Cashier' should work as expected 4/ Default sorting should remain as 'Date' order. 5/ Signoff Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:50:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:50:03 +0000 Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 14:50:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 13:50:33 +0000 Subject: [Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 --- Comment #26 from Martin Renvoize --- Rebased against the now PQA dependency bug and set status back to SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:01:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:01:18 +0000 Subject: [Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048 --- Comment #15 from Martin Renvoize --- Created attachment 117452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117452&action=edit Bug 27048: (follow-up) Correction to elapsed printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:01:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:01:50 +0000 Subject: [Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048 --- Comment #16 from Martin Renvoize --- Fix the duration printing to take the form [00:00:07] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:04:03 +0000 Subject: [Koha-bugs] [Bug 27473] Improve link text in the installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27473 --- Comment #16 from Martin Renvoize --- Seems reasonable to me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:07:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:07:05 +0000 Subject: [Koha-bugs] [Bug 27682] Add a floating table header for Search engine configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #4 from Jonathan Druart --- 1. There is a weird behaviour, when you hit land on the page the floating header is wider than the thead. However if you go to the bibliographic or authorities tab and come back, it's ok. 2. tableInit( "", "search_fields"); In tableInit we should test if oldtabid is passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:16:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:16:46 +0000 Subject: [Koha-bugs] [Bug 27048] Add timestamps to verbose output of rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27048 --- Comment #17 from Jonathan Druart --- Martin, don't you think we should add a "elapsed" or "duration" to explain what it is? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:20:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:20:36 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:20:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:20:39 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #1 from Peter Vashchuk --- Created attachment 117453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117453&action=edit Bug 27708: unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object and then treated as one, but in the former item data was stored as hash keys in the same variable so later it was treated like an object, hence why it crashed. This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:21:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:21:31 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 117454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117454&action=edit Bug 27808: (QA follow-up) Make sure the update catches the items we want This query: SELECT * FROM items LEFT JOIN issues ON issues.itemnumber=items.itemnumber WHERE items.onloan IS NULL; returns 961 rows on the sample data, with 2 items checked out and onloan set to NULL. With this tweak, the query only matches the 2 checkout items with onloan set to NULL: SELECT * FROM items LEFT JOIN issues ON issues.itemnumber=items.itemnumber WHERE items.onloan IS NULL AND issues.issue_id IS NOT NULL; This is the query that needs to be used on the atomic update for filtering the items to be updated. This patch does that. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:23:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:23:58 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:00 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #48 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:03 +0000 Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:05 +0000 Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:07 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user if CheckPrevCheckout is used via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:09 +0000 Subject: [Koha-bugs] [Bug 26591] Add a choice to prevent the checkout or warn the user if CheckPrevCheckout is used via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26591 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:11 +0000 Subject: [Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:12 +0000 Subject: [Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:14 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:16 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:18 +0000 Subject: [Koha-bugs] [Bug 27592] Link audio alerts to corresponding preference and back In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27592 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:19 +0000 Subject: [Koha-bugs] [Bug 27592] Link audio alerts to corresponding preference and back In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27592 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:21 +0000 Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:23 +0000 Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #30 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:25 +0000 Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:26 +0000 Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #42 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:28 +0000 Subject: [Koha-bugs] [Bug 27792] Improve jEditable configuration for point of sale fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:30 +0000 Subject: [Koha-bugs] [Bug 27792] Improve jEditable configuration for point of sale fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:32 +0000 Subject: [Koha-bugs] [Bug 27794] Add link to biblio in lateorders page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:33 +0000 Subject: [Koha-bugs] [Bug 27794] Add link to biblio in lateorders page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27794 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:35 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:24:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:24:37 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:25:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:25:52 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stalkernoid at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:26:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:26:22 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117453|0 |1 is obsolete| | --- Comment #2 from Peter Vashchuk --- Created attachment 117455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117455&action=edit Bug 27708: unify two item object creation blocks to be stored as hash Previously for existing item data was stored as an object reference and then treated as one, but for not yet existing item data was stored as keys in hash reference in the same variable and later it was treated like an object, hence why it crashed with "no method". This patch unifies that variable in both cases filled as hash and treated as such. To reproduce: 1) Go to "Administration->System preferences" and change "AcqCreateItem" to "receiving an order." 2) Now, go to "Acquisitions" and create a new Vendor, or use an existing one. 3) Next, go to "Administration->EDI Account" and add EDI account (pick that Vendor that you created recently, or the one that you will use for this test). 4) Also in "Administration->Library EANs" add EAN if you didn't have one previously. 5) Go back to "Acquisitions" and add a new basket to your Vendor that you will use for this test. 6) Press "Create EDIFACT order" button. It should throw "Can't call method "homebranch" on unblessed reference..." software error. 7) Apply the patch. 8) Reload the page that threw software error previously (or repeat steps 5, 6 if you need another basket), it should go through now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:27:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:27:05 +0000 Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #31 from Jonathan Druart --- Mason, I pushed your follow-up, but did you see Joonas's comment about it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:29:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:29:09 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 --- Comment #21 from Jonathan Druart --- I missed your patch Tomas, can you resubmit for updatedatabase.pl please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:30:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:30:18 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |stalkernoid at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:40:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:40:47 +0000 Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- > - Local cover images (including multiple local cover images) Hum, this does not work actually. Only the first image is displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:42:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:42:35 +0000 Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > > - Local cover images (including multiple local cover images) > > Hum, this does not work actually. Only the first image is displayed. Nevermind, it's already how it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 15:57:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 14:57:16 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117454|0 |1 is obsolete| | --- Comment #22 from Tomás Cohen Arazi --- Created attachment 117456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117456&action=edit Bug 27808: (QA follow-up) Make sure the update catches the items we want This query: SELECT * FROM items LEFT JOIN issues ON issues.itemnumber=items.itemnumber WHERE items.onloan IS NULL; returns 961 rows on the sample data, with 2 items checked out and onloan set to NULL. With this tweak, the query only matches the 2 checkout items with onloan set to NULL: SELECT * FROM items LEFT JOIN issues ON issues.itemnumber=items.itemnumber WHERE items.onloan IS NULL AND issues.issue_id IS NOT NULL; This is the query that needs to be used on the atomic update for filtering the items to be updated. This patch does that. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 16:17:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 15:17:42 +0000 Subject: [Koha-bugs] [Bug 27717] Date of birth fails to display for babies under 1 year In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27717 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 16:42:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 15:42:41 +0000 Subject: [Koha-bugs] [Bug 27823] New: List upcoming steps during installation process Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27823 Bug ID: 27823 Summary: List upcoming steps during installation process Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 117457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117457&action=edit Screenshot of the proposed change I think it would be nice for the user installing Koha to be able to see what the upcoming steps were. See attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 16:53:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 15:53:14 +0000 Subject: [Koha-bugs] [Bug 27823] List upcoming steps during installation process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27823 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 16:53:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 15:53:17 +0000 Subject: [Koha-bugs] [Bug 27823] List upcoming steps during installation process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27823 --- Comment #1 from Owen Leonard --- Created attachment 117458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117458&action=edit Bug 27823: List upcoming steps during installation process This patch adds text to each step of the installation process showing which steps have been completed, which step is current, and which steps come next. This helps the user know where they are in the process. To test, apply the patch and begin the process of installing Koha. In my testing environment I drop the Koha database and create it again. On each step of the installation process, confirm that the list of steps is correct, showing the right stage in the process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 16:54:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 15:54:51 +0000 Subject: [Koha-bugs] [Bug 27823] List upcoming steps during installation process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27823 --- Comment #2 from Owen Leonard --- It feels dumb to repeat the block of markup again and again but when I thought about how I could use an include file the logic looked just as convoluted. If someone has a good idea I'd love to hear it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:02:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:02:08 +0000 Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #43 from Jonathan Druart --- We have a test that is failing: # Failed test 'exact match for JSON Pointer "/order_by"' # at t/Koha/REST/Plugin/Query.t line 338. # Structures begin differing at: # $got = ARRAY(0x55702f09b360) # $expected = HASH(0x55702f094400) # Looks like you failed 1 test of 20. # Failed test 'dbic_merge_sorting() tests' # at t/Koha/REST/Plugin/Query.t line 343. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:12:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:12:16 +0000 Subject: [Koha-bugs] [Bug 27824] New: Report batch operations break with space in placeholder Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Bug ID: 27824 Summary: Report batch operations break with space in placeholder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 23390 I found this bug while testing Bug 5697: Using the system for defining a column name placeholder (Bug 23390), if there is a space inside the column name placeholder it won't work. The SQL example in Bug 5697: SELECT i.itemnumber, i.itemnumber as Exemplarnummber, [[i.itemnumber| itemnumber for batch]], CONCAT('', i.itemnumber, '' ) AS "itemnumber as edit link" FROM items i "[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for batch." With that space removed it works as expected. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 [Bug 23390] Add placeholder syntax for column names -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:12:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:12:16 +0000 Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 [Bug 27824] Report batch operations break with space in placeholder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:13:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:13:25 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 --- Comment #12 from Owen Leonard --- (In reply to Owen Leonard from comment #11) > I think this must be > considered a bug in the placeholder parsing I have filed Bug 27824 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:14:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:14:11 +0000 Subject: [Koha-bugs] [Bug 27784] Unknown authority types break elasticsearch authorities indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27784 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:14:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:14:14 +0000 Subject: [Koha-bugs] [Bug 27784] Unknown authority types break elasticsearch authorities indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27784 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117378|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 117459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117459&action=edit Bug 27784: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:14:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:14:18 +0000 Subject: [Koha-bugs] [Bug 27784] Unknown authority types break elasticsearch authorities indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27784 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117379|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 117460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117460&action=edit Bug 27784: Don't parse subdivision authorities as headings Subdivision authorities are not used for linking, however, they are recognized by C4::AuthoritiesMarc While these records are not used for linking, they could provide reference and should be allowed to exist in the catalog without breaking ES indexing THis patch simply skips the step of parsing the authorities into the linking form if the type contains '_SUBD' To test: 1 - Import a subdivision authority record via Z39 or use the one attached to this bug 2 - perl misc/search_tools/rebuild_elasticsearch.pl -v -d 3 - Authority indexing dies: Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202. Use of uninitialized value $tag in regexp compilation at /usr/share/perl5/MARC/Record.pm line 206. Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 207. Can't call method "tag" on an undefined value at /kohadevbox/koha/C4/Heading.pm line 71. 4 - Apply patches 5 - reindex 6 - Success! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:15:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:15:57 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com --- Comment #49 from Jonathan Druart --- Hum, there is a test failing that may be related to this, but I don't recreate locally (D9_My8): 16:25:53 koha_1 | # Failed test 'Module Koha::AuthSubfieldStructures should have koha_object[s]_class method if needed' 16:25:53 koha_1 | # at t/db_dependent/TestBuilder.t line 402. 16:25:53 koha_1 | # got: 'Can't locate object method "_new_from_dbic" via package "Koha::Authority::Subfield" (perhaps you forgot to load "Koha::Authority::Subfield"?) at /kohadevbox/koha/Koha/Object.pm line 335. 16:25:53 koha_1 | # ' 16:25:53 koha_1 | # expected: '' 16:26:47 koha_1 | # Looks like you failed 1 test of 526. 16:26:47 koha_1 | 16:26:47 koha_1 | # Failed test 'Test all classes' 16:26:47 koha_1 | # at t/db_dependent/TestBuilder.t line 413. 16:26:48 koha_1 | # Looks like you failed 1 test of 5. However I found an inconsistency. Those patches introduced Koha::AuthSubfieldStructure[s], but we already had Koha::Authority::Subfield[s]. It also introduced Koha::MarcSubfieldStructure[s]. What about: Koha::Framework::Biblio::Subfield[s] Koha::Framework::Authority::Subfield[s] Then later: Koha::Framework::Biblio::Tag[s] Koha::Framework::Authority::Tag[s] Or... Koha::MARC::Biblio::Subfield? Koha::MARCStructure::Biblio::Subfield? Or... Koha::Framework::Subfield::Biblio and Koha::FrameworkSubfield::Authority that would inherit from Koha::Framework::Subfield. But then we need to drop the plural forms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:16:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:16:33 +0000 Subject: [Koha-bugs] [Bug 27784] Unknown authority types break elasticsearch authorities indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27784 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind --- Thanks Nick for providing a sample record! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:28:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:28:39 +0000 Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #26 from Martin Renvoize --- Mojolicious uses pretty standard semantic versioning.. jump a major and you can't really expect things to work. The latest combination of dependencies I found to work with current Koha is: Mojolicous 8.73 JSON::Validator 4.05 Mojolicious::Plugin::OpenAPI 3.39 If we wanted to jump beyond that we'll need to change the Koha codebase to accommodate the changes in the libraries. What's easier, backporting new libraries to older Debian (and updating our codebase for the newer libraries) or downgrading/pinning older libraries on newer Debian? Or, dare I say it.. shipping a local clone of the Mojo stack inside Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:38:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:38:55 +0000 Subject: [Koha-bugs] [Bug 23780] Batch check out fails to inform or trap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind --- I'm not sure how to trigger this when testing. Before applying the patch, and if I add an invoice for $50 (which is over the limit), I get this message on batch check out screen: Cannot check out! Charges: Patron has outstanding charges of 50.00. Checkouts are BLOCKED because fine balance is OVER THE LIMIT. [Make payment][Pay all fines] Patch still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:40:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:40:45 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 --- Comment #6 from Nick Clemens --- Created attachment 117461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117461&action=edit Bug 26247: Atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:41:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:41:13 +0000 Subject: [Koha-bugs] [Bug 26777] Give the user the option to display their patron card barcode from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 --- Comment #5 from Owen Leonard --- Looks like this tool has more options, including all the options we offer in the patron card creator: https://github.com/metafloor/bwip-js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 17:46:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 16:46:36 +0000 Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #27 from Jonathan Druart --- The short term solution is to package a 4.99+really3.25-koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 18:08:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 17:08:29 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24359 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 18:08:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 17:08:29 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 18:13:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 17:13:26 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #284 from Kyle M Hall --- What impact will this feature have on the holds queue. As it stands, there will be a request in the queue for each available item in the hold group. I see the holds to pull report gives a link to the holds group. I think the same functionality would be needed for the holds queue report as well. In addition, we'll need to make sure this bug and bug 24359 work together. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 18:13:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 17:13:54 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:40:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:40:12 +0000 Subject: [Koha-bugs] [Bug 27825] New: Add preference for choosing the default format for patron barcodes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27825 Bug ID: 27825 Summary: Add preference for choosing the default format for patron barcodes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: barbara.johnson at bedfordtx.gov, gmcharlt at gmail.com, lisetteslatah at gmail.com, magnus at libriotech.no, martin.renvoize at ptfs-europe.com, testopia at bugs.koha-community.org Blocks: 26777 Whether we add scannable barcodes to the OPAC via a JS library (as suggested in Bug 26777) or via an API (Bug 26692), it would be good to provide the library with a way to define the format for the barcode output. This could also be used as the default in the patron card creator. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 [Bug 26777] Give the user the option to display their patron card barcode from the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:40:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:40:12 +0000 Subject: [Koha-bugs] [Bug 26777] Give the user the option to display their patron card barcode from the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27825 [Bug 27825] Add preference for choosing the default format for patron barcodes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:40:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:40:12 +0000 Subject: [Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27825 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:46:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:46:30 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:46:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:46:33 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114405|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:46:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:46:37 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:47:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:47:22 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:47:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:47:27 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 117462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117462&action=edit Bug 24359: Add test Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:47:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:47:31 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 117463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117463&action=edit Bug 24359: Remove hold from holds queue when captured This patch removes a hold from holds queue when captured by check in. To test: 1. check out an item from a book with multiple items for patron_1 2. place a biblio level hold for patron_2 3. perl misc/cronjobs/holds/build_holds_queue.pl CHECK => holds queue shows the placed hold 4. check in the item from step 1 and confirm hold for patron_2 SUCCESS => hold for patron_2 is no longer in holds queue 5. prove t/db_dependent/HoldsQueue.t Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:47:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:47:36 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 117464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117464&action=edit Bug 24359: (QA follow-up) Fix tests This patch fixes a rebase issue, and also makes sure the tests do not rely on any prior data. The query on tmp_holdsqueue is done against the actual reserve_id so no need to delete all the data from the tmp_holdsqueue and hold_fill_targets table. I also noticed the previous subtest wasn't run inside a transaction even if the code was designed to not depend on prior data as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/HoldsQueue.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:49:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:49:21 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 --- Comment #13 from Tomás Cohen Arazi --- I fixed a rebase issue. I also made the tests not reset the used tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:49:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:49:31 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 [Bug 27068] HoldsQueue doesn't know how to use holds groups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:49:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:49:31 +0000 Subject: [Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24359 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 [Bug 24359] Remove items from Holds Queue when checked in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:51:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:51:01 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 19:51:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 18:51:18 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 20:16:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 19:16:42 +0000 Subject: [Koha-bugs] [Bug 27798] Independent branches should have a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27798 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 20:23:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 19:23:52 +0000 Subject: [Koha-bugs] [Bug 27592] Link audio alerts to corresponding preference and back In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27592 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 20:27:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 19:27:24 +0000 Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 20:29:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 19:29:03 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 20:49:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 19:49:50 +0000 Subject: [Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #1 from Tomás Cohen Arazi --- Ok, on doing this, I discovered the versions of the JSON::Validator we use don't handle array type of headers, so I will need to make the header a string instead of an array with collectionFormat: csv as we want. Will keep poking at upgrading the dependency and making better use of the capabilities (coercing the header into an array, for example). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 23:30:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 22:30:15 +0000 Subject: [Koha-bugs] [Bug 27826] New: Self checkout dies on '?' as a barcode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27826 Bug ID: 27826 Summary: Self checkout dies on '?' as a barcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Assign an item '?' as a barcode 2 - Check the item out to a patron 3 - Enable and visit the self checkout: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 4 - Try to load the patron with the item issued 5 - Boom! Error below: Template process failed: undef error - Quantifier follows nothing in regex; marked by <-- HERE in m/? <-- HERE / at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/VMethods.pm line 191. at /kohadevbox/koha/C4/Templates.pm line 122 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 23:35:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 22:35:20 +0000 Subject: [Koha-bugs] [Bug 16700] Quick spine label creator: Make css configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16700 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #4 from Barbara Johnson --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 23:56:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 22:56:57 +0000 Subject: [Koha-bugs] [Bug 27798] Independent branches should have a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27798 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 23:57:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 22:57:02 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 23:57:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 22:57:06 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117462|0 |1 is obsolete| | Attachment #117463|0 |1 is obsolete| | Attachment #117464|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 117465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117465&action=edit Bug 24359: Add test Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 23:57:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 22:57:16 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 --- Comment #15 from Kyle M Hall --- Created attachment 117466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117466&action=edit Bug 24359: Remove hold from holds queue when captured This patch removes a hold from holds queue when captured by check in. To test: 1. check out an item from a book with multiple items for patron_1 2. place a biblio level hold for patron_2 3. perl misc/cronjobs/holds/build_holds_queue.pl CHECK => holds queue shows the placed hold 4. check in the item from step 1 and confirm hold for patron_2 SUCCESS => hold for patron_2 is no longer in holds queue 5. prove t/db_dependent/HoldsQueue.t Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 1 23:57:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Mar 2021 22:57:19 +0000 Subject: [Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 --- Comment #16 from Kyle M Hall --- Created attachment 117467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117467&action=edit Bug 24359: (QA follow-up) Fix tests This patch fixes a rebase issue, and also makes sure the tests do not rely on any prior data. The query on tmp_holdsqueue is done against the actual reserve_id so no need to delete all the data from the tmp_holdsqueue and hold_fill_targets table. I also noticed the previous subtest wasn't run inside a transaction even if the code was designed to not depend on prior data as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/HoldsQueue.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 01:18:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 00:18:52 +0000 Subject: [Koha-bugs] [Bug 27765] Set a custom order to library branches on opac-library.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27765 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette Scheer --- This would also be helpful for consortiums as we could group library groups together. It might even be nice to give the option of using a library group as part of the sort/and maybe as a heading for those branches. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 02:46:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 01:46:54 +0000 Subject: [Koha-bugs] [Bug 27803] publicationyear / copyrightdate not included in Holds to Pull In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 02:46:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 01:46:58 +0000 Subject: [Koha-bugs] [Bug 27803] publicationyear / copyrightdate not included in Holds to Pull In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 --- Comment #1 from Aleisha Amohia --- Created attachment 117468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117468&action=edit Bug 27803: Ensure publicationyear or copyrightdate shows in Holds to Pull If marcflavour is set to MARC21, use biblio.copyrightdate. If marcflavour is set to something other than MARC21, use biblioitem.publicationyear. This is to match previous behaviour of this feature. To test: 1) Set your marcflavour system preferenece to MARC21. 2) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblio.copyrightdate. 3) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 4) Edit a biblio, fill in whichever field is mapped to biblio.copyrightdate and Save. 5) Place a hold on this biblio. (It must have an available item to allow placing holds.) 6) Go to Circulation -> Holds to Pull. 7) Confirm your hold shows in the table with the copyrightdate. 8) Set your marcflavour system preference to something other thatn MARC21. 9) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblioitem.publicationyear. 10) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 11) Edit a biblio, fill in whichever field is mapped to biblioitem.publicationyear and Save. 12) Place a hold on this biblio. (It must have an available item to allow placing holds.) 13) Go to Circulation -> Holds to Pull. 14) Confirm your hold shows in the table with the publicationyear. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 02:47:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 01:47:24 +0000 Subject: [Koha-bugs] [Bug 27803] publicationyear / copyrightdate not included in Holds to Pull In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 03:15:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 02:15:31 +0000 Subject: [Koha-bugs] [Bug 27125] Show authority type for UNIMARC in authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 03:15:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 02:15:34 +0000 Subject: [Koha-bugs] [Bug 27125] Show authority type for UNIMARC in authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114072|0 |1 is obsolete| | --- Comment #2 from Andreas Roussos --- Created attachment 117469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117469&action=edit Bug 27125: Show authority type also for UNIMARC in authority search result display Bug 12533 added authority type in authority search result display. But it does not work for UNIMARC, due to : https://git.koha-community.org/Koha-community/Koha/src/commit/be9f64b638335cac7465ca302e187c7914534fbe/C4/AuthoritiesMarc.pm#L798 I propose to use result->{authtype} Test plan : 1) Use UNIMARC catalogue 2) Search for autorities 3) Check you see autority type in column 4) Same for a MARC21 catalogue Signed-off-by: Andreas Roussos I followed the test plan, and the patch works as expected for both UNIMARC and MARC21. There is actually an improvement in the MARC21 case: previously, the 'Authority type' column for records in the Default framework would not display anything, whereas now it displays 'Default'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 04:09:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 03:09:04 +0000 Subject: [Koha-bugs] [Bug 27827] New: The Authority type input field for new authority types should be wider Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Bug ID: 27827 Summary: The Authority type input field for new authority types should be wider Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: a.roussos at dataly.gr QA Contact: testopia at bugs.koha-community.org Created attachment 117470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117470&action=edit The 'Authority type:' input field is too narrow When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents (please see the attached screenshot). This, IMHO, is a nuisance, so I'm choosing a Severity of 'minor' for this bug ("The component mostly works, but causes some irritation to users."). I suggest we increase the 'size' property of the HTML input element from 10 to 20 in order to make it twice as wide (thus allowing even the widest of entries to be displayed in their entirety without any scrolling) while the 'maxlength' property will remain at its current value of 10 since the max. number of characters allowed for an authtype in the database is 10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 04:10:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 03:10:01 +0000 Subject: [Koha-bugs] [Bug 27827] The Authority type input field for new authority types should be wider In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |a.roussos at dataly.gr Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 04:22:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 03:22:10 +0000 Subject: [Koha-bugs] [Bug 27827] The Authority type input field for new authority types should be wider In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 04:22:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 03:22:13 +0000 Subject: [Koha-bugs] [Bug 27827] The Authority type input field for new authority types should be wider In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 --- Comment #1 from Andreas Roussos --- Created attachment 117471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117471&action=edit Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 04:25:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 03:25:24 +0000 Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #28 from David Cook --- (In reply to Jonathan Druart from comment #27) > The short term solution is to package a 4.99+really3.25-koha Why? We should be able to provide the right dependency in the Koha apt repo and specify the right dependency in the control file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 04:28:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 03:28:49 +0000 Subject: [Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 --- Comment #29 from David Cook --- (In reply to Martin Renvoize from comment #26) > > What's easier, backporting new libraries to older Debian (and updating our > codebase for the newer libraries) or downgrading/pinning older libraries on > newer Debian? > I would think probably the latter. > > Or, dare I say it.. shipping a local clone of the Mojo stack inside Koha. I'm not opposed to this. I've started using Carton on other projects, and it's nice having all my Perl dependencies stored in the "local" directory, and then just pointing to that in PERL5LIB. That said, without using the cpanfile.snapshot via Carton, this could get very unmanageable and create many headaches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 05:04:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 04:04:26 +0000 Subject: [Koha-bugs] [Bug 26715] Make Z39.50 modal moveable in the Advanced Cataloging Editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26715 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 05:41:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 04:41:11 +0000 Subject: [Koha-bugs] [Bug 26929] Koha will only display the first 20 macros Advanced Editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 06:37:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 05:37:40 +0000 Subject: [Koha-bugs] [Bug 26606] Correctly URI-encode query string in URL loaded after deleting an authority record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26606 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 08:09:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 07:09:08 +0000 Subject: [Koha-bugs] [Bug 27071] Hold pickup library match not enforced correctly on intranet when using hold groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.04 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #38 from Fridolin Somers --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 08:13:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 07:13:06 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #39 from Fridolin Somers --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 08:49:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 07:49:45 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #13 from Emmi Takkinen --- Created attachment 117472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117472&action=edit Bug 26498: Add POD for "store" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 08:49:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 07:49:52 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 09:16:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 08:16:09 +0000 Subject: [Koha-bugs] [Bug 27803] publicationyear / copyrightdate not included in Holds to Pull In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 09:16:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 08:16:20 +0000 Subject: [Koha-bugs] [Bug 27803] publicationyear / copyrightdate not included in Holds to Pull In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117468|0 |1 is obsolete| | --- Comment #2 from Peter Vashchuk --- Created attachment 117473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117473&action=edit Bug 27803: Ensure publicationyear or copyrightdate shows in Holds to Pull If marcflavour is set to MARC21, use biblio.copyrightdate. If marcflavour is set to something other than MARC21, use biblioitem.publicationyear. This is to match previous behaviour of this feature. To test: 1) Set your marcflavour system preferenece to MARC21. 2) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblio.copyrightdate. 3) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 4) Edit a biblio, fill in whichever field is mapped to biblio.copyrightdate and Save. 5) Place a hold on this biblio. (It must have an available item to allow placing holds.) 6) Go to Circulation -> Holds to Pull. 7) Confirm your hold shows in the table with the copyrightdate. 8) Set your marcflavour system preference to something other thatn MARC21. 9) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblioitem.publicationyear. 10) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 11) Edit a biblio, fill in whichever field is mapped to biblioitem.publicationyear and Save. 12) Place a hold on this biblio. (It must have an available item to allow placing holds.) 13) Go to Circulation -> Holds to Pull. 14) Confirm your hold shows in the table with the publicationyear. Sponsored-by: Catalyst IT Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 09:43:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 08:43:02 +0000 Subject: [Koha-bugs] [Bug 27827] The Authority type input field for new authority types should be wider In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 09:43:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 08:43:05 +0000 Subject: [Koha-bugs] [Bug 27827] The Authority type input field for new authority types should be wider In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117471|0 |1 is obsolete| | --- Comment #2 from Peter Vashchuk --- Created attachment 117474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117474&action=edit Bug 27827: make the 'Authority type:' input field wider When adding a new authority type in the Staff client, the 'Authority type' input field is too narrow. If you enter something like "OOP_CORPUS" inside the textbox, you will have to scroll right and left inside the textbox in order to view its contents. This patch fixes that. Test plan: 1) Try to add a new authority type with name "OOP_CORPUS". Notice how the input field is too narrow and cannot contain the entire string. 2) Apply this patch. 3) Repeat step 1), this time the input field has been widened and can accommodate the entire string. Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 09:43:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 08:43:07 +0000 Subject: [Koha-bugs] [Bug 27820] plugins_nightly.pl script missing use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27820 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m --- Comment #8 from Jonathan Druart --- Please test this carefully. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 09:50:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 08:50:25 +0000 Subject: [Koha-bugs] [Bug 27803] publicationyear / copyrightdate not included in Holds to Pull In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 09:50:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 08:50:27 +0000 Subject: [Koha-bugs] [Bug 27803] publicationyear / copyrightdate not included in Holds to Pull In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117473|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä --- Created attachment 117475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117475&action=edit Bug 27803: Ensure publicationyear or copyrightdate shows in Holds to Pull If marcflavour is set to MARC21, use biblio.copyrightdate. If marcflavour is set to something other than MARC21, use biblioitem.publicationyear. This is to match previous behaviour of this feature. To test: 1) Set your marcflavour system preferenece to MARC21. 2) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblio.copyrightdate. 3) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 4) Edit a biblio, fill in whichever field is mapped to biblio.copyrightdate and Save. 5) Place a hold on this biblio. (It must have an available item to allow placing holds.) 6) Go to Circulation -> Holds to Pull. 7) Confirm your hold shows in the table with the copyrightdate. 8) Set your marcflavour system preference to something other thatn MARC21. 9) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblioitem.publicationyear. 10) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 11) Edit a biblio, fill in whichever field is mapped to biblioitem.publicationyear and Save. 12) Place a hold on this biblio. (It must have an available item to allow placing holds.) 13) Go to Circulation -> Holds to Pull. 14) Confirm your hold shows in the table with the publicationyear. Sponsored-by: Catalyst IT Signed-off-by: Petro Vashchuk Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 09:52:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 08:52:53 +0000 Subject: [Koha-bugs] [Bug 27803] publicationyear / copyrightdate not included in Holds to Pull In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |joonas.kylmala at helsinki.fi |y.org | --- Comment #4 from Joonas Kylmälä --- In the commit message it said to modify biblioitem.publicationyear but at least in my koha the field is biblioitems.publicationyear, probably just a typo. Had to also restart plack after changing marcflavour to get the publicationyear to show in holds to pull. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 09:58:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 08:58:29 +0000 Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #44 from Martin Renvoize --- Created attachment 117476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117476&action=edit Bug 27680: (QA follow-up) Update test for dbic_merge_sorting The order_by handling will now always return an arrayref of ordering hashrefs even when only one ordering hash is present. This is interpreted by dbic as equivilent so I just update the test to pass here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:00:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:00:57 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #32 from Fridolin Somers --- koha-worker will run as root. Shouldn't we run as koha user for package install, as www-data for dev install ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:07:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:07:19 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.04 released in| | --- Comment #33 from Fridolin Somers --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:19:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:19:44 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #50 from Jonathan Druart --- Created attachment 117477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117477&action=edit Bug 8976: Use existing Koha::Authority::Subfield[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:27:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:27:42 +0000 Subject: [Koha-bugs] [Bug 23780] Batch check out fails to inform or trap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org --- Comment #7 from Jonathan Druart --- (In reply to David Nind from comment #6) > I'm not sure how to trigger this when testing. > > Before applying the patch, and if I add an invoice for $50 (which is over > the limit), I get this message on batch check out screen: > > Cannot check out! > Charges: Patron has outstanding charges of 50.00. Checkouts are BLOCKED > because fine balance is OVER THE LIMIT. [Make payment][Pay all fines] > > Patch still applies. You are right, it has been fixed by bug 19382. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:27:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:27:48 +0000 Subject: [Koha-bugs] [Bug 23780] Batch check out fails to inform or trap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:27:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:27:55 +0000 Subject: [Koha-bugs] [Bug 23780] Batch check out fails to inform or trap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94216|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:31:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:31:12 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #51 from Martin Renvoize --- Followup reviewed and tested.. works well for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:37:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:37:12 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #34 from Martin Renvoize --- (In reply to Fridolin Somers from comment #32) > koha-worker will run as root. > Shouldn't we run as koha user for package install, as www-data for dev > install ? Good call.. can't believe I didn't spot that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:38:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:38:39 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #52 from Jonathan Druart --- Created attachment 117478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117478&action=edit Bug 8976: (follow-up) Code cleaning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:39:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:39:51 +0000 Subject: [Koha-bugs] [Bug 27803] publicationyear / copyrightdate not included in Holds to Pull In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:39:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:39:53 +0000 Subject: [Koha-bugs] [Bug 27803] publicationyear / copyrightdate not included in Holds to Pull In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:40:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:40:17 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #53 from Jonathan Druart --- Last 2 patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:40:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:40:30 +0000 Subject: [Koha-bugs] [Bug 27680] API DataTables Wrapper fails for ordering on multi-data-field columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27680 --- Comment #45 from Jonathan Druart --- follow-up pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:40:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:40:40 +0000 Subject: [Koha-bugs] [Bug 27808] Item's onloan column remains unset if a checked out item is issued to another patron without being returned first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27808 --- Comment #23 from Jonathan Druart --- follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:46:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:46:34 +0000 Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:46:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:46:37 +0000 Subject: [Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:47:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:47:32 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Joonas Kylmälä --- Thanks for the patch! I think > $item_hash->{branch} = $branch; Would need to be changed to > $item_hash->{branchcode} = $branch; The delivery location info won't get transmitted otherwise. Can you please also add test for a) delivery place b) Some tests for when AcqCreateItem is different value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:06 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:10 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115135|0 |1 is obsolete| | Attachment #115136|0 |1 is obsolete| | Attachment #115137|0 |1 is obsolete| | Attachment #115138|0 |1 is obsolete| | Attachment #115139|0 |1 is obsolete| | Attachment #115140|0 |1 is obsolete| | Attachment #115141|0 |1 is obsolete| | Attachment #115142|0 |1 is obsolete| | Attachment #115143|0 |1 is obsolete| | Attachment #115144|0 |1 is obsolete| | Attachment #115145|0 |1 is obsolete| | Attachment #115146|0 |1 is obsolete| | Attachment #115218|0 |1 is obsolete| | Attachment #115296|0 |1 is obsolete| | Attachment #115297|0 |1 is obsolete| | Attachment #115298|0 |1 is obsolete| | Attachment #115299|0 |1 is obsolete| | Attachment #116933|0 |1 is obsolete| | Attachment #116934|0 |1 is obsolete| | Attachment #116935|0 |1 is obsolete| | --- Comment #109 from Jonathan Druart --- Created attachment 117479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117479&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:15 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #110 from Jonathan Druart --- Created attachment 117480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117480&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:19 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #111 from Jonathan Druart --- Created attachment 117481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117481&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:24 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #112 from Jonathan Druart --- Created attachment 117482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117482&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:28 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #113 from Jonathan Druart --- Created attachment 117483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117483&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:33 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #114 from Jonathan Druart --- Created attachment 117484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117484&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:37 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #115 from Jonathan Druart --- Created attachment 117485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117485&action=edit Bug 22544: Add tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:41 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #116 from Jonathan Druart --- Created attachment 117486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117486&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:44 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com, | |joonas.kylmala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:45 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #117 from Jonathan Druart --- Created attachment 117487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117487&action=edit Bug 22544: (QA follow-up) Fix spelling Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:49 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #118 from Jonathan Druart --- Created attachment 117488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117488&action=edit Bug 22544: Update to current codebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:54 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #119 from Jonathan Druart --- Created attachment 117489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117489&action=edit Bug 22544: Update search_for_display to be able to take more types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:51:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:51:58 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #120 from Jonathan Druart --- Created attachment 117490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117490&action=edit Bug 22544: Fix filtering by location on tools -> news management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:52:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:52:02 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #121 from Jonathan Druart --- Created attachment 117491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117491&action=edit Bug 22544: Clarify documentation and change param 'type' to 'location' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:52:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:52:07 +0000 Subject: [Koha-bugs] [Bug 25939] Print multiple copies with quick spine label creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25939 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:52:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:52:07 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #122 from Jonathan Druart --- Created attachment 117492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117492&action=edit Bug 22544: Enhance exception description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:52:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:52:11 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #123 from Jonathan Druart --- Created attachment 117493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117493&action=edit Bug 22544: Add default language value to KohaNews template plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:52:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:52:15 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #124 from Jonathan Druart --- Created attachment 117494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117494&action=edit Bug 22544: Use template plugin for news author display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:52:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:52:19 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #125 from Jonathan Druart --- Created attachment 117495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117495&action=edit Bug 22544: TT plugin should return hashref only if news exist It restore the header and fix the RSS feeds (see comment 103) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:52:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:52:23 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #126 from Jonathan Druart --- Created attachment 117496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117496&action=edit Bug 22544: Fix OpacLoginInstructions Moved recently -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:52:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:52:28 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #127 from Jonathan Druart --- Created attachment 117497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117497&action=edit Bug 22544: Restore newdate and timestamp for slip notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 10:52:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 09:52:40 +0000 Subject: [Koha-bugs] [Bug 16629] SpineLabelFormat should be able to use fields/subfields from the record like the other label tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16629 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:03:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:03:56 +0000 Subject: [Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:05:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:05:37 +0000 Subject: [Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 117498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117498&action=edit Bug 27797: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:05:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:05:40 +0000 Subject: [Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 117499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117499&action=edit Bug 27797: Make POST /holds use the stashed koha.overrides Bug 26181 introduced a way to override behavior through a new header, x-koha-override. And bug 27760 introduced a generic approach to handle x-koha-override. This patchset makes the POST /api/v1/holds route rely on this new way of handling x-koha-override instead of doing it manually. The header is added to the spec as a parameter. Note: the header should be defined as: "type": "array", "collectionFormat": "csv", "items": { "type": "string", "enum": [ "any" ] } but the versions of JSON::Validator we use have lots of bugs related to header type coercion, so it just doesn't work. The changelog for JSON::Validator is fairly elocuent about it. The override now takes a list of valid keywords (right now only 'any' but it would be fairly straight-forward to add a fairly granular set of options based on each possible AddReserve failure. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 4. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:10:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:10:05 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Stefan Norinder changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |somesecretemail at mailinator. | |com --- Comment #28 from Stefan Norinder --- After we upgraded Koha to version 20.05.09 we get Internal Server Error when importing a post to a basket. Here's output from the log file: ``` Undefined subroutine &CGI::Compile::ROOT::usr_share_koha_intranet_cgi_2dbin_acqui_neworderempty_2epl::SetMatchedBiblionumber called at /usr/share/koha/intranet/cgi-bin/acqui/neworderempty.pl line 183. ``` Could it be related to the fix for this bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:10:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:10:52 +0000 Subject: [Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 --- Comment #4 from Tomás Cohen Arazi --- If we agree on this patches, I suggest this should be backported down to 20.05 so anyone relying on the feature/behavior change it introduced, doesn't need to change their code when they upgrade. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:24:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:24:16 +0000 Subject: [Koha-bugs] [Bug 27756] background_jobs_worker.pl is memory inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27756 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:24:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:24:19 +0000 Subject: [Koha-bugs] [Bug 27756] background_jobs_worker.pl is memory inefficient In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27756 --- Comment #4 from Jonathan Druart --- Created attachment 117500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117500&action=edit Bug 27756: Fork background jobs to prevent memory leak -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:30:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:30:51 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | CC| |andrew at bywatersolutions.com --- Comment #29 from Jonathan Druart --- The patches are indeed part of 20.05.09. I don't recreate the problem on master however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:33:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:33:24 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 --- Comment #30 from Jonathan Druart --- I do recreate on master! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:35:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:35:10 +0000 Subject: [Koha-bugs] [Bug 27828] New: New order from staged file is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27828 Bug ID: 27828 Summary: New order from staged file is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 24469 Caused by commit 03a9bdc851dcfe114c1676ac55def1e1c5d51970 Bug 24469: Move the new queries to a dedicated ImportBatch subroutine Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_acqui_neworderempty_2epl::SetMatchedBiblionumber called at /kohadevbox/koha/acqui/neworderempty.pl line 183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 [Bug 24469] Record biblionumber in import_biblio when adding to basket via file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:35:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:35:10 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27828 [Bug 27828] New order from staged file is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:36:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:36:26 +0000 Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 --- Comment #31 from Jonathan Druart --- (In reply to Jonathan Druart from comment #30) > I do recreate on master! See bug 27828. (In reply to Jonathan Druart from comment #17) > Doing that is not trivial and will certainly introduce bugs, which I'd like > to avoid. A simple batch seemed better to backport. Indeed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:38:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:38:10 +0000 Subject: [Koha-bugs] [Bug 27828] New order from staged file is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:38:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:38:12 +0000 Subject: [Koha-bugs] [Bug 27828] New order from staged file is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27828 --- Comment #1 from Jonathan Druart --- Created attachment 117501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117501&action=edit Bug 27828: (bug 24469 follow-up) Add missing import Caused by commit 03a9bdc851dcfe114c1676ac55def1e1c5d51970 Bug 24469: Move the new queries to a dedicated ImportBatch subroutine Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_acqui_neworderempty_2epl::SetMatchedBiblionumber called at /kohadevbox/koha/acqui/neworderempty.pl line 183 Test plan: Create a new order from a staged file, select "Add order" next to a title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:39:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:39:53 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 --- Comment #1 from Martin Renvoize --- Created attachment 117502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117502&action=edit Bug 27807: Add multi-column ordering support to datatables wrapper This patch add mutli-column ordering support to the datatables api wrapper. Test plan 1/ Add a series of cities to the system with various combinations of city and state such that you can distinguish sorting on city + state in city ascending + state ascending, city ascending + state descending etc. 2/ Attempt to sort on the two fields in the table (Click the 'City' heading to sort on city name, then Shift Click on 'State' to add 'state' ordering on top.. Shift click again on state to reverse the 'state' ordering but maintain the 'City' ordering. 3/ Confirm the various ordering comes out correctly. 4/ Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:40:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:40:07 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:40:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:40:11 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:40:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:40:25 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:40:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:40:37 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:47:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:47:50 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 --- Comment #2 from Jonathan Druart --- I've applied "Bug 27680: [DO NOT PUSH] Example patch on cities" and I managed to generate queries like: _order_by=+me.name,+me.state,+me.name,+me.city_id or even: _order_by=+me.name,+me.state,+me.name,-me.city_id I know it is not an usual case, and certainly only hypothetical, but maybe we should unique orderArray? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:49:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:49:56 +0000 Subject: [Koha-bugs] [Bug 23232] Enable the option to use the onscreen keyboard on the basic cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:50:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:50:16 +0000 Subject: [Koha-bugs] [Bug 27828] New order from staged file is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27828 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:50:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:50:18 +0000 Subject: [Koha-bugs] [Bug 27828] New order from staged file is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27828 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117501|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 117503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117503&action=edit Bug 27828: (bug 24469 follow-up) Add missing import Caused by commit 03a9bdc851dcfe114c1676ac55def1e1c5d51970 Bug 24469: Move the new queries to a dedicated ImportBatch subroutine Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_acqui_neworderempty_2epl::SetMatchedBiblionumber called at /kohadevbox/koha/acqui/neworderempty.pl line 183 Test plan: Create a new order from a staged file, select "Add order" next to a title Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:50:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:50:39 +0000 Subject: [Koha-bugs] [Bug 22824] Replace YAML::Syck with YAML::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22824 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate, | |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:21 +0000 Subject: [Koha-bugs] [Bug 27829] New: [OMNIBUS] Remove specific LANG installer data Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Bug ID: 27829 Summary: [OMNIBUS] Remove specific LANG installer data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:27 +0000 Subject: [Koha-bugs] [Bug 27619] Remove fr-FR installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 [Bug 27829] [OMNIBUS] Remove specific LANG installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:27 +0000 Subject: [Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27619 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 [Bug 27619] Remove fr-FR installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:30 +0000 Subject: [Koha-bugs] [Bug 27620] Remove fr-CA installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27620 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 [Bug 27829] [OMNIBUS] Remove specific LANG installer data -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:30 +0000 Subject: [Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27620 [Bug 27620] Remove fr-CA installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:31 +0000 Subject: [Koha-bugs] [Bug 27623] Remove pl-PL installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 [Bug 27829] [OMNIBUS] Remove specific LANG installer data -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:31 +0000 Subject: [Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 [Bug 27623] Remove pl-PL installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:33 +0000 Subject: [Koha-bugs] [Bug 27624] Remove ru-RU installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 [Bug 27829] [OMNIBUS] Remove specific LANG installer data -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:33 +0000 Subject: [Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27624 [Bug 27624] Remove ru-RU installer data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:35 +0000 Subject: [Koha-bugs] [Bug 27625] Remove uk-UA installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 [Bug 27829] [OMNIBUS] Remove specific LANG installer data -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:35 +0000 Subject: [Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27625 [Bug 27625] Remove uk-UA installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:36 +0000 Subject: [Koha-bugs] [Bug 27622] Remove nb-NO installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27622 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 [Bug 27829] [OMNIBUS] Remove specific LANG installer data -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:36 +0000 Subject: [Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27622 [Bug 27622] Remove nb-NO installer data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:38 +0000 Subject: [Koha-bugs] [Bug 27621] Remove it-IT installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27621 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 [Bug 27829] [OMNIBUS] Remove specific LANG installer data -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:38 +0000 Subject: [Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27621 [Bug 27621] Remove it-IT installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:40 +0000 Subject: [Koha-bugs] [Bug 24972] Remove de-DE installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24972 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 [Bug 27829] [OMNIBUS] Remove specific LANG installer data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:40 +0000 Subject: [Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24972 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24972 [Bug 24972] Remove de-DE installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:56 +0000 Subject: [Koha-bugs] [Bug 27101] Remove fr-CA installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27101 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27829 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 [Bug 27829] [OMNIBUS] Remove specific LANG installer data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:52:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:52:56 +0000 Subject: [Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27101 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27101 [Bug 27101] Remove fr-CA installer data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:53:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:53:13 +0000 Subject: [Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:55:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:55:12 +0000 Subject: [Koha-bugs] [Bug 27830] New: OPAC library list does not use AddressFormat Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Bug ID: 27830 Summary: OPAC library list does not use AddressFormat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org Bug 13388 introduced the page of library info at /cgi-bin/koha/opac-library.pl. As far as I can tell, the address display on this page does not respect the AddressFormat syspref. Specifically, it displays the ZIP code after the city/state, but both the fr and de setting would display it the other way round. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:55:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:55:12 +0000 Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27830 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:55:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:55:49 +0000 Subject: [Koha-bugs] [Bug 27831] New: Object Name Inconsistencies Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27831 Bug ID: 27831 Summary: Object Name Inconsistencies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org During the push of bug 8976 we discovered some inconsistencies in Koha::Object class names which lead to duplication. We need to clarify the situation and move classes around to be consistent. Current situation: Koha::Authority::Subfield(s) Koha::Authority::Tag(s) Koha::Authority::Type(s) Koha::Biblio::Metadata(s) Koha::MarcSubfieldStructure(s) Koha::AuthSubfieldStructure(s) In bug 8976 we made a few suggestions Koha::Framework::Biblio::Subfield(s) Koha::Framework::Authority::Subfield(s) Koha::Framework::Biblio::Tag(s) Koha::Framework::Authority::Tag(s) OR Koha::MARC::Biblio::Subfield(s) Koha::MARC::Authority::Subfield(s) OR Koha::Framework::Subfield::Biblio (inheriting from Koha::Framework::Subfield) Koha::Framework::Subfield::Authority (inheriting from Koha::Framework::Subfield) Thougts? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:56:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:56:20 +0000 Subject: [Koha-bugs] [Bug 27624] Remove ru-RU installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:57:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:57:14 +0000 Subject: [Koha-bugs] [Bug 27624] Remove ru-RU installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #1 from Jonathan Druart --- https://gitlab.com/joubu/Koha/-/tree/bug_27624 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:57:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:57:57 +0000 Subject: [Koha-bugs] [Bug 27831] Object Name Inconsistencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27831 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:58:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:58:47 +0000 Subject: [Koha-bugs] [Bug 27623] Remove pl-PL installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #1 from Jonathan Druart --- https://gitlab.com/joubu/Koha/-/tree/bug_27623 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:58:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:58:50 +0000 Subject: [Koha-bugs] [Bug 27623] Remove pl-PL installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 11:58:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 10:58:59 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 --- Comment #3 from Martin Renvoize --- Good call, I didn't think about the uniqueness challenge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:05:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:05:48 +0000 Subject: [Koha-bugs] [Bug 27829] [OMNIBUS] Remove specific LANG installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 --- Comment #1 from Jonathan Druart --- https://lists.katipo.co.nz/pipermail/koha/2021-March/055870.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:07:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:07:32 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27831 --- Comment #54 from Jonathan Druart --- (In reply to Jonathan Druart from comment #49) > However I found an inconsistency. Those patches introduced > Koha::AuthSubfieldStructure[s], but we already had > Koha::Authority::Subfield[s]. > It also introduced Koha::MarcSubfieldStructure[s]. > > What about: > Koha::Framework::Biblio::Subfield[s] > Koha::Framework::Authority::Subfield[s] > > Then later: > Koha::Framework::Biblio::Tag[s] > Koha::Framework::Authority::Tag[s] > > Or... Koha::MARC::Biblio::Subfield? Koha::MARCStructure::Biblio::Subfield? > > Or... Koha::Framework::Subfield::Biblio and > Koha::FrameworkSubfield::Authority that would inherit from > Koha::Framework::Subfield. But then we need to drop the plural forms. See bug 27831 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27831 [Bug 27831] Object Name Inconsistencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:07:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:07:32 +0000 Subject: [Koha-bugs] [Bug 27831] Object Name Inconsistencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27831 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8976 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 [Bug 8976] Default sequence of subfields in cataloguing editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:13:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:13:20 +0000 Subject: [Koha-bugs] [Bug 27778] Prevent tables overflowing their containers on patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12850 |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12850 [Bug 12850] C4::Serials::GetLateIssues is not used https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:13:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:13:20 +0000 Subject: [Koha-bugs] [Bug 12850] C4::Serials::GetLateIssues is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27778 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27778 [Bug 27778] Prevent tables overflowing their containers on patron accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:13:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:13:20 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27778 [Bug 27778] Prevent tables overflowing their containers on patron accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:21:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:21:19 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 --- Comment #4 from Martin Renvoize --- Created attachment 117504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117504&action=edit Bug 27807: (QA follow-up) Unique values only This patch filters the final _order_by clause such that we only have unique data fields present and we take the first occurence of a field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:21:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:21:20 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #35 from Fridolin Somers --- (In reply to Martin Renvoize from comment #34) > (In reply to Fridolin Somers from comment #32) > > koha-worker will run as root. > > Shouldn't we run as koha user for package install, as www-data for dev > > install ? > > Good call.. can't believe I didn't spot that! I added to koha-worker.service : [Service] User=www-data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:22:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:22:21 +0000 Subject: [Koha-bugs] [Bug 27813] Purchase suggestions should sort by suggesteddate rather than title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Depends on| |16784 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #1 from Jonathan Druart --- Caused by: commit fb526fb155143a62ea24a8433f58c1c79c1a0179 Bug 16784: Add table configuration on suggestions table Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784 [Bug 16784] Add table configuration for the suggestions table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:22:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:22:21 +0000 Subject: [Koha-bugs] [Bug 16784] Add table configuration for the suggestions table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27813 [Bug 27813] Purchase suggestions should sort by suggesteddate rather than title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:22:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:22:48 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:24:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:24:27 +0000 Subject: [Koha-bugs] [Bug 27813] Purchase suggestions should sort by suggesteddate rather than title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:24:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:24:30 +0000 Subject: [Koha-bugs] [Bug 27813] Purchase suggestions should sort by suggesteddate rather than title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27813 --- Comment #2 from Jonathan Druart --- Created attachment 117505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117505&action=edit Bug 27813: Restore default order on suggestion list view Prior to 20.05, suggestions on /cgi-bin/koha/suggestion/suggestion.pl sorted by suggesteddate by default. On 20.05 and later, they're sorting by title instead. We should go back to the previous behavior. Test plan: Create some suggestions Edit the suggestions.suggesteddate in the DB List the suggestions and confirm that there are sorted by new suggested date first -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:25:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:25:01 +0000 Subject: [Koha-bugs] [Bug 27813] Purchase suggestions should sort by suggesteddate rather than title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27813 --- Comment #3 from Jonathan Druart --- Andrew, newer first, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:39:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:39:52 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #2) > I've applied "Bug 27680: [DO NOT PUSH] Example patch on cities" and I > managed to generate queries like: > > _order_by=+me.name,+me.state,+me.name,+me.city_id > or even: > _order_by=+me.name,+me.state,+me.name,-me.city_id > > I know it is not an usual case, and certainly only hypothetical, but maybe > we should unique orderArray? Good catch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:52:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:52:58 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117504|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 117506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117506&action=edit Bug 27807: (QA follow-up) Unique values only This patch filters the final _order_by clause such that we only have unique data fields present and we take the first occurence of a field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:54:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:54:50 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 --- Comment #7 from Martin Renvoize --- Updated the patch.. I was pushing an array onto an array.. effectively `[ thing2, [ thing2, thing3] ]` I've updated the patch to perform an array merge to we get a single level array back and thus the unique filtering works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 12:56:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 11:56:03 +0000 Subject: [Koha-bugs] [Bug 20596] Error Zoom 20003 when import authority marc file (koha/tools/manage-marc-import.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:02:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:02:46 +0000 Subject: [Koha-bugs] [Bug 27832] New: Rolling upgrade support Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27832 Bug ID: 27832 Summary: Rolling upgrade support Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: nugged at gmail.com Let's make Koha database upgrades support rolling upgrades to avoid downtime in the service. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:03:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:03:08 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:04:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:04:07 +0000 Subject: [Koha-bugs] [Bug 27832] Rolling upgrade support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27832 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stalkernoid at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:16:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:16:36 +0000 Subject: [Koha-bugs] [Bug 27796] SIP payment types should not be available as refund types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27796 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:23:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:23:43 +0000 Subject: [Koha-bugs] [Bug 27813] Purchase suggestions should sort by suggesteddate rather than title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27813 --- Comment #4 from Andrew Fuerste-Henry --- Oh, sorry, I didn't specify. In 19.11, they sort oldest to newest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:36:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:36:28 +0000 Subject: [Koha-bugs] [Bug 27833] New: Koha::Exceptions::Patron::Attribute::* should have parameters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 Bug ID: 27833 Summary: Koha::Exceptions::Patron::Attribute::* should have parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org When one of them is thrown, they should carry the failing code and value. This way we can provide better feedback on the UI (or the API). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:36:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:36:54 +0000 Subject: [Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |17828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 [Bug 17828] Koha::Patron::Attribute->store should raise an exception if unique_id is being broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:36:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:36:54 +0000 Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute->store should raise an exception if unique_id is being broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27833 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:39:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:39:44 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #25 from Kyle M Hall --- Comment on attachment 117064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117064 Bug 25690: Remove duplicated logic in SIP2 checkouts Review of attachment 117064: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25690&attachment=117064) ----------------------------------------------------------------- ::: C4/SIP/ILS/Transaction/Checkout.pm @@ +53,4 @@ > my $patron = Koha::Patrons->find($self->{patron}->{borrowernumber}); > my $overridden_duedate; # usually passed as undef to AddIssue > $debug and warn "do_checkout borrower: . " . $patron->borrowernumber; > + my ($issuingimpossible, $needsconfirmation) = _can_we_issue($patron, $barcode, 0); Can you explain why this is hard coded to 0 now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:41:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:41:17 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #26 from Kyle M Hall --- Comment on attachment 117374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117374 Bug 25690: (follow-up) Correct grammar in warning messages Review of attachment 117374: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25690&attachment=117374) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt @@ +32,4 @@ > Item is marked waiting at [% branchname | html %] for [% name | html %] ([% borrowernumber | html %]). > [% END %] > [% IF ( transferred ) %] > + Item has an hold and is in transit for [% name | html %] ([% borrowernumber | html %]). I would change "Item has an hold and is in transit" to "Items has been trapped to fill a hold and is in transit", or at least "Item is filling a hold and is in transit". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:41:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:41:23 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:41:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:41:30 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:52:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:52:59 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #27 from Joonas Kylmälä --- (In reply to Kyle M Hall from comment #25) > Comment on attachment 117064 [details] [review] > Bug 25690: Remove duplicated logic in SIP2 checkouts > > Review of attachment 117064 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/SIP/ILS/Transaction/Checkout.pm > @@ +53,4 @@ > > my $patron = Koha::Patrons->find($self->{patron}->{borrowernumber}); > > my $overridden_duedate; # usually passed as undef to AddIssue > > $debug and warn "do_checkout borrower: . " . $patron->borrowernumber; > > + my ($issuingimpossible, $needsconfirmation) = _can_we_issue($patron, $barcode, 0); > > Can you explain why this is hard coded to 0 now? The logic is moved now to > $confirmation eq 'RESERVED' and C4::Context->preference("AllowItemsOnHoldCheckoutSIP") and > $confirmation eq 'RESERVED' and !C4::Context->preference("AllowItemsOnHoldCheckoutSIP") checks. There was never need to do the skipping in the core module. The 0 can be refactored out but I didn't do so here because the patch series got already so long. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 13:57:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 12:57:01 +0000 Subject: [Koha-bugs] [Bug 27828] New order from staged file is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27828 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry --- Good catch! Just noting for anyone reading this bug because they've run into this error, it seems to be working fine if you use the checkboxes and Save button to add titles to your basket rather than clicking that Add Order link. That said, I'd honestly never noticed that Add Order button, so I'm just assuming it does the same thing as checking the box for a title and saving your order that way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:00:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:00:21 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117062|0 |1 is obsolete| | Attachment #117063|0 |1 is obsolete| | Attachment #117064|0 |1 is obsolete| | Attachment #117065|0 |1 is obsolete| | Attachment #117066|0 |1 is obsolete| | Attachment #117067|0 |1 is obsolete| | Attachment #117374|0 |1 is obsolete| | --- Comment #28 from Joonas Kylmälä --- Created attachment 117507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117507&action=edit Bug 25690: Remove double usage of 'Reserved' return value The patch "Bug 19116: Hold not set to waiting after transfer" added a new meaning to 'Reserved' return value of C4::Reserves::CheckReserves function. Let's remove double usage and have separate Transferred return value so we can differentiate between attached and non-attached holds. This will come useful in future refactorings. This patch does no changes to the logic except in the /cgi-bin/koha/circ/branchtransfers.pl and circulation.pl we now give similarly to waiting state notice about hold being transferred. To test: 1) Apply this patch 2) Create a new item level hold so that pickup library is different than where the item is currently. Then return the item so that hold is being attached and transferred. 3) Go to branchtransfers.pl and try to create a new transfer: it should prompt you with message "Item is attached to a hold and being transferred for XXX" and provide you with option to cancel the hold or to ignore the transfer. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:00:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:00:25 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #29 from Joonas Kylmälä --- Created attachment 117508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117508&action=edit Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred Items that are attached to a hold and being transferred (found = T) is final decision and you cannot checkout those to other patrons. To test (if you have applied all patches from bug 25690): 1) prove t/db_dependent/SIP/Transaction.t => passes To test (if you don't have all patches): 1) Create hold and set pickup library to something else where the item is at 2) Return the item and it should confirm the hold and start transfer 3) Apply this patch 4) Try to checkout this item now to some other patron via SIP2 and notice it doesn't allow it 5) Revert this patch 6) Notice you can now checkout somebody else's hold that is being transferred! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:00:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:00:28 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #30 from Joonas Kylmälä --- Created attachment 117509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117509&action=edit Bug 25690: Remove duplicated logic in SIP2 checkouts Because AllowItemsOnHoldCheckoutSIP only affects the checkoutability of non-attached, i.e. RESERVED holds in SIP2 we can therefore use the common code from CanBookBeIssued and ignore only the RESERVED confirmation message case in SIP2 checkout code. This slightly changes the checkout error message given for "In processing" holds that someone other than the holdee tries to checkout. Otherwise there is no logic changes. The message that this changes is "Item is on hold for another patron." vs. now "Item cannot be issued: $confirmation". It is easier to create follow-up patch to properly add INPROCESSING confirmation to CanBookBeIssued and then show correct message based on the CanBookBeIssued return value. To test: 1) Apply all patches from bug 25690 to get latest Transaction.t version 2) prove t/db_dependent/SIP/Transaction.t => passes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:00:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:00:32 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #31 from Joonas Kylmälä --- Created attachment 117510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117510&action=edit Bug 25690: Make CanBookBeIssued return In Processing state as needing confirmation This prevents checking out to a patron an item with hold to someone else in the In Processing state via staff interface. Also the checkout error message via SIP is now a more clearer one: "Item is on hold for another patron." Before it was "Item cannot be issued: $confirmation". Also the branch transfer and batch checkout pages are adapted to this new confirmation message as well. To test: 1) Create bib level hold to an item for patron A 2) Check-in that item via SIP2, now the hold state should be "In processing" 3) Apply patch 4) Try to checkout the item to patron B via staff interface and notice we get now confirmation prompt do we really want to do it because it is in processing. In order to not have to setup SIP2 server, alternatively steps 1) and 2) can be done so that you check-in the item in staff interface and make it Waiting, and then with SQL change it to "In processing": UPDATE reserves SET found = "P" WHERE reserve_id = XXX; UPDATE reserves SET waitingdate = NULL WHERE reserve_id = XX UPDATE reserves SET expirationdate = NULL WHERE reserve_id = XXX; Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:00:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:00:36 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #32 from Joonas Kylmälä --- Created attachment 117511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117511&action=edit Bug 25690: Add SIP2 tests for checking out with holds This should cover whether checking out is allowed for all different hold states: Attached: - Waiting - In processing - Transfer Unattached: - Reserved To test: 1) prove t/db_dependent/SIP/Transaction.t => passes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:00:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:00:39 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #33 from Joonas Kylmälä --- Created attachment 117512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117512&action=edit Bug 25690: (QA follow-up) PROCESSED -> PROCESSING for consistency PROCESSED gave the apearance that the item processing had been completed whereas in reading the code it appears to actually signify that the item is awaiting/in proessing state. This patch updates the variable to be PROCESSING consistently throughout the codebase. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:00:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:00:43 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #34 from Joonas Kylmälä --- Created attachment 117513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117513&action=edit Bug 25690: (follow-up) Correct grammar in warning messages This makes the meaning of the warnings a bit more clear. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:01:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:01:47 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #35 from Joonas Kylmälä --- (In reply to Kyle M Hall from comment #26) > I would change "Item has an hold and is in transit" to "Items has been > trapped to fill a hold and is in transit", or at least "Item is filling a > hold and is in transit". Thanks for the feedback, corrected the message now in the "Bug 25690: (follow-up) Correct grammar in warning messages" patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:03:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:03:45 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #36 from Joonas Kylmälä --- Kyle, btw, you had set the bug to "Doesn't apply status". For me it applied but I noticed: > Using index info to reconstruct a base tree... > M C4/SIP/ILS/Transaction/Checkout.pm > Falling back to patching base and 3-way merge... > Auto-merging C4/SIP/ILS/Transaction/Checkout.pm in the git messages, so maybe it depends on git settings. I attached all the patches now again, so hopefully it works for you now as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:35:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:35:58 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #6 from Timothy Alexis Vass --- Should it be possible to change pick up location for suspended holds? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:45:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:45:34 +0000 Subject: [Koha-bugs] [Bug 27828] New order from staged file is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27828 --- Comment #4 from Jonathan Druart --- (In reply to Andrew Fuerste-Henry from comment #3) > Good catch! Just noting for anyone reading this bug because they've run into > this error, it seems to be working fine if you use the checkboxes and Save > button to add titles to your basket rather than clicking that Add Order link. > That said, I'd honestly never noticed that Add Order button, so I'm just > assuming it does the same thing as checking the box for a title and saving > your order that way. You can only use the link if there is a match, that's the difference between both actions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:58:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:58:27 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:58:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:58:30 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117502|0 |1 is obsolete| | Attachment #117506|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 117514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117514&action=edit Bug 27807: Add multi-column ordering support to datatables wrapper This patch add mutli-column ordering support to the datatables api wrapper. Test plan 1/ Add a series of cities to the system with various combinations of city and state such that you can distinguish sorting on city + state in city ascending + state ascending, city ascending + state descending etc. 2/ Attempt to sort on the two fields in the table (Click the 'City' heading to sort on city name, then Shift Click on 'State' to add 'state' ordering on top.. Shift click again on state to reverse the 'state' ordering but maintain the 'City' ordering. 3/ Confirm the various ordering comes out correctly. 4/ Signoff Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 14:58:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 13:58:34 +0000 Subject: [Koha-bugs] [Bug 27807] API DataTables Wrapper fails for ordered on multiple columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27807 --- Comment #9 from Jonathan Druart --- Created attachment 117515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117515&action=edit Bug 27807: (QA follow-up) Unique values only This patch filters the final _order_by clause such that we only have unique data fields present and we take the first occurence of a field. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:06:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:06:25 +0000 Subject: [Koha-bugs] [Bug 27834] New: CircControl syspref is used wrong in TooMany function C4::Circulation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27834 Bug ID: 27834 Summary: CircControl syspref is used wrong in TooMany function C4::Circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The CircControl syspref description says > Use the checkout and fines rules of > PickupLibrary: the library you are logged in at. > PatronLibrary: the library the patron is from. > ItemHomeLibrary: the library the item is from. This is mostly true but there is one exception in the TooMany function where it actually doesn't just change which libraries rules are used but how the the calculation is performed. With PatronLibrary set the behaviour is as expected by reading the syspref description. However with the setting PickupLibrary the behaviour changes now, instead of just using the rules of the pickup library we also only take into account the loans in the pickup library when calculating whether we are over the checkout limit or not. The same happens with ItemHomeLibrary where we instead calculate the patron's checkouts in the home library of the item being checked out. We should really try to fix this either by a) showing that ItemHomeLibrary and PickupLibrary is unacceptable and no one actually wants that, that would allow then making the behaviour similar as what it is to PatronLibrary (so just selecting the right circ rule instead of changing calculation method). b) Provide a new syspref for changing the calcutation method when PickupLibrary or ItemHomeLibrary CircControl values are used, and set it on upgrade enabled as default. Ps. svc/letters/preview might use CirControl wrongly as well, I'm not 100% I didn't quite understand but as for other usages of CircControl syspref I grepped where it was used and it correctly only changed the circ rules to be used instead of changing behaviour. So in addition to TooMany we might have to do some changes to svc/letters/preview if it turns out it changes behaviour as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:06:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:06:25 +0000 Subject: [Koha-bugs] [Bug 24868] When CircControl or ReservesControlBranch are enforced based on item, location limits are enforced per library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24868 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27834 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:06:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:06:25 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27834 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:09:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:09:02 +0000 Subject: [Koha-bugs] [Bug 27824] Report batch operations break with space in placeholder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27824 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- What does not work exactly? I copy/pasted the query to create a new SQL report, I run it and see the table result with the 4 headers: itemnumber, Exemplarnummber, itemnumber for batch, itemnumber as edit link -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:10:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:10:33 +0000 Subject: [Koha-bugs] [Bug 27834] CircControl syspref is used wrong in TooMany function C4::Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27834 --- Comment #1 from Joonas Kylmälä --- IMHO, easiest way would be to go with option b): b) Provide a new syspref for changing the calcutation method when PickupLibrary or ItemHomeLibrary CircControl values are used, and set it on upgrade enabled as default. We might miss some corner case even if we deem option a) safe and so if this new syspref introduced by option b) turns out unused for all users then we can very easily remove it in future and revert it if a corner case comes there. With option a) reverting is not as simple. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:10:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:10:56 +0000 Subject: [Koha-bugs] [Bug 27834] CircControl syspref is used wrong in TooMany function C4::Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27834 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:11:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:11:51 +0000 Subject: [Koha-bugs] [Bug 27822] Wrong systempreference for AddressFormat in 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Which exact version of 20.11? It works for me on the latest (20.11.03). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:13:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:13:21 +0000 Subject: [Koha-bugs] [Bug 24868] When CircControl or ReservesControlBranch are enforced based on item, location limits are enforced per library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24868 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #6 from Joonas Kylmälä --- Hi, (In reply to Andrew Fuerste-Henry from comment #0) > This same logic applies to other parts of the circ and fine rules that are > enforcing counts - holds per day, current checkouts allowed, total current > checkouts allowed, maximum holds allowed, etc. The current checkouts allowed part seems to be actually due to a bug, please see bug 27834 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:13:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:13:31 +0000 Subject: [Koha-bugs] [Bug 27822] Wrong systempreference for AddressFormat in 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 --- Comment #2 from Jonathan Druart --- Right, scratch the last comment. How did you end up with "US" instead of "us"? It looks ok in the installer data (installer/data/mysql/mandatory/sysprefs.sql): 13 ('AddressFormat','us','us|de|fr','Choose format to display postal addresses', 'Choice'), -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:14:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:14:16 +0000 Subject: [Koha-bugs] [Bug 27822] Wrong systempreference for AddressFormat in 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 --- Comment #3 from verolencinas --- I had this problem updating 19.11 to 20.11.03. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:18:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:18:30 +0000 Subject: [Koha-bugs] [Bug 27822] Wrong systempreference for AddressFormat in 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 verolencinas changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from verolencinas --- My sysprefs.sql is ok. I'm closing this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:19:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:19:27 +0000 Subject: [Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 117516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117516&action=edit Bug 27833: Make Koha::Exceptions::Patron::Attribute::* have parameters This patch adds a 'field' to this exceptions. They now have an 'attribute' parameter referencing the object itself, To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! 3. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:19:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:19:30 +0000 Subject: [Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 117517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117517&action=edit Bug 27833: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:19:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:19:33 +0000 Subject: [Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 117518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117518&action=edit Bug 27833: Make K::P::Attribute add the object to the exception This patch makes the 'check_unique_id' and '_check_repeatable' methods pass the 'attribute' parameter when throwing an exception. This way we can provid emore meaningfull error messages. To test: 1. Apply the previous patches 2. Run $ kshell k$ prove t/db_dependent/Koha/Patron/Attributes.t => FAIL: The exceptions are not passed the attribute! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:19:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:19:57 +0000 Subject: [Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:23:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:23:47 +0000 Subject: [Koha-bugs] [Bug 27822] Wrong systempreference for AddressFormat in 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 verolencinas changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #5 from verolencinas --- The "US" in AddressFormat is in installer/data/mysql/localization/es-ES/custom.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:28:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:28:20 +0000 Subject: [Koha-bugs] [Bug 27835] New: Closed days offsets with one day Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27835 Bug ID: 27835 Summary: Closed days offsets with one day Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: somesecretemail at mailinator.com QA Contact: testopia at bugs.koha-community.org We have configured our calendar to have closed days on Saturdays and Sundays but the fines job executes on Saturdays, but not on Mondays. It seems like it offsets incorrectly with one day. I think the problem started after updating to Koha version 20.05.09. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:28:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:28:46 +0000 Subject: [Koha-bugs] [Bug 23666] Add API route for additional patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27833 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:28:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:28:46 +0000 Subject: [Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 [Bug 23666] Add API route for additional patron attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:33:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:33:56 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:34:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:34:00 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117507|0 |1 is obsolete| | Attachment #117508|0 |1 is obsolete| | Attachment #117509|0 |1 is obsolete| | Attachment #117510|0 |1 is obsolete| | Attachment #117511|0 |1 is obsolete| | Attachment #117512|0 |1 is obsolete| | Attachment #117513|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall --- Created attachment 117519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117519&action=edit Bug 25690: Remove double usage of 'Reserved' return value The patch "Bug 19116: Hold not set to waiting after transfer" added a new meaning to 'Reserved' return value of C4::Reserves::CheckReserves function. Let's remove double usage and have separate Transferred return value so we can differentiate between attached and non-attached holds. This will come useful in future refactorings. This patch does no changes to the logic except in the /cgi-bin/koha/circ/branchtransfers.pl and circulation.pl we now give similarly to waiting state notice about hold being transferred. To test: 1) Apply this patch 2) Create a new item level hold so that pickup library is different than where the item is currently. Then return the item so that hold is being attached and transferred. 3) Go to branchtransfers.pl and try to create a new transfer: it should prompt you with message "Item is attached to a hold and being transferred for XXX" and provide you with option to cancel the hold or to ignore the transfer. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:34:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:34:14 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #38 from Kyle M Hall --- Created attachment 117520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117520&action=edit Bug 25690: SIP2: Don't allow checking out attached hold that is being transferred Items that are attached to a hold and being transferred (found = T) is final decision and you cannot checkout those to other patrons. To test (if you have applied all patches from bug 25690): 1) prove t/db_dependent/SIP/Transaction.t => passes To test (if you don't have all patches): 1) Create hold and set pickup library to something else where the item is at 2) Return the item and it should confirm the hold and start transfer 3) Apply this patch 4) Try to checkout this item now to some other patron via SIP2 and notice it doesn't allow it 5) Revert this patch 6) Notice you can now checkout somebody else's hold that is being transferred! Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:34:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:34:17 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #39 from Kyle M Hall --- Created attachment 117521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117521&action=edit Bug 25690: Remove duplicated logic in SIP2 checkouts Because AllowItemsOnHoldCheckoutSIP only affects the checkoutability of non-attached, i.e. RESERVED holds in SIP2 we can therefore use the common code from CanBookBeIssued and ignore only the RESERVED confirmation message case in SIP2 checkout code. This slightly changes the checkout error message given for "In processing" holds that someone other than the holdee tries to checkout. Otherwise there is no logic changes. The message that this changes is "Item is on hold for another patron." vs. now "Item cannot be issued: $confirmation". It is easier to create follow-up patch to properly add INPROCESSING confirmation to CanBookBeIssued and then show correct message based on the CanBookBeIssued return value. To test: 1) Apply all patches from bug 25690 to get latest Transaction.t version 2) prove t/db_dependent/SIP/Transaction.t => passes Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:34:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:34:21 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #40 from Kyle M Hall --- Created attachment 117522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117522&action=edit Bug 25690: Make CanBookBeIssued return In Processing state as needing confirmation This prevents checking out to a patron an item with hold to someone else in the In Processing state via staff interface. Also the checkout error message via SIP is now a more clearer one: "Item is on hold for another patron." Before it was "Item cannot be issued: $confirmation". Also the branch transfer and batch checkout pages are adapted to this new confirmation message as well. To test: 1) Create bib level hold to an item for patron A 2) Check-in that item via SIP2, now the hold state should be "In processing" 3) Apply patch 4) Try to checkout the item to patron B via staff interface and notice we get now confirmation prompt do we really want to do it because it is in processing. In order to not have to setup SIP2 server, alternatively steps 1) and 2) can be done so that you check-in the item in staff interface and make it Waiting, and then with SQL change it to "In processing": UPDATE reserves SET found = "P" WHERE reserve_id = XXX; UPDATE reserves SET waitingdate = NULL WHERE reserve_id = XX UPDATE reserves SET expirationdate = NULL WHERE reserve_id = XXX; Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:34:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:34:25 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #41 from Kyle M Hall --- Created attachment 117523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117523&action=edit Bug 25690: Add SIP2 tests for checking out with holds This should cover whether checking out is allowed for all different hold states: Attached: - Waiting - In processing - Transfer Unattached: - Reserved To test: 1) prove t/db_dependent/SIP/Transaction.t => passes Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:34:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:34:28 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #42 from Kyle M Hall --- Created attachment 117524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117524&action=edit Bug 25690: (QA follow-up) PROCESSED -> PROCESSING for consistency PROCESSED gave the apearance that the item processing had been completed whereas in reading the code it appears to actually signify that the item is awaiting/in proessing state. This patch updates the variable to be PROCESSING consistently throughout the codebase. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:34:32 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #43 from Kyle M Hall --- Created attachment 117525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117525&action=edit Bug 25690: (follow-up) Correct grammar in warning messages This makes the meaning of the warnings a bit more clear. Signed-off-by: Joonas Kylmälä Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:58:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:58:41 +0000 Subject: [Koha-bugs] [Bug 24491] Add filters to debit types interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24491 --- Comment #1 from Martin Renvoize --- Created attachment 117526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117526&action=edit Bug 24491: Add optional filtering to debit types This patch adds a pair of additional checkbox filtering options to the debit types page so that you can filter down to just those type that are available for sale or available for invoicing, or available for both. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 15:59:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 14:59:34 +0000 Subject: [Koha-bugs] [Bug 24491] Add filters to debit types interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24491 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:01:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:01:15 +0000 Subject: [Koha-bugs] [Bug 24491] Add filters to debit types interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24491 --- Comment #2 from Martin Renvoize --- Looking for feedback on the UX here.. the implementation certainly isn't perfect. In the medium turn I'd like to convert the table to being api driven and use Jonathans patches for static links for table states. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:01:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:01:27 +0000 Subject: [Koha-bugs] [Bug 24491] Add filters to debit types interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24491 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:02:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:02:53 +0000 Subject: [Koha-bugs] [Bug 27836] New: Document that CircControl syspref changes which library's calendar to use Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27836 Bug ID: 27836 Summary: Document that CircControl syspref changes which library's calendar to use Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently CircControl syspref changes also which library's calendar to use when calculating opening days for example for fines. This should be documented in the syspref (now it is not). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:09:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:09:51 +0000 Subject: [Koha-bugs] [Bug 27822] Wrong systempreference for AddressFormat in 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:09:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:09:54 +0000 Subject: [Koha-bugs] [Bug 27822] Wrong systempreference for AddressFormat in 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 --- Comment #6 from Jonathan Druart --- Created attachment 117527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117527&action=edit Bug 27822: Fix default value for AddressFormat (es-ES) It must be "us" not "US" otherwise you get Template process failed: file error - member-main-address-style-US: not found at /usr/share/koha/lib/C4/Templates.pm line 122" because the system expects "us", not "US". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:10:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:10:23 +0000 Subject: [Koha-bugs] [Bug 27822] Wrong systempreference for AddressFormat in 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Version|20.11 |master Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Depends on| |24973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 [Bug 24973] Allow to localize and translate system preferences with new yaml based installer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:10:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:10:23 +0000 Subject: [Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 [Bug 27822] Wrong systempreference for AddressFormat in 20.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:11:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:11:06 +0000 Subject: [Koha-bugs] [Bug 27822] Wrong systempreference for AddressFormat in 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 --- Comment #7 from Jonathan Druart --- Indeed, thanks! A workaround is to, using the UI, save it to another value than "us", then back to "us". It should be set to "us" in DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:11:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:11:22 +0000 Subject: [Koha-bugs] [Bug 27822] Wrong systempreference for AddressFormat (es-ES) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong systempreference for |Wrong systempreference for |AddressFormat in 20.11 |AddressFormat (es-ES) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:13:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:13:54 +0000 Subject: [Koha-bugs] [Bug 27836] Document that CircControl syspref changes which library's calendar to use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27836 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:13:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:13:57 +0000 Subject: [Koha-bugs] [Bug 27836] Document that CircControl syspref changes which library's calendar to use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27836 --- Comment #1 from Joonas Kylmälä --- Created attachment 117528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117528&action=edit Bug 27836: Document that CirControl changes which calendar is being used You can verify that which branch's Koha calendar is being used to calculate fines by reading for example the code in C4::Circulation::_CalculateAndUpdateFine() There you can see that $control_branchcode variable is being passed to C4::Overdues::CalcFine() and if you trace that you will see in the end it decides which branch's calendar to use for calculating chargeable overdue fine days. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:37:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:37:58 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #36 from Fridolin Somers --- Also maybe needs Type=forking ? https://www.freedesktop.org/software/systemd/man/systemd.service.html#Type= -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:39:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:39:16 +0000 Subject: [Koha-bugs] [Bug 27826] Self checkout dies on '?' as a barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27826 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |19458 --- Comment #1 from Jonathan Druart --- Caused by commit fff6777b35195dca489726875039c2bde6b52c2c Bug 19458: Self-check module highlighting Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19458 [Bug 19458] Self-check module highlighting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:39:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:39:16 +0000 Subject: [Koha-bugs] [Bug 19458] Self-check module highlighting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19458 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27826 [Bug 27826] Self checkout dies on '?' as a barcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:44:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:44:32 +0000 Subject: [Koha-bugs] [Bug 27789] Missing translate text replacement in admin-home.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- You should remove the "fuzzy" from the .po file. Maybe the string needs to be adjusted on pootle? Did you check translate.koha-community.org/projects? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:44:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:44:49 +0000 Subject: [Koha-bugs] [Bug 27789] Missing translate text replacement in admin-home.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:49:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:49:38 +0000 Subject: [Koha-bugs] [Bug 27767] Batch delete from cart doesn't change the number of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27767 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Also true if you remove a record from the detail page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:54:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:54:47 +0000 Subject: [Koha-bugs] [Bug 27837] New: Permanent location is reverted to location when location updated and permanent_location mapped to MARC field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Bug ID: 27837 Summary: Permanent location is reverted to location when location updated and permanent_location mapped to MARC field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Generally the permanent_location and location should match, however, prior to bug 23463 one could: 1 - Map permanent_location to a marc field 2 - Expose that field in the item editor 3 - Change the location of the item and retain the permanent location on saving 4 - This created a 'temporary' location that was cleared upon next checkin Many libraries used this for adding items to displays. Since bug 23463, however, the item updates only fields that have changed - if one changes the location but not the permanent location then koha sees that no permanent location was set and reverts it to the location We need to force passing through the permanent_location if it is visible+mapped in the item edit form, regardless of whether it changes or not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:55:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:55:06 +0000 Subject: [Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23463 Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 16:55:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 15:55:06 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:01:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:01:56 +0000 Subject: [Koha-bugs] [Bug 27838] New: See also authorities not copied Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27838 Bug ID: 27838 Summary: See also authorities not copied Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl At koha 20.11.03 thre is an issue when try to add a see also authority, it onlye copies rlink, doesn't copy $a autority. Test plan: a) Search for a geographic authority (it doesn't matter which one, topic, personall...etc) b) Go to 551 (if geographic) look for an authority and select it to link it to youe record c) it just copy the rlin it doesn't copy 151$a Tested with 20.11 fresh install it work with 20.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:27:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:27:35 +0000 Subject: [Koha-bugs] [Bug 27838] See also authorities not copied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22399 CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |oleonard at myacpl.org Severity|enhancement |major Version|20.11 |master --- Comment #1 from Jonathan Druart --- Owen, I think this has been caused by commit 579608808c4ec81f469e4c48627525d17a16194d Bug 22399: Improve responsive behavior of the basic marc editor Can you have a look please? More precisely: 56 function SetSubfieldNumber(subfield_name, nb) { And I bet the culprit is: 52 var field_start = whichfield.parentNode.parentNode.parentNode.parentNode; Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:27:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:27:35 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27838 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27838 [Bug 27838] See also authorities not copied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:39:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:39:51 +0000 Subject: [Koha-bugs] [Bug 27467] Provide a static URL for tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27467 --- Comment #14 from Martin Renvoize --- Right.. so solution 3 is the one that works.. we should drop solutions 1 and 2 to clarify what people should be testing. Silly question.. why drop the base64 encode/decode? I find that string a less ugly than the URL encoded set or state params myself.. So.. what's waiting to happen here to push this from 'In discussion' into 'Needs signoff' ?.. is it the addition of a 'Share' button? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:41:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:41:45 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #227 from Martin Renvoize --- What's the current status of this one..? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:50:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:50:11 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114809|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 117529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117529&action=edit Bug 25674: Add placeholders for RabbitMQ configuration Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:50:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:50:14 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114810|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 117530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117530&action=edit Bug 25674: Adapt koha-create This patch adds the following option switches to koha-create: --mb-host --mb-port --mb-user --mb-pass --mb-vhost They are used to override the default values on instance creation. To test: 1. Play with the several option switches and verify that the resulting koha-conf.xml contains the expected data. => SUCCESS: It works as expected 2. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:50:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:50:17 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114811|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 117531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117531&action=edit Bug 25674: Add documentation Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:50:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:50:20 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115005|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 117532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117532&action=edit Bug 25674: Remove default vhost Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:50:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:50:59 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114288|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 117533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117533&action=edit Bug 26742: Add configuration to koha-conf.xml for message broker The connection details for the message broker should be configurable. This patch adds configuration options to koha-conf.xml. If they are not specified, then default connection details will be used. Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:51:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:51:03 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114372|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 117534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117534&action=edit Bug 26742: Remove die from connect The change was not advertised and it needs to be done on a separate bug report (+ test coverage) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:51:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:51:23 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #20 from Martin Renvoize --- All works as expected, thanks.. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:52:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:52:12 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117408|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes --- Created attachment 117535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117535&action=edit Bug 26247: Make retaining search terms in staff client optional This patch adds a new system preference 'StaffRetainSearchTerms' - if enabled header searches will be retained on the results page as current behvaiour. If disabled the search box will be empty after searching To test: 1 - Search in staff client from header 2 - Confirm search terms are retained 3 - Apply patch, update database 4 - Search again, terms still retained 5 - Disable StaffRetainSearchTerms preference 6 - Search again 7 - Search box is cleared Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:52:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:52:14 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #21 from Martin Renvoize --- Tested this as part of testing bug 25674.. so adding my additional signoff line :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:52:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:52:14 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117409|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes --- Created attachment 117536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117536&action=edit Bug 26247: Consolidate search box code This cleans up the various search bar templates to use a single template for the 'Search the catalog box' To test: 1 - Apply patch 2 - Confirm the 'Search the catalog' appears and works from modules: Budgets Cataloging Circulation Currencies Contracts Home page Notices and slips Patrons Administration Serials Acquisitions -> suggestions Z3950 Admin Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:52:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:52:17 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117410|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes --- Created attachment 117537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117537&action=edit Bug 26247: Only copy header inputs if marked sticky This alters the 'keep_text' function to require 'head-searchbox' elements to be marked with class 'sticky' ti have values carry over There have been complaints about the stickiness of retained search terms, this patch attempts to mitigate that while preserving stickiness for other searches To test: 1 - Enable 'StaffRetainSearchTerms' (or don't apply previous patches) 2 - Search in staff client from header 3 - Search term is retained in the search box 4 - Click abother tab like 'checkin' 5 - Search term is copied to new tab 6 - Apply patch 7 - Reload the page 8 - Search in header 9 - Search term still retained 10 - Click on another header tab 11 - Search term is not copied Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:52:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:52:20 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117411|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes --- Created attachment 117538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117538&action=edit Bug 26247: Make search terms optionally sticky This patch adds a configurable option for retaining stickiness of search terms across search tabs To test: 1 - Apply all patches except this one, enable StaffRetainSearchTerms 2 - Search in staff client from header 3 - Confirm behaviour is that term is retained, but not copied when switching header search tab 4 - Apply this patch, updatedatabase 5 - Search again 6 - Previous behaviour is restored, search terms are sticky between tabs 7 - Disable preference StaffStickySearchTerms 8 - Search again 9 - Search terms retained, but not sticky Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:52:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:52:22 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117461|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes --- Created attachment 117539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117539&action=edit Bug 26247: Atomic update Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:55:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:55:01 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #21 from Martin Renvoize --- With bug 26363 adding a systemd unit file.. it raises the question of should this patch also do something for that.. Fridolin quite rightly raised questions about what user the unit worker should be running under. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:59:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:59:28 +0000 Subject: [Koha-bugs] [Bug 15509] Allow item level descriptions to Quick spine label creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15509 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 17:59:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 16:59:47 +0000 Subject: [Koha-bugs] [Bug 16700] Quick spine label creator: Make css configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16700 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:01:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:01:20 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:06:18 +0000 Subject: [Koha-bugs] [Bug 27825] Add preference for choosing the default format for patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27825 --- Comment #1 from Martin Renvoize --- Seems like a reasonable idea to me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:14:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:14:19 +0000 Subject: [Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117498|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 117540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117540&action=edit Bug 27797: Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:14:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:14:22 +0000 Subject: [Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117499|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 117541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117541&action=edit Bug 27797: Make POST /holds use the stashed koha.overrides Bug 26181 introduced a way to override behavior through a new header, x-koha-override. And bug 27760 introduced a generic approach to handle x-koha-override. This patchset makes the POST /api/v1/holds route rely on this new way of handling x-koha-override instead of doing it manually. The header is added to the spec as a parameter. Note: the header should be defined as: "type": "array", "collectionFormat": "csv", "items": { "type": "string", "enum": [ "any" ] } but the versions of JSON::Validator we use have lots of bugs related to header type coercion, so it just doesn't work. The changelog for JSON::Validator is fairly elocuent about it. The override now takes a list of valid keywords (right now only 'any' but it would be fairly straight-forward to add a fairly granular set of options based on each possible AddReserve failure. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 4. Sign off! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:15:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:15:01 +0000 Subject: [Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- Works well, tests pass, the feature works. Signing off, thanks for doing this Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:15:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:15:15 +0000 Subject: [Koha-bugs] [Bug 27797] Make POST /holds use the stashed koha.overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27797 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:17:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:17:43 +0000 Subject: [Koha-bugs] [Bug 27838] See also authorities not copied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27838 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:20:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:20:01 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #12 from Sally --- The functions all work as described - the two system preferences are: StaffRetainSearchTerms: Retain / Don't retain StaffStickySearchItems: Copy / Don't copy Settings: Retain + Copy Result: Current behaviour as on master Settings: Don't retain + Copy Result: Previous behaviour before Bug 19046 Settings: Retain + Don't Copy Settings: Don't retain + Don't copy Result: As stated Speaking as a user, I think this feature is an either/or scenario, which is a shame. The way I would like to use it might be impossible to code, but worth asking, I suppose! Users want search terms to persist for the following scenario: - search for 'Roald Dahl' - return 6000 results, realise you want to search for 'Roald Dahl BFG' - search isn't retained, so you have to write the whole term again - but if the search is retained, you just have to add 'BFG' to the end Users don't want the search terms copied across to other fields (i.e. check out), as described by Lucas. But if you set: Retain + Don't copy, although this is really close to what's needed, it re-introduces the problem that copying was designed to fix: - type a catalog search into the bar whilst you're on the wrong tab (e.g. check out) - realise and move tab to search the catalog - now the search is empty again so the term needs to be rewritten, although it persisted in the other tabs It feels to me that the problem is that copying should only go in one direction - from left to right on the screen, so content written in check out could be moved into search the catalog, but content written in search the catalog tabs can't be moved into check out This would give the following result: - librarian types search into check out box; librarian can change tab to search catalog and the term is retained - librarian searches the catalog and wants to modify the search; term is retained - librarian searches the catalog, tabs back to check out; term should disappear I realise it might be impossible, but as an end user, that feels like the ultimate goal. I've signed it off because the patches do work as described, and do bring back the old functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:20:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:20:37 +0000 Subject: [Koha-bugs] [Bug 27838] See also authorities not copied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27838 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 27737 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:20:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:20:37 +0000 Subject: [Koha-bugs] [Bug 27737] Tag editor for authority lookup broken in authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #2 from Owen Leonard --- *** Bug 27838 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:21:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:21:12 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:24:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:24:08 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117127|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 117542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117542&action=edit Bug 26498: Set default expiration date for holds Koha doesn't automatically set expiration date for holds so they can live in the system forever. This patch adds new sysprefs to control setting of default expiration date for holds. Note that expiration date is only set if input field for it is left blank. To test: 1. Apply patch and update database. 2. Enable syspref "DefaultHoldExpirationdate" and set some values to "DefaultHoldExpirationdatePeriod" and "DefaultHoldExpirationdateUnitOfTime". 3. Add some holds for patron from staff client or OPAC and leave expiration date input field blank. => Holds expiration date should be set according your settings 4. Disable "DefaultHoldExpirationdate" and repeat step 3. => Expiration date shouldn't be set. Also prove prove t/db_dependent/Hold.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Andrew Isherwood Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:24:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:24:12 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117472|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 117543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117543&action=edit Bug 26498: Add POD for "store" Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:24:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:24:52 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize --- Works well, code reads well, QA scripts are happy and tests make sense and pass.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:30:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:30:46 +0000 Subject: [Koha-bugs] [Bug 27737] Tag editor for authority lookup broken in authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | --- Comment #3 from Owen Leonard --- (In reply to Jonathan Druart from comment #1 on Bug 27838) function SetSubfieldNumber(subfield_name, nb) { > > And I bet the culprit is: > 52 var field_start = > whichfield.parentNode.parentNode.parentNode.parentNode; ...which is exactly what makes that kind of selector so fragile!! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:54:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:54:40 +0000 Subject: [Koha-bugs] [Bug 27737] Tag editor for authority lookup broken in authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 18:54:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 17:54:43 +0000 Subject: [Koha-bugs] [Bug 27737] Tag editor for authority lookup broken in authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737 --- Comment #4 from Owen Leonard --- Created attachment 117544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117544&action=edit Bug 27737: Tag editor for authority lookup broken in authority editor This patch corrects the selector used for targeting the correct fields during an authority linking operation. To test, apply the patch and go to Authorities in the staff client. - Create or edit an authority record. - Switch to tab 5 and if necessary click one of the tag names (e.g. "SEE ALSO FROM TRACING--PERSONAL NAME") to expand the subfields. - Click the "..." plugin link next to subfield a ("Personal name" in this example). - In the popup window, search for an authority record. - Click "Choose" next to one of the results. - The popup window should close and the authority editor should contain data from the record you chose, including a value in $9 and $a. - Test with various records to confirm that data in other fields is copied correctly, for instanct $d, dates associated with a name, $t title of a work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:00:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:00:53 +0000 Subject: [Koha-bugs] [Bug 27794] Add link to biblio in lateorders page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27794 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch modifies the release notes| |display of bibliographic | |records in the acquisitions | |report of late orders so | |that the title of the | |record is a link to the | |corresponding bibliographic | |details page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:09:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:09:22 +0000 Subject: [Koha-bugs] [Bug 27792] Improve jEditable configuration for point of sale fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27792 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch improves release notes| |interactions with | |inline-editable fields in | |the Point of Sale interface | |to prevent jumpy table | |re-draws and to enforce the | |required currenty/number | |input types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:14:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:14:05 +0000 Subject: [Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option for modules in action_logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- +1 on this, libraries want some logs longer than others. Also, some logs are more feasible to keep longer. Granularity would be great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:17:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:17:56 +0000 Subject: [Koha-bugs] [Bug 27839] New: koha-worker missing tab-completion in bash Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839 Bug ID: 27839 Summary: koha-worker missing tab-completion in bash Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz There's no entry for koha-worker in koha-common.bash-completion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:18:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:18:07 +0000 Subject: [Koha-bugs] [Bug 27839] koha-worker missing tab-completion in bash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:18:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:18:12 +0000 Subject: [Koha-bugs] [Bug 27839] koha-worker missing tab-completion in bash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:18:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:18:12 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27839 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839 [Bug 27839] koha-worker missing tab-completion in bash -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:24:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:24:15 +0000 Subject: [Koha-bugs] [Bug 27737] Tag editor for authority lookup broken in authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:24:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:24:18 +0000 Subject: [Koha-bugs] [Bug 27737] Tag editor for authority lookup broken in authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117544|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 117545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117545&action=edit Bug 27737: Tag editor for authority lookup broken in authority editor This patch corrects the selector used for targeting the correct fields during an authority linking operation. To test, apply the patch and go to Authorities in the staff client. - Create or edit an authority record. - Switch to tab 5 and if necessary click one of the tag names (e.g. "SEE ALSO FROM TRACING--PERSONAL NAME") to expand the subfields. - Click the "..." plugin link next to subfield a ("Personal name" in this example). - In the popup window, search for an authority record. - Click "Choose" next to one of the results. - The popup window should close and the authority editor should contain data from the record you chose, including a value in $9 and $a. - Test with various records to confirm that data in other fields is copied correctly, for instanct $d, dates associated with a name, $t title of a work. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:30:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:30:35 +0000 Subject: [Koha-bugs] [Bug 27840] New: option to add restriction for update patron category cron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27840 Bug ID: 27840 Summary: option to add restriction for update patron category cron Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Many libraries use the update patron category cron to update child accounts to adult accounts. However, once the child becomes an adult, libraries need to obtain an updated application from the patron. It would be really helpful to have an option in the cron to be able add a manual restriction with a message to the accounts that are updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:31:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:31:03 +0000 Subject: [Koha-bugs] [Bug 27840] option to add restriction for update patron category cron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27840 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 19:42:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 18:42:45 +0000 Subject: [Koha-bugs] [Bug 27737] Tag editor for authority lookup broken in authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from David Nind --- Sorry Owen, changing to failed QA. I went back and checked to make sure that adding or editing using authority lookup still works for standard MARC editing, such as 100. Before the patch is applied this works. After the patch is applied and when editing a record, you get a "spinning wheel" when you click on the choose button. 8-( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 20:02:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 19:02:41 +0000 Subject: [Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 20:02:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 19:02:44 +0000 Subject: [Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117516|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 117546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117546&action=edit Bug 27833: Make Koha::Exceptions::Patron::Attribute::* have parameters This patch adds a 'field' to this exceptions. They now have an 'attribute' parameter referencing the object itself, To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! 3. Sign off! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 20:02:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 19:02:47 +0000 Subject: [Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117517|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 117547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117547&action=edit Bug 27833: Add unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 20:02:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 19:02:50 +0000 Subject: [Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117518|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 117548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117548&action=edit Bug 27833: Make K::P::Attribute add the object to the exception This patch makes the 'check_unique_id' and '_check_repeatable' methods pass the 'attribute' parameter when throwing an exception. This way we can provid emore meaningfull error messages. To test: 1. Apply the previous patches 2. Run $ kshell k$ prove t/db_dependent/Koha/Patron/Attributes.t => FAIL: The exceptions are not passed the attribute! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 20:21:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 19:21:09 +0000 Subject: [Koha-bugs] [Bug 27841] New: Add unique action types to action logs for holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27841 Bug ID: 27841 Summary: Add unique action types to action logs for holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When a hold's Found value changes to T (for transit) for W (for waiting), the action logs simply record a modification. That makes it very difficult to search the logs specifically for the point at which a hold goes to one of those two statuses. I'd like to see them marked with their own action_logs.action values, though I'm not sure on wording that would be translatable / understandable for all. Maybe just "Transfer" and "Waiting?" Though it bothers me a bit that those aren't verbs and the rest of the action options are. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 20:29:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 19:29:42 +0000 Subject: [Koha-bugs] [Bug 27842] New: Incorrect biblionumber handling in serials subscriptions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842 Bug ID: 27842 Summary: Incorrect biblionumber handling in serials subscriptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It seems that a librarian can edit the biblionumber for a given subscription, however, when receiving serials the biblionumber is pulled from the existing serials, so all new received issues are received on the old biblionumber This is problematic in light of bug 21901 - you can change the biblionumber, the serials still point to the old biblionumber - and deleting the biblio deletes the serials. Additionally, the update will delete serials where this was the case To recreate: 1 - Create a new subscription 2 - Receive an issue 3 - Edit the subscription and change the biblionumber 4 - Receive another issue 5 - SELECT * FROM serial 6 - Both have the old number 7 - Delete the old biblio 8 - The serials are deleted 9 - You also cannot now receive for this issue or generate serials -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 20:36:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 19:36:10 +0000 Subject: [Koha-bugs] [Bug 27839] koha-worker missing tab-completion in bash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 20:36:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 19:36:13 +0000 Subject: [Koha-bugs] [Bug 27839] koha-worker missing tab-completion in bash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 117549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117549&action=edit Bug 27839: Add tab-completion in bash for koha-worker This patch simply adds tab-completion for this script. To test: 1. Apply this patch 2. Run: $ cp debian/koha-common.bash-completion /etc/bash_completion.d/koha-common 3. Open a new bash instance 4. Type 'koha-worker ' => SUCCESS: All options are there 5. Play with Koha instances => SUCCESS: they show up, once chosen they are not offered anymore 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 20:36:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 19:36:16 +0000 Subject: [Koha-bugs] [Bug 27839] koha-worker missing tab-completion in bash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27839 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 117550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117550&action=edit Bug 27839: (follow-up) Update docs for koha-worker Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 21:08:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 20:08:16 +0000 Subject: [Koha-bugs] [Bug 24309] Holds on multiple in the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24309 Marie-Luce Laflamme changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme at inlibro | |.com --- Comment #1 from Marie-Luce Laflamme --- A new feature on the Opac would be a great help for library users who would love to place holds on different volumes within a record. For example, when placing holds in a serial (or manga) record, you could select more than one item in the record. This way you could select Vol. X, Vol. Y and Vol. Z all at once, instead of placing each hold separately. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 21:23:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 20:23:36 +0000 Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and subscriptions tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842 [Bug 27842] Incorrect biblionumber handling in serials subscriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 21:23:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 20:23:36 +0000 Subject: [Koha-bugs] [Bug 27842] Incorrect biblionumber handling in serials subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27842 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21901 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 [Bug 21901] Foreign keys are missing on the serials and subscriptions tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 21:24:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 20:24:31 +0000 Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and subscriptions tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #35 from Nick Clemens --- See bug 27842 - this potentially causes data loss during upgrades -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 21:36:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 20:36:00 +0000 Subject: [Koha-bugs] [Bug 27843] New: Editing item's Collection code sets items.cn_sort to NULL Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27843 Bug ID: 27843 Summary: Editing item's Collection code sets items.cn_sort to NULL Change sponsored?: --- Product: Koha Version: 20.11 Hardware: Other OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pgm0203 at comcast.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 117551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117551&action=edit Current Server Information Moving a single item to a different collection---by editing the item in the Staff Interface and selecting a different value in the Collection code menu---has the side effect of setting the items.cn_sort field for that item to NULL. As a result, the item disappears from the OPAC shelf browser, and initiating shelf browsing from that item fails. For example, moving Item 681 from ART to NFIC: Before: +------------+-------+--------------------+-----------------------+ | itemnumber | ccode | itemcallnumber | cn_sort | +------------+-------+--------------------+-----------------------+ | 681 | ART | ND553.R45 A4 2010a | ND0553 R45 A4 02010A | +------------+-------+--------------------+-----------------------+ After: +------------+-------+--------------------+---------+ | itemnumber | ccode | itemcallnumber | cn_sort | +------------+-------+--------------------+---------+ | 681 | NFIC | ND553.R45 A4 2010a | NULL | +------------+-------+--------------------+---------+ After manually restoring the content of the items.cn_sort field, the item reappears in the shelf browser in the destination collection. I'm running Koha 20.11 on a Raspberry Pi 4B (it's my personal library). I have ShelfBrowserUsesCcode turned on and use LoC Classification for call numbers. I have attached my current Server Information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 21:42:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 20:42:06 +0000 Subject: [Koha-bugs] [Bug 27592] Link audio alerts to corresponding preference and back In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27592 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 21:57:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 20:57:43 +0000 Subject: [Koha-bugs] [Bug 24309] Holds on multiple in the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24309 --- Comment #2 from Christopher Brannon --- In addition to a batch feature, if the Holds per record column in the circulation rules has Unlimited or any value over 1 entered, it would be great if the radio buttons under the requestspecific table on request.pl could be changed to checkboxes and would allow the patron to select up to the number set in the circulation rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 22:22:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 21:22:47 +0000 Subject: [Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 22:27:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 21:27:27 +0000 Subject: [Koha-bugs] [Bug 25841] Manual should reference update_patrons_category.pl rather than j2a.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25841 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #2 from Caroline Cyr La Rose --- This is done in 20.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 23:16:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 22:16:28 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #37 from David Cook --- (In reply to Fridolin Somers from comment #36) > Also maybe needs Type=forking ? > > https://www.freedesktop.org/software/systemd/man/systemd.service.html#Type= I don't think so since it doesn't fork when it starts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 23:21:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 22:21:09 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #38 from David Cook --- (In reply to Martin Renvoize from comment #34) > (In reply to Fridolin Somers from comment #32) > > koha-worker will run as root. > > Shouldn't we run as koha user for package install, as www-data for dev > > install ? > > Good call.. can't believe I didn't spot that! Good catch, Frido. Yes, the package install should be "%i-koha". As for a source/dev install, I'm not 100% sure what it should be. I suppose it depends on what the background worker needs to do. In theory, www-data shouldn't be needed, but I suppose there might be something that the web server has written as www-data which the background worker needs to manage? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 23:24:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 22:24:23 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #39 from David Cook --- (In reply to David Cook from comment #38) > As for a source/dev install, I'm not 100% sure what it should be. I suppose > it depends on what the background worker needs to do. In theory, www-data > shouldn't be needed, but I suppose there might be something that the web > server has written as www-data which the background worker needs to manage? Source/dev installs require extra work anyway so that one might be solved by documentation... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 23:26:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 22:26:00 +0000 Subject: [Koha-bugs] [Bug 27844] New: koha-worker systemd service should run as %i-koha in package install Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 Bug ID: 27844 Summary: koha-worker systemd service should run as %i-koha in package install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Frido pointed out that koha-worker will run as root in a package install because we haven't specified a lower privileged Koha-specific user. See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363#c32. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 23:26:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 22:26:46 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #22 from David Cook --- (In reply to Martin Renvoize from comment #21) > With bug 26363 adding a systemd unit file.. it raises the question of should > this patch also do something for that.. Fridolin quite rightly raised > questions about what user the unit worker should be running under. I don't think so. I think that should be hard-coded to "%i-koha" like the rest of package Koha. Certainly a good catch by Frido though. I've opened bug 27844 for it. I'll do a patch for it quickly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 23:27:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 22:27:05 +0000 Subject: [Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 [Bug 26363] Provide a systemd unit file for background_jobs_worker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 23:27:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 22:27:05 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 [Bug 27844] koha-worker systemd service should run as %i-koha in package install -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 23:27:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 22:27:20 +0000 Subject: [Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 2 23:57:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 22:57:28 +0000 Subject: [Koha-bugs] [Bug 27845] New: cash_management needs default register setting Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27845 Bug ID: 27845 Summary: cash_management needs default register setting Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org If your library has more than one register, you may have to select a different register constantly. I would suggest adding a dropdown in the cash_management permission setting for the user to select their default register from a list of registers for their library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 3 00:05:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 23:05:47 +0000 Subject: [Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 --- Comment #1 from David Cook --- And I just remembered that we can't securely use systemd in a container, and trying to do so for testing purposes is challenging as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 3 00:06:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 23:06:16 +0000 Subject: [Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25674 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 3 00:06:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 23:06:16 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27844 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 3 00:36:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 23:36:29 +0000 Subject: [Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 --- Comment #2 from David Cook --- Created attachment 117552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117552&action=edit Bug 27844: Launch koha-worker systemd service as koha linux user This patch adds the User directive to the koha-worker systemd unit file Test plan: 0a. DO NOT APPLY PATCH YET 0b. Start a Koha testing environment running systemd 1. koha-worker --stop kohadev 2. cp debian/templates/koha-worker at .service /etc/systemd/system/. 3. systemctl start koha-worker at kohadev.service 4. ps -efww | grep "background_jobs_worker" 5. Note koha-worker is running as root 6. APPLY THE PATCH 7. cp debian/templates/koha-worker at .service /etc/systemd/system/. 8. systemctl daemon-reload 9. systemctl restart koha-worker at kohadev.service 10. ps -efww | grep "background_jobs_worker" 11. Note that koha-worker is now running as kohadev-koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 3 00:39:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Mar 2021 23:39:06 +0000 Subject: [Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 --- Comment #3 from David Cook --- Here are some instructions on how to create a koha-testing-docker container with Systemd using Docker: Systemd in container (insecurely): 0. Build an image FROM koha/koha-testing:master 1. Install systemd and systemd-sysv 2. CMD ["/sbin/init"] 3. Update your docker-compose file to use this new systemd image for koha container 4. Update your docker-compose file to use "privileged: true" to the koha container 5. Enter into the koha container and run /kohadevbox/run.sh by hand 6. systemctl daemon-reload 7. service koha-common stop 8. service koha-common start -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 3 01:04:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Mar 2021 00:04:23 +0000 Subject: [Koha-bugs] [Bug 27844] koha-worker systemd service should run as %i-koha in package install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27844 --- Comment #4 from David Cook --- Alternative (more secure) systemd inspired by https://developers.redhat.com/blog/2016/09/13/running-systemd-in-a-non-privileged-container/: Systemd in container (insecurely): 0. Build an image FROM koha/koha-testing:master 1. Install systemd and systemd-sysv 2. CMD ["/sbin/init"] 3. Update your docker-compose file to use this new systemd image for koha container 4. Update your docker-compose file to have a volume "/sys/fs/cgroup:/sys/fs/cgroup:ro" for the koha container 5. Enter into the koha container and run /kohadevbox/run.sh by hand 6. systemctl daemon-reload 7. service koha-common stop 8. service koha-common start -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 3 01:15:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Mar 2021 00:15:00 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #23 from Tomás Cohen Arazi --- I clearly don't understand the need for the unit file, but it looks like the process shouldn't be running as root https://git.koha-community.org/Koha-community/Koha/src/branch/master/debian/scripts/koha-worker#L70 The shipped unit files are not linked to koha-create so I assume they are just not used. They are shipped just in case someone wants to use them. The current scripts make it easy not to depend on systemd (KTD) and things like koha-docker rely on supervisord. My feeling is we need a good rfc to discuss the ultimate goal, and each involved detail. Adding a hard dependency on systemd specifics can have some impact, that needs to be pondered. I support this work, I just would like more clear goals. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 3 01:16:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Mar 2021 00:16:09 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #24 from Tomás Cohen Arazi --- And I don't understand how this didn't get into 20.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 3 02:30:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Mar 2021 01:30:03 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #25 from David Cook --- (In reply to Tomás Cohen Arazi from comment #23) > I clearly don't understand the need for the unit file, but it looks like > the process shouldn't be running as root > > https://git.koha-community.org/Koha-community/Koha/src/branch/master/debian/ > scripts/koha-worker#L70 > You're mixing up a couple things here. The "daemon" based koha-worker runs as -koha. It's all good. The issue is only with the systemd unit file from a different bug report. The systemd unit file would run the background worker as root (without the patch from 27844). I've already confirmed it in testing. > The shipped unit files are not linked to koha-create so I assume they are > just not used. They are shipped just in case someone wants to use them. > I think you're right. > The current scripts make it easy not to depend on systemd (KTD) and things > like koha-docker rely on supervisord. > supervisord would just be an alternative to systemd for process management. You shouldn't be using "daemon" with supervisord if I recall correctly. Can you elaborate on that point? As for koha-testing-docker... I think it would benefit from different process management anyway. (For what it's worth, I use ubi-init for a legacy app on Red Hat 8, which uses systemd in containers, and it works quite well for a multi-service container.) > My feeling is we need a good rfc to discuss the ultimate goal, and each > involved detail. Adding a hard dependency on systemd specifics can have some > impact, that needs to be pondered. > > I support this work, I just would like more clear goals. I agree. I've been saying for many years that we need goals and a long-term project roadmap instead of just stumbling along all separately. I think Jonathan has done great to make per-release road maps, but it would be good for there to be some discussion and consensus on where the project is going technically-speaking. Personally, I would like the community to pursue containerization, but I don't really see it happening. There's too much technical debt, moving parts, container inexperience, inertia, etc. I find systemd to be much better than "daemon" when working on a full VM. When it comes to containers, we should be using a different approach to process management anyway. If we want to do multiple services in a container, we could use systemd (see bug 27844). Or we could use supervisord. I know that supervisord is considered a "moderately heavy-weight" approach according to https://docs.docker.com/config/containers/multi-service_container/, but koha_koha_1 is a heavy-weight container. Anyway, I think we're off topic at this point anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 3 04:43:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Mar 2021 03:43:09 +0000 Subject: [Koha-bugs] [Bug 27846] New: Accessibility: Staff Client - Breadcrumbs should be more accessible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846 Bug ID: 27846 Summary: Accessibility: Staff Client - Breadcrumbs should be more accessible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: wainuiwitikapark at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Breadcrumbs should adhere to the guidelines in https://www.w3.org/TR/wai-aria-practices-1.1/examples/breadcrumb/index.html i.e. be a