[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #98 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 113967
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113967
Bug 22690: Refactor merging of records to improve performance (Elasticsearch)

Review of attachment 113967:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22690&attachment=113967)
-----------------------------------------------------------------

::: Koha/Item.pm
@@ +1064,5 @@
> +sub item_orders {
> +    my ( $self ) = @_;
> +
> +    my $orders = $self->_result->item_orders;
> +    return Koha::Acquisition::Orders->_new_from_dbic($orders);

In it's current form, this can result in failure..  I'm not seeing any handling
for that...

i.e. if an item is deleted it gets moved to deleted_items but the itemnumber
remains in the aqorder_items table as there is no foreign key constraint.. have
you tested this case?

-- 
You are receiving this mail because:
You are watching all bug changes.