[Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order"

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708

Peter Vashchuk <stalkernoid at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117453|0                           |1
        is obsolete|                            |

--- Comment #2 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 117455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117455&action=edit
Bug 27708: unify two item object creation blocks to be stored as hash

Previously for existing item data was stored as an object reference and 
then treated as one, but for not yet existing item data was stored as 
keys in hash reference in the same variable and later it was treated 
like an object, hence why it crashed with "no method". 
This patch unifies that variable in both cases filled as hash and 
treated as such.

To reproduce:
    1) Go to "Administration->System preferences" and change
"AcqCreateItem" to "receiving an order."
    2) Now, go to "Acquisitions" and create a new Vendor,
or use an existing one.
    3) Next, go to "Administration->EDI Account" and add EDI account
(pick that Vendor that you created recently, or the one that you will
use for this test).
    4) Also in "Administration->Library EANs" add EAN if you didn't
have one previously.
    5) Go back to "Acquisitions" and add a new basket to your Vendor
that you will use for this test.
    6) Press "Create EDIFACT order" button. It should throw
"Can't call method "homebranch" on unblessed reference..."
software error.
    7) Apply the patch.
    8) Reload the page that threw software error previously
(or repeat steps 5, 6 if you need another basket),
it should go through now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.