[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

--- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hum, there is a test failing that may be related to this, but I don't recreate
locally (D9_My8):

16:25:53 koha_1       |         #   Failed test 'Module
Koha::AuthSubfieldStructures should have koha_object[s]_class method if needed'
16:25:53 koha_1       |         #   at t/db_dependent/TestBuilder.t line 402.
16:25:53 koha_1       |         #          got: 'Can't locate object method
"_new_from_dbic" via package "Koha::Authority::Subfield" (perhaps you forgot to
load "Koha::Authority::Subfield"?) at /kohadevbox/koha/Koha/Object.pm line 335.
16:25:53 koha_1       |         # '
16:25:53 koha_1       |         #     expected: ''
16:26:47 koha_1       |         # Looks like you failed 1 test of 526.
16:26:47 koha_1       | 
16:26:47 koha_1       |     #   Failed test 'Test all classes'
16:26:47 koha_1       |     #   at t/db_dependent/TestBuilder.t line 413.
16:26:48 koha_1       |     # Looks like you failed 1 test of 5.



However I found an inconsistency. Those patches introduced
Koha::AuthSubfieldStructure[s], but we already had
Koha::Authority::Subfield[s].
It also introduced Koha::MarcSubfieldStructure[s].

What about:
Koha::Framework::Biblio::Subfield[s]
Koha::Framework::Authority::Subfield[s]

Then later:
Koha::Framework::Biblio::Tag[s]
Koha::Framework::Authority::Tag[s]

Or... Koha::MARC::Biblio::Subfield? Koha::MARCStructure::Biblio::Subfield?

Or... Koha::Framework::Subfield::Biblio and Koha::FrameworkSubfield::Authority
that would inherit from Koha::Framework::Subfield. But then we need to drop the
plural forms.

-- 
You are receiving this mail because:
You are watching all bug changes.