[Koha-bugs] [Bug 27834] New: CircControl syspref is used wrong in TooMany function C4::Circulation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27834

            Bug ID: 27834
           Summary: CircControl syspref is used wrong in TooMany function
                    C4::Circulation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at helsinki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The CircControl syspref description says

> Use the checkout and fines rules of
>   PickupLibrary: the library you are logged in at.
>   PatronLibrary: the library the patron is from.
>   ItemHomeLibrary: the library the item is from.

This is mostly true but there is one exception in the TooMany function where it
actually doesn't just change which libraries rules are used but how the the
calculation is performed.

With PatronLibrary set the behaviour is as expected by reading the syspref
description. However with the setting PickupLibrary the behaviour changes now,
instead of just using the rules of the pickup library we also only take into
account the loans in the pickup library when calculating whether we are over
the checkout limit or not. The same happens with ItemHomeLibrary where we
instead calculate the patron's checkouts in the home library of the item being
checked out.

We should really try to fix this either by

a) showing that ItemHomeLibrary and PickupLibrary is unacceptable and no one
actually wants that, that would allow then making the behaviour similar as what
it is to PatronLibrary (so just selecting the right circ rule instead of
changing calculation method).

b) Provide a new syspref for changing the calcutation method when PickupLibrary
or ItemHomeLibrary CircControl values are used, and set it on upgrade enabled
as default.


Ps. svc/letters/preview might use CirControl wrongly as well, I'm not 100% I
didn't quite understand but as for other usages of CircControl syspref I
grepped where it was used and it correctly only changed the circ rules to be
used instead of changing behaviour. So in addition to TooMany we might have to
do some changes to svc/letters/preview if it turns out it changes behaviour as
well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.