[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

--- Comment #47 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Joonas Kylmälä from comment #46)
> (In reply to Jonathan Druart from comment #44)
> > -            if ( $res->{'itemnumber'} && $res->{'itemnumber'} ==
> > $itemnumber && $res->{'priority'} == 0) {
> > 
> > Why did you remove that test?
> 
> Thanks for asking. The reason I removed the line is because it equivalent of
> a reserve being found / attached and now we finally handle all the different
> cases so doing the check twice is not necessary. If you look at the patch
> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67411 (bug
> 19116) then it should be really clear. Previously the "Reserved" return
> value had double usage/meaning, firstly it could mean an unattached hold
> (biblio or item level) or secondly it could have meant an attached hold in
> transfer. Please see the explanation also in the commit message.

And to explain even a bit more verbosely: The "$res->{'priority'} == 0" makes
the hold found/attached (when combined together with itemnumber).

-- 
You are receiving this mail because:
You are watching all bug changes.