[Koha-bugs] [Bug 27879] New: Koha::Hold::is_at_destination function should be removed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27879

            Bug ID: 27879
           Summary: Koha::Hold::is_at_destination function should be
                    removed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at helsinki.fi
        QA Contact: testopia at bugs.koha-community.org

Currently Koha::Hold::is_at_destination looks to be unnecessary and it could be
replaced with Koha::Hold::is_waiting. However, to make sure nobody adds any
code paths in the future we should add some checks to Koha::Hold::set_waiting
so that it wouldn't allow set Hold waiting if the item's holding branch is not
the hold's pickup library. We should also make sure that e.g. a transfer cannot
be initiated for a waiting hold without the hold status going to in transit.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.