[Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058

--- Comment #27 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Jonathan Druart from comment #26)
> Joonas, can you add a comment next to this notforloan test to explain why we
> did this change? It's not obvious when we read the code at first to
> understand why we need it in IsAvailableForItemLevelRequest but
> ItemsAnyAvailableAndNotRestricted.

I'm not sure additional comment would help much more than the one above "[...]
if at least one item available for loan/check out[...]". I don't see this test
being any different from the other ones:

$i->itemlost
$i->withdrawn
$i->onloan

etc.

Somebody just probably mistakenly thought we did holdability test instead of
checkoutability test, thus the bug here. I would not add additional comment
because the comment above is already explaining this but instead what we should
do is split the function to two and give them better names (the any available
part and restricted parts).

-- 
You are receiving this mail because:
You are watching all bug changes.