[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Gracefully stop             |Update DB process - wrap
                   |updatedatabase/installer    |each DBRev inside a
                   |when a database change      |transaction and better
                   |cannot be applied           |error handling

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #44)
> So, the goal of this bug report is to go from attachment 102521 [details] to
> https://snipboard.io/lpETMg.jpg ?

Yes, and the transaction.

> I suggest to change the bug title then, because it was not clear to me. From
> my point of view the updatedatabase is already stopped gracefully (with an
> ugly error message, yes, but the error is handled and shown to the user).

Yes, it is now (with bug 25026 pushed), not when the bug report was opened
(neither when I wrote the first version).

> I agree that bug 27880 is out of scope here, but it can answer problem
> number 2 quite easily.
> 
> Maybe we can find an intermediate step before going to bug 27880, but
> without having to rewrite everything twice.
> For instance, keep the file naming conventions of 27880, but with the
> version added. Something like:
> 20210305153137-201200013-create-table-foo.pl (I prefer .pl over .pm because
> there is no need to duplicate the name inside the file)
> The database version can still be extracted from the file name, like in your
> 3rd patch. And the upgrade path to 27880 should be straightforward
> 
> Is that what you had in mind when you said "- move forward with my patches
> with Julian's idea in mind (adjustments are needed)" ?

Exactly! :)

-- 
You are receiving this mail because:
You are watching all bug changes.